Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update develop-ref after dtcenter/MET#2838 #2839

Merged
merged 38 commits into from
Mar 14, 2024

Commits on Feb 2, 2024

  1. 2673 Moved dvariable declaration after include

    Howard Soh committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    d8572b9 View commit details
    Browse the repository at this point in the history
  2. #2673 Move down namespace below include

    Howard Soh committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    6ebfdac View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Feature #2395 wdir (#2820)

    * Per #2395, add new columns to VL1L2, VAL1L2, and VCNT line types for wind direction statistics. Work still in progress.
    
    * Per #2395, write the new VCNT columns to the output and document the additions to the VL1L2, VAL1L2, and VCNT columns.
    
    * Per #2395, add the definition of new statistics to Appendix G.
    
    * Per #2395, update file version history.
    
    * Per #2395, tweak warning message about zero wind vectors and update grid-stat and point-stat to log calls to the do_vl1l2() function.
    
    * Per #2395, refine the weights for wind direction stats, ignoring the undefined directions.
    
    * Update src/tools/core/stat_analysis/aggr_stat_line.cc
    
    * Update src/tools/core/stat_analysis/parse_stat_line.cc
    
    * Update src/tools/core/stat_analysis/aggr_stat_line.cc
    JohnHalleyGotway committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    c788602 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Recent changes to branch protection rules for the develop branch have…

    … broken the logic of the update_truth.yml GHA workflow. Instead of submitting a PR to merge develop into develop-ref directly, use an intermediate update_truth_for_develop branch.
    JohnHalleyGotway committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    67ee04e View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Feature #2280 ens_prob (#2823)

    * Per #2280, update to support probability threshold strings like ==8, where 8 is the number of ensemble members, to create probability bins centered on the n/8 for n = 0 ... 8.
    
    * Per #2280, update docs about probability threshold settings.
    
    * Per #2280, use a loose tolerance when checking for consistent bin widths.
    
    * Per #2280, add a new unit test for grid_stat to demonstrate processing the output from gen_ens_prod.
    
    * Per #2280, when verifying NMEP probability forecasts, smooth the obs data first.
    
    * Per #2280, only request STAT output for the PCT line type to match unit_grid_stat.xml and minimize the new output files.
    
    * Per #2280, update config option docs.
    
    * Per #2280, update config option docs.
    JohnHalleyGotway committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    b558794 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'origin/develop' into feature_2673_sonar…

    …qube_beta3_namespace
    Howard Soh committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    069cdbd View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. #2673 Change 0 to nullptr

    Howard Soh committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    7f513eb View commit details
    Browse the repository at this point in the history
  2. #2673 Change 0 to nullptr

    Howard Soh committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    7483636 View commit details
    Browse the repository at this point in the history
  3. #2673 Change 0 to nullptr

    Howard Soh committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    f33de8e View commit details
    Browse the repository at this point in the history
  4. #2673 Change 0 to nullptr

    Howard Soh committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    c1e99ea View commit details
    Browse the repository at this point in the history
  5. #2673 Change 0 to nullptr

    Howard Soh committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    6c30e49 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #2827 from dtcenter/feature_2673_sonarqube_beta3_n…

    …ullptr
    
    Feature 2673 sonarqube beta4 nullptr
    hsoh-u committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    5cca97e View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. #2673 Removed the redundant parentheses with return

    Howard Soh committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    83730cf View commit details
    Browse the repository at this point in the history
  2. #2673 Removed the redundant parentheses with return

    Howard Soh committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    4d60e06 View commit details
    Browse the repository at this point in the history
  3. #2673 Removed the redundant parentheses with return

    Howard Soh committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    3ff3767 View commit details
    Browse the repository at this point in the history
  4. #2673 Removed the redundant parentheses with return

    Howard Soh committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    55f5d3e View commit details
    Browse the repository at this point in the history
  5. #2673 Removed the redundant parentheses with return

    Howard Soh committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    6bb41bc View commit details
    Browse the repository at this point in the history
  6. #2673 Merged develop branch

    Howard Soh committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    d82a979 View commit details
    Browse the repository at this point in the history
  7. #2673 restored return statement

    Howard Soh committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    481bb15 View commit details
    Browse the repository at this point in the history
  8. Merge pull request #2828 from dtcenter/feature_2673_sonarqube_beta3_r…

    …eturn
    
    Feature 2673 sonarqube beta4 return
    hsoh-u committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    00b162b View commit details
    Browse the repository at this point in the history
  9. #2673 Added std namespace

    Howard Soh committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    bc7af99 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    e872917 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. #2673 Moved down 'using namespace' statement.

    Howard Soh committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    3eb4367 View commit details
    Browse the repository at this point in the history
  2. #2673 Moved down 'using namespace' statement.

    Howard Soh committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    3f92f6a View commit details
    Browse the repository at this point in the history
  3. #2673 Moved down 'using namespace' statement.

    Howard Soh committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    a00c7be View commit details
    Browse the repository at this point in the history
  4. #2673 Moved down 'using namespace' statement.

    Howard Soh committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    5706e97 View commit details
    Browse the repository at this point in the history
  5. Merge remote-tracking branch 'origin/develop' into feature_2673_sonar…

    …qube_beta3_namespace
    Howard Soh committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    4821c37 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. #2673 Added std namespace

    Howard Soh committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    2509f7c View commit details
    Browse the repository at this point in the history
  2. #2673 Added std namespace

    Howard Soh committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    ca64f00 View commit details
    Browse the repository at this point in the history
  3. #2673 Added std namespace

    Howard Soh committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    a7f0e06 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Merge pull request #2831 from dtcenter/feature_2673_sonarqube_beta3_n…

    …amespace
    
    Feature 2673 sonarqube beta3 namespace
    hsoh-u committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    0b2a7da View commit details
    Browse the repository at this point in the history
  2. #2673 Changed literal 1 to boolean value, true

    Howard Soh committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    0ab2466 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Merge pull request #2832 from dtcenter/feature_2673_sonarqube_1_to_true

    #2673 Changed literal 1 to the boolean value, true
    hsoh-u committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    4d7d4a2 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Configuration menu
    Copy the full SHA
    a6f7646 View commit details
    Browse the repository at this point in the history
  2. Feature #2583 ecnt (#2825)

    * Unrelated to #2583, fix typo in code comments.
    
    * Per #2583, add hooks write 3 new ECNT columns for observation error data.
    
    * Per #2583, make error messages about mis-matched array lengths more informative.
    
    * Per #2583, switch to more concise variable naming conventions of ign_oerr_cnv, ign_oerr_cor, and dawid_seb.
    
    * Per #2583, fix typo to enable compilation
    
    * Per #2583, define the 5 new ECNT column names.
    
    * Per #2583, add 5 new columns to the ECNT table in the Ensemble-Stat chapter
    
    * Per #2583, update stat_columns.cc to write these 5 new ECNT columns
    
    * Per #2583, update ECNTInfo class to compute the 5 new ECNT statistics.
    
    * Per #2583, update stat-analysis to parse the 5 new ECNT columns.
    
    * Per #2583, update aggregate_stat logic for 5 new ECNT columns.
    
    * Per #2583, update PairDataEnsemble logic for 5 new ECNT columns
    
    * Per #2583, update vx_statistics library with obs_error handling logic for the 5 new ECNT columns
    
    * Per #2583, changes to make it compile
    
    * Per #2583, changes to make it compile
    
    * Per #2583, switch to a consistent ECNT column naming convention with OERR at the end. Using IGN_CONV_OERR and IGN_CORR_OERR.
    
    * Per #2583, define ObsErrorEntry::variance() with a call to the dist_var() utility function.
    
    * Per #2583, update PairDataEnsemble::compute_pair_vals() to compute the 5 new stats with the correct inputs.
    
    * Per #2583, add DEBUG(10) log messages about computing these new stats.
    
    * Per #2583, update Stat-Analysis to compute these 5 new stats from the ORANK line type.
    
    * Per #2583, whitespace and comments.
    
    * Per #2583, update the User's Guide.
    
    * Per #2583, remove the DS_ADD_OERR and DS_MULT_OERR ECNT columns and rename DS_OERR as DSS, since observation error is not actually involved in its computation.
    
    * Per #2583, minor update to Appendix C
    
    * Per #2583, rename ECNT line type statistic DSS to IDSS.
    
    * Per #2583, fix a couple of typos
    
    * Per #2583, more error checking.
    
    * Per #2583, remove the ECNT IDSS column since its just 2*pi*IGN, the existing ignorance score, and only provides meaningful information when combined with the other Dawid-Sebastiani statistics that have already been removed.
    
    * Per #2583, add Eric's documentation of these new stats to Appendix C. Along the way, update the DOI links in the references based on this APA style guide: https://apastyle.apa.org/style-grammar-guidelines/references/dois-urls#:~:text=Include%20a%20DOI%20for%20all,URL%2C%20include%20only%20the%20DOI.
    
    * Per #2583, fix new equations with embedded underscores for PDF by defining both html and pdf formatting options.
    
    * Per #2583, update the ign_conv_oerr equation to include a 2
    *pi multiplier for consistency with the existing ignorance score. Also, fix the documented equations.
    
    * Per #2583, remove log file that was inadvertently added on this branch.
    
    * Per #2583, simplify ObsErrorEntry::variance() implementation. For the distribution type of NONE, return a variance of 0.0 rather than bad data, as discussed with @michelleharrold and @JeffBeck-NOAA on 3/8/2024.
    
    ---------
    
    Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
    JohnHalleyGotway and MET Tools Test Account committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    108a895 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4c322aa View commit details
    Browse the repository at this point in the history
  4. Feature #2583 ecnt fix IGN_OERR_CORR (#2838)

    * Unrelated to #2583, fix typo in code comments.
    
    * Per #2583, add hooks write 3 new ECNT columns for observation error data.
    
    * Per #2583, make error messages about mis-matched array lengths more informative.
    
    * Per #2583, switch to more concise variable naming conventions of ign_oerr_cnv, ign_oerr_cor, and dawid_seb.
    
    * Per #2583, fix typo to enable compilation
    
    * Per #2583, define the 5 new ECNT column names.
    
    * Per #2583, add 5 new columns to the ECNT table in the Ensemble-Stat chapter
    
    * Per #2583, update stat_columns.cc to write these 5 new ECNT columns
    
    * Per #2583, update ECNTInfo class to compute the 5 new ECNT statistics.
    
    * Per #2583, update stat-analysis to parse the 5 new ECNT columns.
    
    * Per #2583, update aggregate_stat logic for 5 new ECNT columns.
    
    * Per #2583, update PairDataEnsemble logic for 5 new ECNT columns
    
    * Per #2583, update vx_statistics library with obs_error handling logic for the 5 new ECNT columns
    
    * Per #2583, changes to make it compile
    
    * Per #2583, changes to make it compile
    
    * Per #2583, switch to a consistent ECNT column naming convention with OERR at the end. Using IGN_CONV_OERR and IGN_CORR_OERR.
    
    * Per #2583, define ObsErrorEntry::variance() with a call to the dist_var() utility function.
    
    * Per #2583, update PairDataEnsemble::compute_pair_vals() to compute the 5 new stats with the correct inputs.
    
    * Per #2583, add DEBUG(10) log messages about computing these new stats.
    
    * Per #2583, update Stat-Analysis to compute these 5 new stats from the ORANK line type.
    
    * Per #2583, whitespace and comments.
    
    * Per #2583, update the User's Guide.
    
    * Per #2583, remove the DS_ADD_OERR and DS_MULT_OERR ECNT columns and rename DS_OERR as DSS, since observation error is not actually involved in its computation.
    
    * Per #2583, minor update to Appendix C
    
    * Per #2583, rename ECNT line type statistic DSS to IDSS.
    
    * Per #2583, fix a couple of typos
    
    * Per #2583, more error checking.
    
    * Per #2583, remove the ECNT IDSS column since its just 2*pi*IGN, the existing ignorance score, and only provides meaningful information when combined with the other Dawid-Sebastiani statistics that have already been removed.
    
    * Per #2583, add Eric's documentation of these new stats to Appendix C. Along the way, update the DOI links in the references based on this APA style guide: https://apastyle.apa.org/style-grammar-guidelines/references/dois-urls#:~:text=Include%20a%20DOI%20for%20all,URL%2C%20include%20only%20the%20DOI.
    
    * Per #2583, fix new equations with embedded underscores for PDF by defining both html and pdf formatting options.
    
    * Per #2583, update the ign_conv_oerr equation to include a 2
    *pi multiplier for consistency with the existing ignorance score. Also, fix the documented equations.
    
    * Per #2583, remove log file that was inadvertently added on this branch.
    
    * Per #2583, simplify ObsErrorEntry::variance() implementation. For the distribution type of NONE, return a variance of 0.0 rather than bad data, as discussed with @michelleharrold and @JeffBeck-NOAA on 3/8/2024.
    
    * Per #2583, updates to ensemble-stat.rst recommended by @michelleharrold and @JeffBeck-NOAA.
    
    * Per #2583, implement changes to the IGN_CORR_OERR corrected as directed by @ericgilleland.
    
    ---------
    
    Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
    JohnHalleyGotway and MET Tools Test Account committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    fd1b250 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    db52ebd View commit details
    Browse the repository at this point in the history