-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update develop-ref after dtcenter/MET#2918 #2922
Commits on Feb 2, 2024
-
2673 Moved dvariable declaration after include
Howard Soh committedFeb 2, 2024 Configuration menu - View commit details
-
Copy full SHA for d8572b9 - Browse repository at this point
Copy the full SHA d8572b9View commit details -
#2673 Move down namespace below include
Howard Soh committedFeb 2, 2024 Configuration menu - View commit details
-
Copy full SHA for 6ebfdac - Browse repository at this point
Copy the full SHA 6ebfdacView commit details
Commits on Feb 14, 2024
-
* Per #2395, add new columns to VL1L2, VAL1L2, and VCNT line types for wind direction statistics. Work still in progress. * Per #2395, write the new VCNT columns to the output and document the additions to the VL1L2, VAL1L2, and VCNT columns. * Per #2395, add the definition of new statistics to Appendix G. * Per #2395, update file version history. * Per #2395, tweak warning message about zero wind vectors and update grid-stat and point-stat to log calls to the do_vl1l2() function. * Per #2395, refine the weights for wind direction stats, ignoring the undefined directions. * Update src/tools/core/stat_analysis/aggr_stat_line.cc * Update src/tools/core/stat_analysis/parse_stat_line.cc * Update src/tools/core/stat_analysis/aggr_stat_line.cc
Configuration menu - View commit details
-
Copy full SHA for c788602 - Browse repository at this point
Copy the full SHA c788602View commit details
Commits on Feb 15, 2024
-
Recent changes to branch protection rules for the develop branch have…
… broken the logic of the update_truth.yml GHA workflow. Instead of submitting a PR to merge develop into develop-ref directly, use an intermediate update_truth_for_develop branch.
Configuration menu - View commit details
-
Copy full SHA for 67ee04e - Browse repository at this point
Copy the full SHA 67ee04eView commit details
Commits on Feb 22, 2024
-
Feature #2280 ens_prob (#2823)
* Per #2280, update to support probability threshold strings like ==8, where 8 is the number of ensemble members, to create probability bins centered on the n/8 for n = 0 ... 8. * Per #2280, update docs about probability threshold settings. * Per #2280, use a loose tolerance when checking for consistent bin widths. * Per #2280, add a new unit test for grid_stat to demonstrate processing the output from gen_ens_prod. * Per #2280, when verifying NMEP probability forecasts, smooth the obs data first. * Per #2280, only request STAT output for the PCT line type to match unit_grid_stat.xml and minimize the new output files. * Per #2280, update config option docs. * Per #2280, update config option docs.
Configuration menu - View commit details
-
Copy full SHA for b558794 - Browse repository at this point
Copy the full SHA b558794View commit details -
Merge remote-tracking branch 'origin/develop' into feature_2673_sonar…
…qube_beta3_namespace
Howard Soh committedFeb 22, 2024 Configuration menu - View commit details
-
Copy full SHA for 069cdbd - Browse repository at this point
Copy the full SHA 069cdbdView commit details
Commits on Feb 27, 2024
-
Howard Soh committed
Feb 27, 2024 Configuration menu - View commit details
-
Copy full SHA for 7f513eb - Browse repository at this point
Copy the full SHA 7f513ebView commit details -
Howard Soh committed
Feb 27, 2024 Configuration menu - View commit details
-
Copy full SHA for 7483636 - Browse repository at this point
Copy the full SHA 7483636View commit details -
Howard Soh committed
Feb 27, 2024 Configuration menu - View commit details
-
Copy full SHA for f33de8e - Browse repository at this point
Copy the full SHA f33de8eView commit details -
Howard Soh committed
Feb 27, 2024 Configuration menu - View commit details
-
Copy full SHA for c1e99ea - Browse repository at this point
Copy the full SHA c1e99eaView commit details -
Howard Soh committed
Feb 27, 2024 Configuration menu - View commit details
-
Copy full SHA for 6c30e49 - Browse repository at this point
Copy the full SHA 6c30e49View commit details -
Merge pull request #2827 from dtcenter/feature_2673_sonarqube_beta3_n…
…ullptr Feature 2673 sonarqube beta4 nullptr
Configuration menu - View commit details
-
Copy full SHA for 5cca97e - Browse repository at this point
Copy the full SHA 5cca97eView commit details
Commits on Feb 28, 2024
-
#2673 Removed the redundant parentheses with return
Howard Soh committedFeb 28, 2024 Configuration menu - View commit details
-
Copy full SHA for 83730cf - Browse repository at this point
Copy the full SHA 83730cfView commit details -
#2673 Removed the redundant parentheses with return
Howard Soh committedFeb 28, 2024 Configuration menu - View commit details
-
Copy full SHA for 4d60e06 - Browse repository at this point
Copy the full SHA 4d60e06View commit details -
#2673 Removed the redundant parentheses with return
Howard Soh committedFeb 28, 2024 Configuration menu - View commit details
-
Copy full SHA for 3ff3767 - Browse repository at this point
Copy the full SHA 3ff3767View commit details -
#2673 Removed the redundant parentheses with return
Howard Soh committedFeb 28, 2024 Configuration menu - View commit details
-
Copy full SHA for 55f5d3e - Browse repository at this point
Copy the full SHA 55f5d3eView commit details -
#2673 Removed the redundant parentheses with return
Howard Soh committedFeb 28, 2024 Configuration menu - View commit details
-
Copy full SHA for 6bb41bc - Browse repository at this point
Copy the full SHA 6bb41bcView commit details -
Howard Soh committed
Feb 28, 2024 Configuration menu - View commit details
-
Copy full SHA for d82a979 - Browse repository at this point
Copy the full SHA d82a979View commit details -
#2673 restored return statement
Howard Soh committedFeb 28, 2024 Configuration menu - View commit details
-
Copy full SHA for 481bb15 - Browse repository at this point
Copy the full SHA 481bb15View commit details -
Merge pull request #2828 from dtcenter/feature_2673_sonarqube_beta3_r…
…eturn Feature 2673 sonarqube beta4 return
Configuration menu - View commit details
-
Copy full SHA for 00b162b - Browse repository at this point
Copy the full SHA 00b162bView commit details -
Howard Soh committed
Feb 28, 2024 Configuration menu - View commit details
-
Copy full SHA for bc7af99 - Browse repository at this point
Copy the full SHA bc7af99View commit details -
#2673 Moved down 'using namespace' statement. Removed trailing spaces
Howard Soh committedFeb 28, 2024 Configuration menu - View commit details
-
Copy full SHA for e872917 - Browse repository at this point
Copy the full SHA e872917View commit details
Commits on Mar 1, 2024
-
#2673 Moved down 'using namespace' statement.
Howard Soh committedMar 1, 2024 Configuration menu - View commit details
-
Copy full SHA for 3eb4367 - Browse repository at this point
Copy the full SHA 3eb4367View commit details -
#2673 Moved down 'using namespace' statement.
Howard Soh committedMar 1, 2024 Configuration menu - View commit details
-
Copy full SHA for 3f92f6a - Browse repository at this point
Copy the full SHA 3f92f6aView commit details -
#2673 Moved down 'using namespace' statement.
Howard Soh committedMar 1, 2024 Configuration menu - View commit details
-
Copy full SHA for a00c7be - Browse repository at this point
Copy the full SHA a00c7beView commit details -
#2673 Moved down 'using namespace' statement.
Howard Soh committedMar 1, 2024 Configuration menu - View commit details
-
Copy full SHA for 5706e97 - Browse repository at this point
Copy the full SHA 5706e97View commit details -
Merge remote-tracking branch 'origin/develop' into feature_2673_sonar…
…qube_beta3_namespace
Howard Soh committedMar 1, 2024 Configuration menu - View commit details
-
Copy full SHA for 4821c37 - Browse repository at this point
Copy the full SHA 4821c37View commit details
Commits on Mar 5, 2024
-
Howard Soh committed
Mar 5, 2024 Configuration menu - View commit details
-
Copy full SHA for 2509f7c - Browse repository at this point
Copy the full SHA 2509f7cView commit details -
Howard Soh committed
Mar 5, 2024 Configuration menu - View commit details
-
Copy full SHA for ca64f00 - Browse repository at this point
Copy the full SHA ca64f00View commit details -
Howard Soh committed
Mar 5, 2024 Configuration menu - View commit details
-
Copy full SHA for a7f0e06 - Browse repository at this point
Copy the full SHA a7f0e06View commit details
Commits on Mar 6, 2024
-
Merge pull request #2831 from dtcenter/feature_2673_sonarqube_beta3_n…
…amespace Feature 2673 sonarqube beta3 namespace
Configuration menu - View commit details
-
Copy full SHA for 0b2a7da - Browse repository at this point
Copy the full SHA 0b2a7daView commit details -
#2673 Changed literal 1 to boolean value, true
Howard Soh committedMar 6, 2024 Configuration menu - View commit details
-
Copy full SHA for 0ab2466 - Browse repository at this point
Copy the full SHA 0ab2466View commit details
Commits on Mar 7, 2024
-
Merge pull request #2832 from dtcenter/feature_2673_sonarqube_1_to_true
#2673 Changed literal 1 to the boolean value, true
Configuration menu - View commit details
-
Copy full SHA for 4d7d4a2 - Browse repository at this point
Copy the full SHA 4d7d4a2View commit details
Commits on Mar 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a6f7646 - Browse repository at this point
Copy the full SHA a6f7646View commit details -
* Unrelated to #2583, fix typo in code comments. * Per #2583, add hooks write 3 new ECNT columns for observation error data. * Per #2583, make error messages about mis-matched array lengths more informative. * Per #2583, switch to more concise variable naming conventions of ign_oerr_cnv, ign_oerr_cor, and dawid_seb. * Per #2583, fix typo to enable compilation * Per #2583, define the 5 new ECNT column names. * Per #2583, add 5 new columns to the ECNT table in the Ensemble-Stat chapter * Per #2583, update stat_columns.cc to write these 5 new ECNT columns * Per #2583, update ECNTInfo class to compute the 5 new ECNT statistics. * Per #2583, update stat-analysis to parse the 5 new ECNT columns. * Per #2583, update aggregate_stat logic for 5 new ECNT columns. * Per #2583, update PairDataEnsemble logic for 5 new ECNT columns * Per #2583, update vx_statistics library with obs_error handling logic for the 5 new ECNT columns * Per #2583, changes to make it compile * Per #2583, changes to make it compile * Per #2583, switch to a consistent ECNT column naming convention with OERR at the end. Using IGN_CONV_OERR and IGN_CORR_OERR. * Per #2583, define ObsErrorEntry::variance() with a call to the dist_var() utility function. * Per #2583, update PairDataEnsemble::compute_pair_vals() to compute the 5 new stats with the correct inputs. * Per #2583, add DEBUG(10) log messages about computing these new stats. * Per #2583, update Stat-Analysis to compute these 5 new stats from the ORANK line type. * Per #2583, whitespace and comments. * Per #2583, update the User's Guide. * Per #2583, remove the DS_ADD_OERR and DS_MULT_OERR ECNT columns and rename DS_OERR as DSS, since observation error is not actually involved in its computation. * Per #2583, minor update to Appendix C * Per #2583, rename ECNT line type statistic DSS to IDSS. * Per #2583, fix a couple of typos * Per #2583, more error checking. * Per #2583, remove the ECNT IDSS column since its just 2*pi*IGN, the existing ignorance score, and only provides meaningful information when combined with the other Dawid-Sebastiani statistics that have already been removed. * Per #2583, add Eric's documentation of these new stats to Appendix C. Along the way, update the DOI links in the references based on this APA style guide: https://apastyle.apa.org/style-grammar-guidelines/references/dois-urls#:~:text=Include%20a%20DOI%20for%20all,URL%2C%20include%20only%20the%20DOI. * Per #2583, fix new equations with embedded underscores for PDF by defining both html and pdf formatting options. * Per #2583, update the ign_conv_oerr equation to include a 2 *pi multiplier for consistency with the existing ignorance score. Also, fix the documented equations. * Per #2583, remove log file that was inadvertently added on this branch. * Per #2583, simplify ObsErrorEntry::variance() implementation. For the distribution type of NONE, return a variance of 0.0 rather than bad data, as discussed with @michelleharrold and @JeffBeck-NOAA on 3/8/2024. --------- Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
Configuration menu - View commit details
-
Copy full SHA for 108a895 - Browse repository at this point
Copy the full SHA 108a895View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c322aa - Browse repository at this point
Copy the full SHA 4c322aaView commit details -
Feature #2583 ecnt fix IGN_OERR_CORR (#2838)
* Unrelated to #2583, fix typo in code comments. * Per #2583, add hooks write 3 new ECNT columns for observation error data. * Per #2583, make error messages about mis-matched array lengths more informative. * Per #2583, switch to more concise variable naming conventions of ign_oerr_cnv, ign_oerr_cor, and dawid_seb. * Per #2583, fix typo to enable compilation * Per #2583, define the 5 new ECNT column names. * Per #2583, add 5 new columns to the ECNT table in the Ensemble-Stat chapter * Per #2583, update stat_columns.cc to write these 5 new ECNT columns * Per #2583, update ECNTInfo class to compute the 5 new ECNT statistics. * Per #2583, update stat-analysis to parse the 5 new ECNT columns. * Per #2583, update aggregate_stat logic for 5 new ECNT columns. * Per #2583, update PairDataEnsemble logic for 5 new ECNT columns * Per #2583, update vx_statistics library with obs_error handling logic for the 5 new ECNT columns * Per #2583, changes to make it compile * Per #2583, changes to make it compile * Per #2583, switch to a consistent ECNT column naming convention with OERR at the end. Using IGN_CONV_OERR and IGN_CORR_OERR. * Per #2583, define ObsErrorEntry::variance() with a call to the dist_var() utility function. * Per #2583, update PairDataEnsemble::compute_pair_vals() to compute the 5 new stats with the correct inputs. * Per #2583, add DEBUG(10) log messages about computing these new stats. * Per #2583, update Stat-Analysis to compute these 5 new stats from the ORANK line type. * Per #2583, whitespace and comments. * Per #2583, update the User's Guide. * Per #2583, remove the DS_ADD_OERR and DS_MULT_OERR ECNT columns and rename DS_OERR as DSS, since observation error is not actually involved in its computation. * Per #2583, minor update to Appendix C * Per #2583, rename ECNT line type statistic DSS to IDSS. * Per #2583, fix a couple of typos * Per #2583, more error checking. * Per #2583, remove the ECNT IDSS column since its just 2*pi*IGN, the existing ignorance score, and only provides meaningful information when combined with the other Dawid-Sebastiani statistics that have already been removed. * Per #2583, add Eric's documentation of these new stats to Appendix C. Along the way, update the DOI links in the references based on this APA style guide: https://apastyle.apa.org/style-grammar-guidelines/references/dois-urls#:~:text=Include%20a%20DOI%20for%20all,URL%2C%20include%20only%20the%20DOI. * Per #2583, fix new equations with embedded underscores for PDF by defining both html and pdf formatting options. * Per #2583, update the ign_conv_oerr equation to include a 2 *pi multiplier for consistency with the existing ignorance score. Also, fix the documented equations. * Per #2583, remove log file that was inadvertently added on this branch. * Per #2583, simplify ObsErrorEntry::variance() implementation. For the distribution type of NONE, return a variance of 0.0 rather than bad data, as discussed with @michelleharrold and @JeffBeck-NOAA on 3/8/2024. * Per #2583, updates to ensemble-stat.rst recommended by @michelleharrold and @JeffBeck-NOAA. * Per #2583, implement changes to the IGN_CORR_OERR corrected as directed by @ericgilleland. --------- Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
Configuration menu - View commit details
-
Copy full SHA for fd1b250 - Browse repository at this point
Copy the full SHA fd1b250View commit details -
Update the pull request template to include a question about expected…
… impacts to existing METplus Use Cases.
Configuration menu - View commit details
-
Copy full SHA for f113181 - Browse repository at this point
Copy the full SHA f113181View commit details
Commits on Mar 19, 2024
-
#2830 Changed enum Builtin to enum class
Howard Soh committedMar 19, 2024 Configuration menu - View commit details
-
Copy full SHA for be3ce26 - Browse repository at this point
Copy the full SHA be3ce26View commit details -
#2830 Converted enum to enum class at config_constants.h
Howard Soh committedMar 19, 2024 Configuration menu - View commit details
-
Copy full SHA for 0153110 - Browse repository at this point
Copy the full SHA 0153110View commit details
Commits on Mar 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0a771d4 - Browse repository at this point
Copy the full SHA 0a771d4View commit details
Commits on Mar 27, 2024
-
Bugfix #2833 develop azimuth (#2840)
* Per #2833, fix n-1 bug when defining the azimuth delta for range/azimuth grids. * Per #2833, when definng TcrmwData:range_max_km, divide by n_range - 1 since the range values start at 0. * Per #2833, remove max_range_km from the TC-RMW config file. Set the default rmw_scale to NA so that its not used by default. And update the documentation. Still actually need to make the logic of the code work as it should. * Per #2833, update tc_rmw to define the range as either a function of rmw or using explicit spacing in km. * Per #2833, update the TCRMW Config files to remove the max_range_km entry, and update the unit test for one call to use RMW ranges and the other to use ranges defined in kilometers. * Per #2833, just correct code comments. * Per #2833, divide by n - 1 when computing the range delta, rather than n. * Per #2833, correct the handling of the maximum range in the tc-rmw tool. For fixed delta km, need to define the max range when setting up the grid at the beginning. --------- Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
Configuration menu - View commit details
-
Copy full SHA for 98af717 - Browse repository at this point
Copy the full SHA 98af717View commit details -
#2830 Changed enum PadSize to enum class
Howard Soh committedMar 27, 2024 Configuration menu - View commit details
-
Copy full SHA for 1c97607 - Browse repository at this point
Copy the full SHA 1c97607View commit details -
#2830 Removed redundant parantheses
Howard Soh committedMar 27, 2024 Configuration menu - View commit details
-
Copy full SHA for 40b67d4 - Browse repository at this point
Copy the full SHA 40b67d4View commit details -
#2830 Removed commenyted out code
Howard Soh committedMar 27, 2024 Configuration menu - View commit details
-
Copy full SHA for 79f81af - Browse repository at this point
Copy the full SHA 79f81afView commit details -
Merge remote-tracking branch 'origin/develop' into feature_2830_sonar…
…qube_enum
Howard Soh committedMar 27, 2024 Configuration menu - View commit details
-
Copy full SHA for cef8aad - Browse repository at this point
Copy the full SHA cef8aadView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8cc667c - Browse repository at this point
Copy the full SHA 8cc667cView commit details
Commits on Mar 28, 2024
-
#2830 Changed enum to enum class for DistType, InterpMthd, GridTempla…
…tes, and NormalizeType
Howard Soh committedMar 28, 2024 Configuration menu - View commit details
-
Copy full SHA for d6cba7d - Browse repository at this point
Copy the full SHA d6cba7dView commit details -
#2830 Moved enum_class_as_integer from header file to cc files
Howard Soh committedMar 28, 2024 Configuration menu - View commit details
-
Copy full SHA for 15987a1 - Browse repository at this point
Copy the full SHA 15987a1View commit details
Commits on Apr 1, 2024
-
Howard Soh committed
Apr 1, 2024 Configuration menu - View commit details
-
Copy full SHA for 8a277fa - Browse repository at this point
Copy the full SHA 8a277faView commit details -
Howard Soh committed
Apr 1, 2024 Configuration menu - View commit details
-
Copy full SHA for fa41fa3 - Browse repository at this point
Copy the full SHA fa41fa3View commit details -
Deleted enum_class_as_integer and renamed it to enum_class_as_int
Howard Soh committedApr 1, 2024 Configuration menu - View commit details
-
Copy full SHA for 5c95525 - Browse repository at this point
Copy the full SHA 5c95525View commit details -
Howard Soh committed
Apr 1, 2024 Configuration menu - View commit details
-
Copy full SHA for 62acda7 - Browse repository at this point
Copy the full SHA 62acda7View commit details -
#2830 Changed enum to enumclass
Howard Soh committedApr 1, 2024 Configuration menu - View commit details
-
Copy full SHA for 6ac387f - Browse repository at this point
Copy the full SHA 6ac387fView commit details -
#2830 Changed enum_class_as_integer to enum_class_as_int
Howard Soh committedApr 1, 2024 Configuration menu - View commit details
-
Copy full SHA for 175f4ed - Browse repository at this point
Copy the full SHA 175f4edView commit details
Commits on Apr 2, 2024
-
Feature #2379 sonarqube gha (#2847)
* Per #2379, testing initial GHA SonarQube setup. * Per #2379, switch to only analyzing the src directory. * Per #2379, move more config logic from sonar-project.properties into the workflow. #ci-skip-all * Per #2379, try removing + symbols * Per #2379, move projectKey into xml workflow and remove sonar-project.properties. * Per #2379, try following the instructions at https://github.com/sonarsource-cfamily-examples/linux-autotools-gh-actions-sq/blob/main/.github/workflows/build.yml ci-skip-all * Per #2379, see details of progress described in this issue comment: #2379 (comment) * Unrelated to #2379, just removing spurious space that gets flagged as a diff when re-running enum_to_string on seneca. * Per #2379, try running SonarQube through GitHub. * Per #2379, remove empty env section and also disable the testing workflow temporarily during sonarqube development. * Per #2379, fix docker image name. * Per #2379, delete unneeded script. * Per #2379, update GHA to scan Python code and push to the correct SonarQube projects. * Per #2379, update GHA SonarQube project names * Per #2379, update the build job name * Per #2379, update the comile step name * Per #2379, switch to consistent SONAR variable names. * Per #2379, fix type in sed expressions. * Per #2379, just rename the log artifact * Per #2379, use time_command wrapper instead of run_command. * Per #2379, fix bad env var name * Per #2379, switch from egrep to grep. * Per #2379, just try cat-ting the logfile * Per #2379, test whether cat-ting the log file actually works. * Per #2379, revert back * Per #2379, mention SonarQube in the PR template. Make workflow name more succinct. * Per #2379, add SONAR_REFERENCE_BRANCH setting to define the sonar.newCode.referenceBranch property. The goal is to define the comparison reference branch for each SonarQube scan. * Per #2379, have the sonarqube.yml job print the reference branch it's using * Per #2379, intentionally introduce a new code smell to see if SonarQube correctly flag it as appearing in new code. * Per #2379, trying adding the SonarQube quality gate check. * Per #2379, add logic for using the report-task.txt output files to check the quality gate status for both the python and cxx scans. * Per #2379 must use unique GHA id's * Per #2379, working on syntax for quality gate checks * Per #2379, try again. * Per #2379, try again * Per #2379, try again * Per #2379, try again * Per #2379, try again * Per #2379, try again * Per #2379, try yet again * Per #2379 * Per #2379, add more debug * Per #2379, remove -it option from docker run commands * Per #2379, again * Per #2379, now that the scan works as expected, remove the intentional SonarQube code smell as well as debug logging.
Configuration menu - View commit details
-
Copy full SHA for 2c72a1b - Browse repository at this point
Copy the full SHA 2c72a1bView commit details -
Hotfix related to #2379. The sonar.newCode.referenceBranch and sonar.…
…branch.name cannot be set to the same string! Only add the newCode definition when they differ.
Configuration menu - View commit details
-
Copy full SHA for a72e8c5 - Browse repository at this point
Copy the full SHA a72e8c5View commit details
Commits on Apr 3, 2024
-
#2830 Changed enum STATJobType to enum class
Howard Soh committedApr 3, 2024 Configuration menu - View commit details
-
Copy full SHA for 2bef141 - Browse repository at this point
Copy the full SHA 2bef141View commit details
Commits on Apr 5, 2024
-
#2830 Changed STATLineType to enum class
Howard Soh committedApr 5, 2024 Configuration menu - View commit details
-
Copy full SHA for 9e0cd6d - Browse repository at this point
Copy the full SHA 9e0cd6dView commit details -
#2830 Changed Action to enum class
Howard Soh committedApr 5, 2024 Configuration menu - View commit details
-
Copy full SHA for 8fad8f2 - Browse repository at this point
Copy the full SHA 8fad8f2View commit details -
#2830 Changed ModeDataType to enum class
Howard Soh committedApr 5, 2024 Configuration menu - View commit details
-
Copy full SHA for 6d8a3c7 - Browse repository at this point
Copy the full SHA 6d8a3c7View commit details -
#2830 Changed StepCase to enum class
Howard Soh committedApr 5, 2024 Configuration menu - View commit details
-
Copy full SHA for df25b86 - Browse repository at this point
Copy the full SHA df25b86View commit details -
#2830 Changed enum to enum class
Howard Soh committedApr 5, 2024 Configuration menu - View commit details
-
Copy full SHA for 1f1d525 - Browse repository at this point
Copy the full SHA 1f1d525View commit details -
#2830 Changed GenesisPairCategory to enum class
Howard Soh committedApr 5, 2024 Configuration menu - View commit details
-
Copy full SHA for aebdd2a - Browse repository at this point
Copy the full SHA aebdd2aView commit details -
#2830 Removed rediundabt parenrthese
Howard Soh committedApr 5, 2024 Configuration menu - View commit details
-
Copy full SHA for 00380dc - Browse repository at this point
Copy the full SHA 00380dcView commit details -
#2830 Reduced same if checking
Howard Soh committedApr 5, 2024 Configuration menu - View commit details
-
Copy full SHA for 42c453e - Browse repository at this point
Copy the full SHA 42c453eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2bd5dcf - Browse repository at this point
Copy the full SHA 2bd5dcfView commit details -
#2830 USe empty() instead of lebgth checking
Howard Soh committedApr 5, 2024 Configuration menu - View commit details
-
Copy full SHA for 1f32746 - Browse repository at this point
Copy the full SHA 1f32746View commit details -
Howard Soh committed
Apr 5, 2024 Configuration menu - View commit details
-
Copy full SHA for 0811740 - Browse repository at this point
Copy the full SHA 0811740View commit details
Commits on Apr 8, 2024
-
Feature #2379 develop sonarqube updates (#2850)
* Per #2379, move rgb2ctable.py into the python utility scripts directory for better organization and to enable convenient SonarQube scanning. * Per #2379, remove point.py from the vx_python3_utils directory which cleary was inadvertenlty added during development 4 years ago. As far as I can tell it isn't being called by any other code and doesn't belong in the repository. Note that scripts/python/met/point.py has the same name but is entirely different. * Per #2379, update the GHA SonarQube scan to do a single one with Python and C++ combined. The nightly build script is still doing 2 separate scans for now. If this all works well, they could also be combined into a single one. * Per #2379, eliminate MET_CONFIG_OPTIONS from the SonarQube workflow since it doesn't need to be and probably shouldn't be configurable. * Per #2379, trying to copy report-task.txt out of the image * Per #2379, update build_met_sonarqube.sh to check the scan return status * Per #2379, fix bash assignment syntax * Per #2379, remove unused SCRIPT_DIR envvar * Per #2379, switch to a single SonarQube scan for MET's nightly build as well
Configuration menu - View commit details
-
Copy full SHA for e71debf - Browse repository at this point
Copy the full SHA e71debfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 78f1824 - Browse repository at this point
Copy the full SHA 78f1824View commit details -
Merge pull request #2849 from dtcenter/feature_2830_sonarqube_enum
Feature 2830 sonarqube enum
Configuration menu - View commit details
-
Copy full SHA for 3d543fc - Browse repository at this point
Copy the full SHA 3d543fcView commit details
Commits on Apr 10, 2024
-
Feature 2654 ascii2nc polar buoy support (#2846)
* Added iabp data type, and modified file_handler to filter based on time range, which was added as a command line option * handle time using input year, hour, min, and doy * cleanup and switch to position day of year for time computations * Added an ascii2nc unit test for iabp data * Added utility scripts to pull iabp data from the web and find files in a time range * Modified iabp_handler to always output a placeholder 'location' observation with value 1 * added description of IABP data python utility scripts * Fixed syntax error * Fixed Another syntax error. * Slight reformat of documentation * Per #2654, update the Makefiles in scripts/python/utility to include all the python scripts that should be installed. * Per #2654, remove unused code from get_iabp_from_web.py that is getting flagged as a bug by SonarQube. * Per #2654, fix typo in docs --------- Co-authored-by: John Halley Gotway <johnhg@ucar.edu> Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
Configuration menu - View commit details
-
Copy full SHA for 2a26d59 - Browse repository at this point
Copy the full SHA 2a26d59View commit details
Commits on Apr 17, 2024
-
Feature #2786 rpss_from_prob (#2861)
* Per #2786, small change to a an error message unrelated to this development. * Per #2786, add RPSInfo::set_climo_prob() function to derive the RPS line type from climatology probability bins. And update Ensemble-Stat to call it. * Per #2786, minor change to clarify error log message. * Per #2786, for is_prob = TRUE input, the RPS line type is the only output option. Still need to update docs! * Per #2786, add new call to Ensemble-Stat to test computing RPS from climo probabilities * Per #2786, use name rps_climo_bin_prob to be very explicit. * Per #2786, redefine logic of RPSInfo::set_climo_bin_prob() to match the CPC definition. Note that reliability, resolution, uncertainty, and RPSS based on the sample climatology are all set to bad data. Need to investigate whether they can be computed using these inputs. * Per #2786, remove the requirement that any fcst.prob_cat_thresh thresholds must be defined. If they are defined, pass them through to the FCST_THRESH output column. If not, write NA. Add check to make sure the event occurs in exactly 1 category. * Per #2786, don't enforce fcst.prob_cat_thresh == obs.prob_cat_thresh for probabilistic inputs. And add more is_prob checks so that only the RPS line type can be written when given probabilistic inputs. * updated documentation * Per #2786, call rescale_probability() function to convert from 0-100 probs to 0-1 probs. --------- Co-authored-by: j-opatz <jopatz@ucar.edu>
Configuration menu - View commit details
-
Copy full SHA for f78720b - Browse repository at this point
Copy the full SHA f78720bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 947b061 - Browse repository at this point
Copy the full SHA 947b061View commit details
Commits on Apr 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 406d991 - Browse repository at this point
Copy the full SHA 406d991View commit details -
Hotfix to the documentation in the develop branch. Issue #2858 was cl…
…osed as a duplicate of #2857. I had included it in the MET-12.0.0-beta4 release notes, but the work is not yet actually complete.
Configuration menu - View commit details
-
Copy full SHA for 0a219b5 - Browse repository at this point
Copy the full SHA 0a219b5View commit details
Commits on Apr 25, 2024
-
Feature 2842 ugrid config (#2852)
* #2842 Removed UGrid related setting * #2842 Corrected vertical level for data_plane_array * #2842 Do not allow the time range * #2842 The UGridConfig file can be passed as ugrid_dataset * #2842 Changed -config option to -ugrid_config * #2842 Deleted UGrid configurations * 2842 Fix a compile error when UGrid is disabled * #2842 Cleanup * #2842 Added an unittest point_stat_ugrid_mpas_config * #2842 Added a PointStatConfig without UGrid dataset. * #2842 Corrected ty[po at the variable name * Switched from time_centered to time_instant. I think time_centered is the center of the forecast lead window and time_instant is the time the forecast is valid (end of forecast window). * #2842 Removed ugrid_max_distance_km and unused metadata names * #2842 Restored time variable time_instant for LFric * #2842 Adjust lon between -180 and 180 * #2842 Adjust lon between -180 and 180 * #2842 Adjust lon between -180 and 180 * #2842 Adjusted lon to between -180 to 180 * #2842 Changed variable names * Per #2842, switch from degrees east to west right when the longitudes are read. * #2842, switch from degrees east to west right when the longitudes are read * #2842 Cleanup debug messages --------- Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu> Co-authored-by: Daniel Adriaansen <dadriaan@ucar.edu> Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Configuration menu - View commit details
-
Copy full SHA for d4c4eba - Browse repository at this point
Copy the full SHA d4c4ebaView commit details
Commits on Apr 29, 2024
-
Feature 2753 comp script config (#2868)
* set dynamic library file extension to .dylib if running on MacOS and .so otherwise * Added disabling of jasper documentation for compiliation on Hera * Updated * remove extra export of compiler env vars * include full path to log file so it is easier to file the log file to examine when a command fails * send cmake output to a log file * remove redundant semi-colon * use full path to log file so it is easier to examine on failure * use run_cmd to catch if rm command fails * Modifications for compilation on hera, gaea, and orion * Updating * fixed variable name * clean up if/else statements * set TIFF_LIBRARY_RELEASE argument to use full path to dynamic library file to prevent failure installing proj library * set LDFLAGS so that LDFLAGS value set in the user's environment will also be used * Updated based on gaea, orion, and hera installs * Updated * change extension of dynamic library files only if architecture is arm64 because older Macs still use .so * added netcdf library to args to prevent error installing NetCDF-CXX when PROJ has been installed in the same run of the script -- PATH is set in the COMPILE_PROJ if block that causes this flag from being added automatically * clean up how rpath and -L are added to LDFLAGS so that each entry is separate -- prevents errors installing on Mac arm64 because multiple rpath values aren't read using :. Also use MET_PROJLIB * Updated * removed -ltiff from MET libs * only add path to rpath and -L arguments if they are not already included in LDFLAGS * changed from using LIB_TIFF (full path to tiff lib file) to use TIFF_LIB_DIR (dir containing tiff lib file). Added TIFF_INCLUDE_DIR to proj compilation and -DJAS_ENABLE_DOC to jasper compliation taken from @jprestop branch * update comments * ensure all MET_* and MET_*LIB variables are added to the rpath for consistency * remove unnecessary if block and only export LDFLAGS at the end of setting locally * Updated * Added section for adding <VALUE>/lib64 and rearranged placement of ADDTL_DIR * Commenting out the running of the Jasper lib tests * Updating and/or removing files * Updating and/or removing files * Latest udpates which include the addition of the tiff library for proj * Remove commented out line. Co-authored-by: John Halley Gotway <johnhg@ucar.edu> * Make indentation consistent. Co-authored-by: John Halley Gotway <johnhg@ucar.edu> * Make indentation consistent. Co-authored-by: John Halley Gotway <johnhg@ucar.edu> * Make indentation consistent. Co-authored-by: John Halley Gotway <johnhg@ucar.edu> * Per 2753, added -lm to configure_lib_args for NetCDF-CXX * Per #2753 updating acorn files * Per #2753, update wcoss2 files * Per #2753, updating acorn file to include MET_PYTHON_EXE * Per #2753, updated files for 12.0.0 for derecho * Per #2753, updated derecho file adding MET_PYTHON_EXE and made corrections * Updating config files * Updating orion files * Updates for gaea's files * Updating gaea modulefile * Removing modulefile for cheyenne * Added MET_PYTHON_EXE * Added MET_PYTHON_EXE to hera too * Adding file for hercules * Removing equals sign from setenv * Adding file for hercules * Updated script to add libjpeg installation for grib2c * Per #2753, Adding file for casper --------- Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Configuration menu - View commit details
-
Copy full SHA for 3caffb4 - Browse repository at this point
Copy the full SHA 3caffb4View commit details
Commits on Apr 30, 2024
-
Feature #2795 level_mismatch_warning (#2873)
* Per #2795, move the warning message about level mismatch from the config validation step to when the forecast files are being processed. Only check this when the number of forecast fields is greater than 1, but no longer limit the check to pressure levels only. * Per #2795, add comments * Whitespace * Per #2795, port level mismatch fix over to Ensemble-Stat. Check it for each verification task, but only print it once for each task, rather than once for each task * ensemble member.
Configuration menu - View commit details
-
Copy full SHA for d3ecc87 - Browse repository at this point
Copy the full SHA d3ecc87View commit details
Commits on May 1, 2024
-
Feature #2870 removing_MISSING_warning (#2872)
* Per #2870, define utility functions for parsing the file type from a file list and for logging missing files, checking for the MISSING keyword. Also, update Ensemble-Stat and Gen-Ens-Prod to call these functions. * Per #2870, update the gen_ens_prod tests to demonstrate the use of the MISSING keyword for missing files. METplus uses this keyword for Ensemble-Stat and Gen-Ens-Prod.
Configuration menu - View commit details
-
Copy full SHA for ccd1061 - Browse repository at this point
Copy the full SHA ccd1061View commit details -
Feature 2842 ugrid config (#2875)
* #2842 Removed UGrid related setting * #2842 Corrected vertical level for data_plane_array * #2842 Do not allow the time range * #2842 The UGridConfig file can be passed as ugrid_dataset * #2842 Changed -config option to -ugrid_config * #2842 Deleted UGrid configurations * 2842 Fix a compile error when UGrid is disabled * #2842 Cleanup * #2842 Added an unittest point_stat_ugrid_mpas_config * #2842 Added a PointStatConfig without UGrid dataset. * #2842 Corrected ty[po at the variable name * Switched from time_centered to time_instant. I think time_centered is the center of the forecast lead window and time_instant is the time the forecast is valid (end of forecast window). * #2842 Removed ugrid_max_distance_km and unused metadata names * #2842 Restored time variable time_instant for LFric * #2842 Adjust lon between -180 and 180 * #2842 Adjust lon between -180 and 180 * #2842 Adjust lon between -180 and 180 * #2842 Adjusted lon to between -180 to 180 * #2842 Changed variable names * Per #2842, switch from degrees east to west right when the longitudes are read. * #2842, switch from degrees east to west right when the longitudes are read * #2842 Cleanup debug messages * #2842 Disabled output types except STAT for sl1l2 * #2842 Disabled output types except STAT for sl1l2 and MPR * #2842 Reduced output files for UGrid --------- Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu> Co-authored-by: Daniel Adriaansen <dadriaan@ucar.edu> Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Configuration menu - View commit details
-
Copy full SHA for 7f9bf9c - Browse repository at this point
Copy the full SHA 7f9bf9cView commit details -
Hotfix to develop branch to remove duplicate test named 'point_stat_u…
…grid_mpas_config'. That was causing unit_ugrid.xml to fail because it was still looking for .txt output files that are no longer being generated.
Configuration menu - View commit details
-
Copy full SHA for 566d4fb - Browse repository at this point
Copy the full SHA 566d4fbView commit details
Commits on May 7, 2024
-
Feature 2748 document ugrid (#2869)
* Initial documentation of the UGRID capability. * Fixes error in references, adds appendix to index, and adds sub-section for configuration entries and a table for metadata map items. * Corrects LFRic, rewords section on UGRID conventions, updates description of using GridStat, and removes mention of nodes. * Forgot one more mention of UGRID conventions. * Incorporates more suggestions from @willmayfield. * Switches to numerical table reference.
Configuration menu - View commit details
-
Copy full SHA for 542b4ba - Browse repository at this point
Copy the full SHA 542b4baView commit details
Commits on May 8, 2024
-
Feature #2781 Convert MET NetCDF point obs to Pandas DataFrame (#2877)
* Per #2781, added function to convert MET NetCDF point observation data to pandas so it can be read and modified in a python embedding script. Added example python embedding script * ignore python cache files * fixed function call * reduce cognitive complexity to satisfy SonarQube and add boolean return value to catch if function fails to read data * clean up script and add comments * replace call to object function that doesn't exist, handle exception when file passed to script cannot be read by the NetCDF library * rename example script * add new example script to makefiles * fix logic to build pandas DataFrame to properly get header information from observation header IDs * Per #2781, add unit test to demonstrate python embedding script that reads MET NetCDF point observation file and converts it to a pandas DataFrame * Per #2781, added init function for nc_point_obs to take an input filename. Also raise TypeError exception from nc_point_obs.read_data() if input file cannot be read * call parent class init function to properly initialize nc_point_obs
Configuration menu - View commit details
-
Copy full SHA for 79ac568 - Browse repository at this point
Copy the full SHA 79ac568View commit details
Commits on May 15, 2024
-
Feature #2833 pcp_combine_missing (#2886)
* Per #2883, add -input_thresh command line option to configure allowable missing input files. * Per #2883, update pcp_combine usage statement. * Per #2883, update existing pcp_combine -derive unit test example by adding 3 new missing file inputs at the beginning, middle, and end of the file list. The first two are ignored since they include the MISSING keyword, but the third without that keyword triggers a warning message as desired. The -input_thresh option is added to only require 70% of the input files be present. This should produce the exact same output data. * Per #2883, update the pcp_combine logic for the sum command to allow missing data files based on the -input_thresh threshold. Add a test in unit_pcp_combine.xml to demonstrate. * Update docs/Users_Guide/reformat_grid.rst Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> * Per #2883, update pcp_combine usage statement in the code to be more simliar to the User's Guide. * Per #2883, switch to using derive_file_list_missing as the one containing missing files and recreate derive_file_list as it had existed for the test named pcp_combine_derive_VLD_THRESH. * Per #2883, move initialization inside the same loop to resolve SonarQube issues. * Per #2883, update sum_data_files() to switch from allocating memory to using STL vectors to satisfy SonarQube. * Per #2883, changes to declarations of variables to satisfy SonarQube. * Per #2883, address more SonarQube issues * Per #2883, backing out an unintended change I made to tcrmw_grid.cc. This change belongs on a different branch. * Per #2883, update logic of parse_file_list_type() function to handle python input strings. Also update pcp_combine to parse the type of input files being read and log non-missing python input files expected. --------- Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for a960cc6 - Browse repository at this point
Copy the full SHA a960cc6View commit details
Commits on May 16, 2024
-
Per #2888, update STATAnalysisJob::dump_stat_line() to support dumpin…
…g stat line types VCNT, RPS, DMAP, and SSIDX. (#2891)
Configuration menu - View commit details
-
Copy full SHA for 27bff62 - Browse repository at this point
Copy the full SHA 27bff62View commit details
Commits on May 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 32bd12d - Browse repository at this point
Copy the full SHA 32bd12dView commit details
Commits on May 22, 2024
-
Feature #2395 TOTAL_DIR (#2892)
* Per #2395, remove the n_dir_undef and n_dira_undef variables that are superceded by the new dcount and dacount VL1L2Info members to keep track of the number of valid wind direction vectors. * Per #2395, add TOTAL_DIR columns to the VL1L2, VAL1L2, and VCNT line types and update the header column tables. * Per #2395, update the User's Guide to list the new TOTAL_DIR columns in the VL1L2, VAL1L2, and VCNT line types. * Per #2395, update stat_analysis to parse the new TOTAL_DIR columns and use the values to aggregate results when needed. * Per #2395, for SonarQube change 'const char *' to 'const char * const' to satisfy the finding that 'Global variables should be const.' Should probably switch from 'char char *' to strings eventually. But for now, I'm just making up for some SonarQube technical debt. * Per #2395, fix typo in placement of the DIR_ME column name in the met_header_columns_V12.0.txt file * Per #2395, add 2 new Stat-Analysis jobs to demonstrate the processing of VL1L2 lines. * Per #2395, update logic of is_vector_dir_stat(). Instead of just checking 'DIR_', check 'DIR_ME', 'DIR_MAE', and 'DIR_MSE' to avoid an false positive match for the 'DIR_ERR' column which is computed from the vector partial sums rather than the individual direction differences.
Configuration menu - View commit details
-
Copy full SHA for 889f1b2 - Browse repository at this point
Copy the full SHA 889f1b2View commit details -
Bugfix #2897 develop python_valid_time (#2899)
* Per #2897, fix typos in 2 log messages. Also fix the bug in storing the valid time strings. The time string in vld_array should exactly correspond to the numeric unixtime values in vld_num_array. Therefore they need to be updated inside the same if block. The bug is that we were storing only the unique unixtime values but storing ALL of the valid time string, not just the unique ones. * Per #2897, minor change to formatting of log message * MET #2897, don’t waste time searching, just set the index to n - 1 * Per #2897, remove unused add_prec_point_obs(...) function * Per #2897, update add_point_obs(...) logic for DEBUG(9) to print very detailed log messages about what obs are being rejected and which are being used for each verification task. * Per #2897, refine the 'using' log message to make the wording consistent with the summary rejection reason counts log message * Per #2897, update the User's Guide about -v 9 for Point-Stat --------- Co-authored-by: j-opatz <jopatz@ucar.edu> Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
Configuration menu - View commit details
-
Copy full SHA for 663fda7 - Browse repository at this point
Copy the full SHA 663fda7View commit details -
Bugfix 2867 point2grid qc flag (#2890)
* #2867 Added compute_adp_qc_flag and adjusted ADP QC flags * #2867 Added point2grid_GOES_16_ADP_Enterprise_high. Changed AOD QC flags to 0,1,2 (was 1,2,3) * #2867 Added get_nc_att_values_ * #2867 Added get_nc_att_values. Added the argument allow_conversion to get_nc_data(netCDF::NcVar *, uchar *data) * #2867 Read the ADP QC flag values and meanings attributes from DQF variable and set the QC high, meduium, low values to support Enterprise algorithm. Adjusted the ADP QC values by using AOD qc values * #2867 Cleanup * #2867 Corrected indent * #2867 Changed log message * #2867 Removed unused argument * #2867 Removed unused argument * Cleanup * #2867 Fix SonarQube findings * #2867 Deleted protected section with no members * #2867 Cleanup * #2867 FIxed SonarQube findings; unused local variables, decalare as const, etc * #2867 MOved include directives to top * #2867 Changed some argumenmt with references to avoid copying objects * #2867 Do not filter by QC flag if -qc is not given * #2867 Use enumj class for GOES QC: HIGH, MEDIUM, and LOW * #2867 Added log message back which were deleted accidently * #2867 Chaned statci const to constexpr * #2867 Initial release. Separated from nc_utils.h * @2867 Added nc_utils_core.h * #2867 Moved some blocks to nc_utils_core.h * #2867 Include nc_utils_core.h * #2867 Added const references * Per #2867, fixing typo in comments. --------- Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu> Co-authored-by: j-opatz <jopatz@ucar.edu>
Configuration menu - View commit details
-
Copy full SHA for cd2b429 - Browse repository at this point
Copy the full SHA cd2b429View commit details
Commits on May 23, 2024
-
Hotfix to develop to fix the update_truth.yml workflow logic. This te…
…sting workflow run failed (https://github.com/dtcenter/MET/actions/runs/9209471209). Here we switch to a unique update truth branch name to avoid conflicts.
Configuration menu - View commit details
-
Copy full SHA for 66dca0d - Browse repository at this point
Copy the full SHA 66dca0dView commit details -
Avoid pushing directly to the develop or main_vX.Y branches since tha…
…t is not necessary for the automation logic in MET.
Configuration menu - View commit details
-
Copy full SHA for 942959e - Browse repository at this point
Copy the full SHA 942959eView commit details
Commits on Jun 7, 2024
-
#2904 Changed R path to R-4.4.0 (#2905)
Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
Configuration menu - View commit details
-
Copy full SHA for f368db9 - Browse repository at this point
Copy the full SHA f368db9View commit details
Commits on Jun 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bdcfcf8 - Browse repository at this point
Copy the full SHA bdcfcf8View commit details -
Feature 2717 convert unit.pl to unit.py (#2871)
* created unit.py module in new internal/test_unit/python directory * added xml parsing to unit.py * added repl_env function * added reading of the remaining xml tags in build_tests function * progress on main function (putting together test commands) * a few more lines in the main function * minor updates * fixed how the test command was being run * added if name/main and command line parsing * fixed handling of no 'env' in cmd_only mode * handle params from xml that have \ after filename without space in between * added logging * added some more pieces to unit * more updates to unit.py, including running checks on output files * bug fixes, improved handling of output file names, improved handling of env vars, improved logging output * fixed how shell commands are run, and other minor fixes * added last bits from the perl script, fixed some bugs * created unit.py module in new internal/test_unit/python directory * added xml parsing to unit.py * added repl_env function * added reading of the remaining xml tags in build_tests function * progress on main function (putting together test commands) * a few more lines in the main function * minor updates * update scripts to call python unit test script instead of the old perl script * fix she-bang line to allow script to be run without python3 before it * add missing test_dir and exit_on_fail tags that are found in the rest of the unit test xml files * fix call to logger.warning * change tags named 'exists' to 'exist' to match the rest of the xml files * added logger to function * removed tab at end of line that was causing output file path to be excluded from the command * fix broken checks for output files * incorporated george's recommended changes * changed default to overwrite logs; allow for more than one xml file to be passed in command --------- Co-authored-by: Natalie babij <natalie.babij@natbabij-mac1.home> Co-authored-by: Natalie babij <natalie.babij@vpn68-237.vpnclient.ucar.edu> Co-authored-by: Natalie babij <natalie.babij@gsd-sslvpn-209.fsl.noaa.gov> Co-authored-by: Natalie Babij <nbabij@seneca.rap.ucar.edu> Co-authored-by: John Halley Gotway <johnhg@ucar.edu> Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> Co-authored-by: j-opatz <jopatz@ucar.edu>
Configuration menu - View commit details
-
Copy full SHA for 6f75e5a - Browse repository at this point
Copy the full SHA 6f75e5aView commit details
Commits on Jun 14, 2024
-
Bugfix 2867 point2grid qc unittest (#2913)
* #2867 Added compute_adp_qc_flag and adjusted ADP QC flags * #2867 Added point2grid_GOES_16_ADP_Enterprise_high. Changed AOD QC flags to 0,1,2 (was 1,2,3) * #2867 Added get_nc_att_values_ * #2867 Added get_nc_att_values. Added the argument allow_conversion to get_nc_data(netCDF::NcVar *, uchar *data) * #2867 Read the ADP QC flag values and meanings attributes from DQF variable and set the QC high, meduium, low values to support Enterprise algorithm. Adjusted the ADP QC values by using AOD qc values * #2867 Cleanup * #2867 Corrected indent * #2867 Changed log message * #2867 Removed unused argument * #2867 Removed unused argument * Cleanup * #2867 Fix SonarQube findings * #2867 Deleted protected section with no members * #2867 Cleanup * #2867 FIxed SonarQube findings; unused local variables, decalare as const, etc * #2867 MOved include directives to top * #2867 Changed some argumenmt with references to avoid copying objects * #2867 Do not filter by QC flag if -qc is not given * #2867 Use enumj class for GOES QC: HIGH, MEDIUM, and LOW * #2867 Added log message back which were deleted accidently * #2867 Chaned statci const to constexpr * #2867 Initial release. Separated from nc_utils.h * @2867 Added nc_utils_core.h * #2867 Moved some blocks to nc_utils_core.h * #2867 Include nc_utils_core.h * #2867 Added const references * #2867 Some 'static const' were chnaged to constexpr * #2867 Changed -qc options (1,2,3 to 0,1 - high & medium) for AOD * #2867 Merged develop branch * #2867 Corrected the unit test name --------- Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
Configuration menu - View commit details
-
Copy full SHA for 4179f55 - Browse repository at this point
Copy the full SHA 4179f55View commit details
Commits on Jun 18, 2024
-
Feature #2911 tc_stat_set_hdr (#2916)
* Per #2911, no real changes for Stat-Analysis. Just changing order of variables for consistency. * Per #2911, add StatHdrColumns::apply_set_hdr_opts(...) function to be used by TC-Stat. * Per #2911, move ByColumn to the TCStatJob base class and add HdrName and HdrValue to support the -set_hdr job command. * Per #2911, update GSI tools to call the newly added StatHdrColumns::apply_set_hdr_opts(...) function. * Per #2911, update logic of Stat-Analysis for consistency to make use of common apply_set_hdr_opts() function. * Per #2911, add DataLine::set_item() function to support -set_hdr options. * Per #2911, just update contents of error message * Per #2911, add TCStatLine member functions for has() and get_offset(). * Per #2911, update tc_stat to support applying -set_hdr to TC-Stat filter jobs. * Per #2911, revise TC-Stat config files to exercise the -set_hdr job command option * Per #2911, update TC-Stat documentation to mention the -set_hdr job command option * Per #2911, add note * Per #2911, as recommended by SonarQube, make some of these member functions const.
Configuration menu - View commit details
-
Copy full SHA for 95ad048 - Browse repository at this point
Copy the full SHA 95ad048View commit details
Commits on Jun 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5f20f55 - Browse repository at this point
Copy the full SHA 5f20f55View commit details
Commits on Jun 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for eb448e1 - Browse repository at this point
Copy the full SHA eb448e1View commit details