Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AppTP #2682

Merged
merged 15 commits into from
Apr 26, 2024
Merged

Remove AppTP #2682

merged 15 commits into from
Apr 26, 2024

Conversation

samsymons
Copy link
Contributor

@samsymons samsymons commented Apr 5, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/414235014887631/1206989067143299/f
Tech Design URL:
CC:

Description:

This PR removes AppTP.

Steps to test this PR:

  1. Check that the app builds and runs across the board (including alpha)
  2. Check that NetP connects
  3. Check that you can't find any references to AppTP still hanging around in the codebase

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
Internal references:

Software Engineering Expectations
Technical Design Template

@samsymons samsymons requested a review from brindy April 5, 2024 00:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024 •
edited
Loading

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against 745506e

@samsymons samsymons marked this pull request as ready for review April 5, 2024 01:46
samsymons and others added 2 commits April 7, 2024 09:53
@samsymons
Merge branch 'main' into sam/remove-apptp
4f762da 
# By Christopher Brind (2) and others
# Via GitHub
* main:
  Use trait collection to control theme changes (#2672)
  Expand maestro tests (#2691)
  scroll to selected item after opening new tab, etc (#2689)
  Update autoconsent to v10.5.0 (#2671)
  Fix history debug view controller causing crash on tap (#2681)

# Conflicts:
#	DuckDuckGo/HomeCollectionView.swift
#	DuckDuckGo/HomeViewController.swift
@brindy
Merge branch 'main' into sam/remove-apptp
c854d06
@brindy
Copy link
Contributor

brindy commented Apr 8, 2024

@samsymons just FYI, I updated from main

brindy
brindy requested changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bashed on it for a while and all seems good. However, found a few references:

  • HomeCollectionView.configure() (line 70) has an untyped appTP property that could be cleaned up
  • HomeViewCollection.configure(...) line 162, same as above
  • Bunch of appTP. strings in Localizable - not sure when these will get removed?

@github-actions github-actions bot added the stale label Apr 19, 2024
@samsymons
Merge branch 'main' into sam/remove-apptp
f798eb2 
# By Daniel Bernal (11) and others
# Via Mariusz Śpiewak (3) and others
* main: (63 commits)
  Release 7.115.1-1 (#2770)
  Fix iOS auto-clearing fails to remove cookies (#2769)
  Release 7.115.1-0 (#2768)
  Fix iOS auto-clearing fails to remove cookies (#2767)
  iOS: VPN screen improvements (#2721)
  Release 7.116.0-2 (#2763)
  Remove "Thank You" prompt (#2762)
  Test to ensure that page refresh doesn't affect url bar focus (#2749)
  Add support for uploading crash reports to Sentry (#2720)
  Replace SwiftLintPlugin with SwiftLintTool (#2710)
  Release 7.116.0-1 (#2761)
  Remove validator app (#2754)
  Fix crash when quickly adding/removing tabs in switcher (#2760)
  Fix settings navigation bar colors after reopening (#2758)
  Alpha ad-hoc lane (#2492)
  Keep a weak reference to UserScriptMessageBroker (#2755)
  Add refresh config cell to top of debug (#2735)
  VPN: Replace available interfaces in VPN metadata (#2750)
  Require device auth to be set in order to use Sync (#2722)
  Add new iOS pixels for measuring navigation  (#2730)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo/AppDelegate.swift
#	DuckDuckGo/MainViewController.swift
@samsymons
Resolve merge conflicts.
cd74bbd
@github-actions github-actions bot removed the stale label Apr 21, 2024
@samsymons samsymons requested a review from brindy April 21, 2024 17:26
@samsymons
Merge branch 'main' into sam/remove-apptp
c13ced9 
* main:
  lastDisconnectError now matches against NEVPNConnectionError (#2753)
  Release 7.116.0-3 (#2774)
  Patch 7.116.0 with 7.115.1 hotfix (#2773)
@duckduckgo duckduckgo deleted a comment from github-actions bot Apr 23, 2024
brindy
brindy approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samsymons
Merge branch 'main' into sam/remove-apptp
486bdeb 
# By Dominik Kapusta (3) and others
# Via GitHub (1) and amddg44 (1)
* main:
  fix progress bar missing after cold launch (#2792)
  Check entitlements before showing VPN screen from notification (#2748)
  Add parameter allowed encoding to error descriptions (#2781)
  Update Lottie to 4.4.3 (#2765)
  Update to fastlane 2.220.0 to fix ad-hoc lane (#2782)
  iOS: Bundle-Specfic Autofill Secure Vault Keychain Items  (#2759)
  Fix dSYM archive upload to S3 (#2778)
  Fix dSYM archive upload to S3 (#2778)
  Release 7.117.0-0 (#2776)
  Select Subscription Environment in Debug Settings (#2766)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
@samsymons
Remove CocoaAsyncSocket.
745506e
@samsymons samsymons merged commit b049683 into main Apr 26, 2024
13 checks passed
@samsymons samsymons deleted the sam/remove-apptp branch April 26, 2024 03:15
samsymons added a commit that referenced this pull request Apr 26, 2024
@samsymons
Merge branch 'main' into sam/disable-on-demand-when-user-initiates-sh…
8520656 
…utdown

# By Christopher Brind (4) and others
# Via Chris Brind (1) and others
* main: (21 commits)
  Update BSK to 141.1.1 (#2796)
  iOS: VPN Metadata Improvements (#2791)
  Add Internal Page suggestions support (#2784)
  iOS: Add pixels to track VPN wake and stop attempts (#2785)
  Fix bug that shows selected tab in strange position in the switcher (#2789)
  Remove AppTP (#2682)
  Release 7.117.0-1 (#2794)
  cherry pick progress bar fix (#2793)
  fix progress bar missing after cold launch (#2792)
  Check entitlements before showing VPN screen from notification (#2748)
  Add parameter allowed encoding to error descriptions (#2781)
  Update Lottie to 4.4.3 (#2765)
  Update to fastlane 2.220.0 to fix ad-hoc lane (#2782)
  iOS: Bundle-Specfic Autofill Secure Vault Keychain Items  (#2759)
  Fix dSYM archive upload to S3 (#2778)
  Fix dSYM archive upload to S3 (#2778)
  Release 7.117.0-0 (#2776)
  Select Subscription Environment in Debug Settings (#2766)
  lastDisconnectError now matches against NEVPNConnectionError (#2753)
  Release 7.116.0-3 (#2774)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit that referenced this pull request Apr 30, 2024
@samsymons
Merge branch 'main' into sam/remove-atb-from-default-pixel-parameters
810603b 
* main: (38 commits)
  Disable the feedback send button when there’s no text (#2800)
  Release 7.118.0-0 (#2802)
  Autofill Settings - Import passwords via sync (#2756)
  Fix selected VPN location consistency (#2797)
  Reapply "Report Apple Ad attribution using pixel" (#2702)
  reapply auto clear fix, clear cookies, load page on link click (#2798)
  Toggle Connect on Demand when receiving user initiated VPN lifecycle events (#2771)
  Update BSK to 141.1.1 (#2796)
  iOS: VPN Metadata Improvements (#2791)
  Add Internal Page suggestions support (#2784)
  iOS: Add pixels to track VPN wake and stop attempts (#2785)
  Fix bug that shows selected tab in strange position in the switcher (#2789)
  Remove AppTP (#2682)
  Release 7.117.0-1 (#2794)
  cherry pick progress bar fix (#2793)
  fix progress bar missing after cold launch (#2792)
  Check entitlements before showing VPN screen from notification (#2748)
  Add parameter allowed encoding to error descriptions (#2781)
  Update Lottie to 4.4.3 (#2765)
  Update to fastlane 2.220.0 to fix ad-hoc lane (#2782)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brindy brindy brindy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsymons @brindy