Break DuckPlayer ref cycle #3206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brindy
approved these changes
Aug 8, 2024
samsymons
added a commit
that referenced
this pull request
Aug 12, 2024
# By Sam Symons (3) and others # Via Chris Brind (2) and others * main: DuckPlayer contingency messages pixels (#3220) New autofill onboarding for existing DDG users (#3170) Add translations for DuckPlayer contingency messge (#3215) Fix PrivacyProDataReporter crash due to premature secure vault use (#3217) Bump rexml from 3.2.9 to 3.3.3 (#3175) Bump submodules/privacy-reference-tests from `a603ff9` to `afb4f61` (#3165) [DuckPlayer] 16. Localization Updates (#3200) Release 7.132.0-3 (#3213) cherry pick temporary fix for https://app.asana.com/0/414235014887631/1207990702991361/f fix content inset when keyboard is visible (#3207) Ship review feedback for contingency message (#3209) Release 7.132.0-2 (#3211) Restore attribution flag (#3197) Restore attribution flag (#3197) Release 7.132.0-1 (#3208) Break DuckPlayer ref cycle (#3206) Show improved Dax onboarding on New Tab Page (#3203) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414709148257752/1207998631270910/f
Description:
Breaks reference cycle between DuckPlayer and TabViewController, which can contribute to containers not being properly cleaned up
Steps to test this PR: