Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix content inset when keyboard is visible #3207

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Aug 7, 2024

Task/Issue URL: https://app.asana.com/0/392891325557410/1207990702991361/f
Tech Design URL:
CC:

Description:
Fix webview content inset when address bar is in bottom position.

Steps to test this PR:

  1. Visit https://duck.ai with address bar in bottom and top position and make sure the view adjusts accordingly.

@brindy brindy requested review from a team, jaceklyp and federicocappelli and removed request for a team and jaceklyp August 7, 2024 23:10
Copy link
Member

@federicocappelli federicocappelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brindy brindy merged commit 7db5d17 into main Aug 9, 2024
13 checks passed
@brindy brindy deleted the brindy/fix-bottom-margin-on-keyboard-shown branch August 9, 2024 10:03
samsymons added a commit that referenced this pull request Aug 12, 2024
# By Sam Symons (3) and others
# Via Chris Brind (2) and others
* main:
  DuckPlayer contingency messages pixels (#3220)
  New autofill onboarding for existing DDG users (#3170)
  Add translations for DuckPlayer contingency messge (#3215)
  Fix PrivacyProDataReporter crash due to premature secure vault use (#3217)
  Bump rexml from 3.2.9 to 3.3.3 (#3175)
  Bump submodules/privacy-reference-tests from `a603ff9` to `afb4f61` (#3165)
  [DuckPlayer] 16. Localization Updates (#3200)
  Release 7.132.0-3 (#3213)
  cherry pick temporary fix for https://app.asana.com/0/414235014887631/1207990702991361/f
  fix content inset when keyboard is visible (#3207)
  Ship review feedback for contingency message (#3209)
  Release 7.132.0-2 (#3211)
  Restore attribution flag (#3197)
  Restore attribution flag (#3197)
  Release 7.132.0-1 (#3208)
  Break DuckPlayer ref cycle (#3206)
  Show improved Dax onboarding on New Tab Page (#3203)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants