Do not reload DBP tab when switching to it #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mallexxx
requested changes
Dec 8, 2023
DuckDuckGo/Tab/Model/Tab.swift
Outdated
| @@ -463,6 +464,8 @@ protocol NewWindowPolicyDecisionMaker { | |||
| userContentController?.cleanUpBeforeClosing() | |||
| webView.assertObjectDeallocated(after: 4.0) | |||
| } | |||
| delegate?.tabWillClose(self) | |||
There was a problem hiding this comment.
the method is being called on Tab.dealloc, passing self to a call here is a critical issue that will eventually lead to crashes. this should be removed
| @@ -684,6 +683,12 @@ extension BrowserTabViewController: TabDelegate { | |||
| } | |||
| } | |||
|
|
|||
| func tabWillClose(_ tab: Tab) { | |||
| if tab.content == .dataBrokerProtection { | |||
| dataBrokerProtectionHomeViewController = nil | |||
There was a problem hiding this comment.
this won‘t remove dataBrokerProtectionHomeViewController when a Tab is navigated to another URL. Or when dragging a tab to another window. (in this case DBP page data will be reloaded for another window)
If there‘s 2 DBP tabs open (dragged from another window), switching between them will show the same content. If one of them is closed, the DBP page will be reloaded on another one activation.
mallexxx
approved these changes
Dec 13, 2023
samsymons
added a commit
that referenced
this pull request
Dec 21, 2023
# By Dominik Kapusta (41) and others # Via Dominik Kapusta (9) and others * main: (138 commits) Make sure when we set custom config url, we don't expect etag in return (#1994) Add PixelKit source parameter (#1989) Fix internal user toggling (#2000) Show alert and display warning icon in Sync Settings when data syncing is disabled (#1996) DBP: Integrate subscription account authentication to DBP (#1995) Improve bookmarks html reader (#1986) Add Sync feature flags (#1992) Add daily stats pixel (#1993) Do not reload DBP tab when switching to it (#1942) Fix: external application requests via redirect URLs shows wrong origin. (#1900) Update clean-app.sh to work on macOS Sonoma and include NetP containers (#1988) Fix: "SwiftLintPlugin" must be enabled before it can be used (#1987) Prevent VPN server list persistence failures (#1985) add test can remove data (#1980) Remove VPN upgrade card (#1983) Fix low-res VPN warning asset (#1984) DBP: Fix unreliable date tests (#1981) Add search retention pixel for NetP (#1964) Sabrina/sync e2e tests (#1959) swiftlint build plugin (#1318) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/Application/AppDelegate.swift
samsymons
added a commit
that referenced
this pull request
Dec 22, 2023
# By Dominik Kapusta (2) and others # Via GitHub * main: Make sure when we set custom config url, we don't expect etag in return (#1994) Add PixelKit source parameter (#1989) Fix internal user toggling (#2000) Show alert and display warning icon in Sync Settings when data syncing is disabled (#1996) DBP: Integrate subscription account authentication to DBP (#1995) Improve bookmarks html reader (#1986) Add Sync feature flags (#1992) Add daily stats pixel (#1993) Do not reload DBP tab when switching to it (#1942) Fix: external application requests via redirect URLs shows wrong origin. (#1900) # Conflicts: # DuckDuckGo/Statistics/PixelEvent.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1203581873609357/1206115814306009/f
Description:
Do not reload the DBP tab when switching to it
Steps to test this PR:
[ Prepare to use DBP]
falsefrom this linemacos-browser/LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Services/RedeemCodeServices.swift
Line 72 in 2bd8ca8
truefrom this line if you're not already logged as in internal usermacos-browser/DuckDuckGo/DBP/DataBrokerProtectionFeatureVisibility.swift
Line 62 in 2bd8ca8
DataBrokerProtectionViewControllerwas removed from memory, open it again, check if the UI loads againInternal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation