Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix low-res VPN warning asset #1984

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Fix low-res VPN warning asset #1984

merged 3 commits into from
Dec 19, 2023

Conversation

samsymons
Copy link
Collaborator

@samsymons samsymons commented Dec 19, 2023

Task/Issue URL: https://app.asana.com/0/1199230911884351/1206201126808141/f
Tech Design URL:
CC:

Description:

This PR fixes the low-res warning asset in the VPN status UI.

Before:

VPN Asset Before

After:

VPN Asset

Steps to test this PR:

  1. Either force an error somehow, or hardcode an error by visiting NetworkProtectionStatusView and hardcode an error like connectionHealthWarningView(message: "VPN connectivity warning goes here!") in the body function
  2. Make sure the image looks good

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

* main:
  DBP: Fix unreliable date tests (#1981)
  Add search retention pixel for NetP (#1964)
  Sabrina/sync e2e tests (#1959)
  swiftlint build plugin (#1318)
  VPN Geoswitching - initial draft (#1978)
  Add additional VPN startup pixels (#1975)
  Updates to Autofill Logins copy (#1924)
  Bump version to 1.69.0 (95)
  Remove the reconnect/disconnect logic from the connection tester (#1970)
  Set marketing version to 1.69.0
  Update embedded files
  DBP: Send internal user param for dbp waitlist pixels (#1972)
  Move release task to proper section in Code Freeze workflow (#1977)
  drop Main.storyboard (#1944)
  Add GHA workflow to cut release branch (#1976)
  Move DBP tests into main target (#1974)
  Use static date for PixelKit tests (#1973)
Copy link
Contributor

@diegoreymendez diegoreymendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@samsymons samsymons merged commit 0583409 into main Dec 19, 2023
15 checks passed
@samsymons samsymons deleted the sam/error-ui-improvements branch December 19, 2023 08:55
samsymons added a commit that referenced this pull request Dec 21, 2023
# By Dominik Kapusta (41) and others
# Via Dominik Kapusta (9) and others
* main: (138 commits)
  Make sure when we set custom config url, we don't expect etag in return (#1994)
  Add PixelKit source parameter (#1989)
  Fix internal user toggling (#2000)
  Show alert and display warning icon in Sync Settings when data syncing is disabled (#1996)
  DBP: Integrate subscription account authentication to DBP (#1995)
  Improve bookmarks html reader (#1986)
  Add Sync feature flags (#1992)
  Add daily stats pixel (#1993)
  Do not reload DBP tab when switching to it (#1942)
  Fix: external application requests via redirect URLs shows wrong origin. (#1900)
  Update clean-app.sh to work on macOS Sonoma and include NetP containers (#1988)
  Fix: "SwiftLintPlugin" must be enabled before it can be used (#1987)
  Prevent VPN server list persistence failures (#1985)
  add test can remove data (#1980)
  Remove VPN upgrade card (#1983)
  Fix low-res VPN warning asset (#1984)
  DBP: Fix unreliable date tests (#1981)
  Add search retention pixel for NetP (#1964)
  Sabrina/sync e2e tests (#1959)
  swiftlint build plugin (#1318)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
#	DuckDuckGo/Application/AppDelegate.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants