Sabrina/sync e2e tests #1959
Sabrina/sync e2e tests #1959
Conversation
ayoy
force-pushed
the
sabrina/sync_e2e_tests
branch
from
02aa6ea to
9d5dc25
Compare
There was a problem hiding this comment.
Leaving one tiny comment about the debug menu.
The tests are good to go in current shape, great job on that @SabrinaTardio!
I found out that we can't clear tested app data directory from within the test case because the test case itself runs in Sandbox and it can't touch app's files directly. We'll have to orchestrate running tests one by one and clearing data in between ourselves.
DuckDuckGo/Menus/MainMenu.swift
Outdated
| @@ -585,6 +585,8 @@ import Subscription | |||
|
|
|||
| NSMenuItem(title: "Trigger Fatal Error", action: #selector(MainViewController.triggerFatalError)) | |||
|
|
|||
| NSMenuItem(title: "Internal User state", action: #selector(MainViewController.internalUserState)) | |||
There was a problem hiding this comment.
I'd call it "Set Internal User State" (also all words capitalized), and if possible, grey out when internal state is enabled.
Yeah I was just looking at that… in CI maybe we could have a separete job for each test and run the clean up script in between |
* main: DBP: Fix unreliable date tests (#1981) Add search retention pixel for NetP (#1964) Sabrina/sync e2e tests (#1959) swiftlint build plugin (#1318) VPN Geoswitching - initial draft (#1978) Add additional VPN startup pixels (#1975) Updates to Autofill Logins copy (#1924) Bump version to 1.69.0 (95) Remove the reconnect/disconnect logic from the connection tester (#1970) Set marketing version to 1.69.0 Update embedded files DBP: Send internal user param for dbp waitlist pixels (#1972) Move release task to proper section in Code Freeze workflow (#1977) drop Main.storyboard (#1944) Add GHA workflow to cut release branch (#1976) Move DBP tests into main target (#1974) Use static date for PixelKit tests (#1973)
# By Dominik Kapusta (41) and others # Via Dominik Kapusta (9) and others * main: (138 commits) Make sure when we set custom config url, we don't expect etag in return (#1994) Add PixelKit source parameter (#1989) Fix internal user toggling (#2000) Show alert and display warning icon in Sync Settings when data syncing is disabled (#1996) DBP: Integrate subscription account authentication to DBP (#1995) Improve bookmarks html reader (#1986) Add Sync feature flags (#1992) Add daily stats pixel (#1993) Do not reload DBP tab when switching to it (#1942) Fix: external application requests via redirect URLs shows wrong origin. (#1900) Update clean-app.sh to work on macOS Sonoma and include NetP containers (#1988) Fix: "SwiftLintPlugin" must be enabled before it can be used (#1987) Prevent VPN server list persistence failures (#1985) add test can remove data (#1980) Remove VPN upgrade card (#1983) Fix low-res VPN warning asset (#1984) DBP: Fix unreliable date tests (#1981) Add search retention pixel for NetP (#1964) Sabrina/sync e2e tests (#1959) swiftlint build plugin (#1318) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/Application/AppDelegate.swift
Task/Issue URL: https://app.asana.com/0/0/1206157806473025/f
Tech Design URL:
CC:
Description:
Steps to test this PR:
1.
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation