Tab closing animation #333
Conversation
| if shouldScroll { | ||
| collectionView.animator().scroll(CGPoint(x: scrollView.contentView.bounds.origin.x - tabWidth, y: 0)) | ||
| } | ||
| NSAnimationContext.runAnimationGroup { context in |
There was a problem hiding this comment.
Hey GitHub, I have only added this part, everything else is the same.
|
@tomasstrba I don't really see any delay in our current close tab animation so can't really see the difference. Are there more steps than simply hitting the close button or using cmd-w? Could it be a speed thing? I'm on a 2017 iMac 4.2 GHz Quad-Core Intel Core i7 |
|
@brindy, my apologies for later response. Standard animation duration on macOS is 1/3 of a second. I have changed the closing animation to 0.15. I think it is something between the long animation that makes browser looks slow and no animation which makes it hard to follow changes in the tab bar. It is harder to observe this change, but it shouldn't be influenced by your hardware. Let me recored some videos for you to compare |
|
@brindy, I've recorded vides for you. Please, if it is still hard to see the difference, try to play with the duration of the context. Feel free to set it to 1 second or even 0 https://user-images.githubusercontent.com/57389842/142643638-c1f0cfab-22d7-4fdd-8e67-82fc34363c3d.mov o |
|
Thanks - the setting definitely has an effect but I don't notice anything perceptible between 0.3 and 0.15 - that's some fine eye people have! |
|
Thank you Brindy! :) |
* develop: Avoid using a specific browser as the default. (#341) Closing animation duration changed to 0.15 (#333) Hiding the favicon view when favicon is nil (#326) export bookmarks (#339) Ensure ITP database is cleared (#328) Execute print user script in page content world (#238) move the next/previous handlers to the main view controller (#331) Search with DuckDuckGo in PDF Context Menu (#323) Fix Back button takes to r.duckduckgo.com (#321) Track the existing print handler to avoid DoS attacks. (#330) Minor copy fixes (#325) support cmd-option-left/right for navigating tabs (#324) Version 0.17.5 Debounce privacy entry point update (#309) Change major tracker network threshold (#319) Check for click handler on printing user script (#318) Fix Homepage navigation (#322)
* develop: (23 commits) Update the credit card model + UI tweaks (#342) 0.17.6 Add Usage Pixel (#336) Bump find-in-page to latest version (#337) Forward delete collision with suffix resolved (#334) Avoid using a specific browser as the default. (#341) Closing animation duration changed to 0.15 (#333) Hiding the favicon view when favicon is nil (#326) export bookmarks (#339) Ensure ITP database is cleared (#328) Execute print user script in page content world (#238) move the next/previous handlers to the main view controller (#331) Search with DuckDuckGo in PDF Context Menu (#323) Fix Back button takes to r.duckduckgo.com (#321) Track the existing print handler to avoid DoS attacks. (#330) Minor copy fixes (#325) support cmd-option-left/right for navigating tabs (#324) Version 0.17.5 Debounce privacy entry point update (#309) Change major tracker network threshold (#319) ...
# By Alistair Brown (9) and others # Via GitHub * develop: (36 commits) Partial tech debt cleanup (#345) Address Bar visual tweaks (#310) Bump find-in-page to latest version (#352) Bump privacy dashboard to latest version (#349) fix popover message bug (#348) Add missing next and previous find-in-page button handlers (#351) add asserts to check that atb and install date are nil before being set (#350) copy private email address (#344) Reset tracker info on page change (#335) remove history menu and re-home other items (#343) Update the credit card model + UI tweaks (#342) 0.17.6 Add Usage Pixel (#336) Bump find-in-page to latest version (#337) Forward delete collision with suffix resolved (#334) Avoid using a specific browser as the default. (#341) Closing animation duration changed to 0.15 (#333) Hiding the favicon view when favicon is nil (#326) export bookmarks (#339) Ensure ITP database is cleared (#328) ... # Conflicts: # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Task/Issue URL: https://app.asana.com/0/1199178362774117/1200085849431499/f
Description:
Setting lower duration of the tab closing animation to make the browser feel faster. The main point is to avoid long fade out.
Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM