Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset tracker info on page change #335

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

alistairjcbrown
Copy link
Member

Task/Issue URL: https://app.asana.com/0/1177771139624306/1201233794429580/f
Tech Design URL:
CC:

Description:
Reset tracker information on URL path change

Before After
before-tracker-data-reset after-tracker-data-reset

Steps to test this PR:

  1. Go to http://privacy-test-pages.glitch.me/index.html
  2. Open Privacy Dashboard popover — it should say "0 Trackers Found"
  3. Click on the link "Image loaded via document fragment"
  4. Open Privacy Dashboard popover — it should say "1 Tracker Found"
  5. Click on the link "[Home]"
  6. Open Privacy Dashboard popover — it should say "0 Trackers Found"

Testing checklist:

  • Test with Release configuration

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@alistairjcbrown alistairjcbrown force-pushed the abrown/reset-tracker-info-on-page-change branch from fa908bb to 50bd0c0 Compare November 22, 2021 22:52
@alistairjcbrown alistairjcbrown merged commit 99e921b into develop Nov 25, 2021
@alistairjcbrown alistairjcbrown deleted the abrown/reset-tracker-info-on-page-change branch November 25, 2021 11:20
samsymons added a commit that referenced this pull request Nov 26, 2021
* develop:
  Address Bar visual tweaks (#310)
  Bump find-in-page to latest version (#352)
  Bump privacy dashboard to latest version (#349)
  fix popover message bug (#348)
  Add missing next and previous find-in-page button handlers (#351)
  add asserts to check that atb and install date are nil before being set (#350)
  copy private email address (#344)
  Reset tracker info on page change (#335)
  remove history menu and re-home other items (#343)
samsymons added a commit that referenced this pull request Dec 6, 2021
# By Alistair Brown (9) and others
# Via GitHub
* develop: (36 commits)
  Partial tech debt cleanup (#345)
  Address Bar visual tweaks (#310)
  Bump find-in-page to latest version (#352)
  Bump privacy dashboard to latest version (#349)
  fix popover message bug (#348)
  Add missing next and previous find-in-page button handlers (#351)
  add asserts to check that atb and install date are nil before being set (#350)
  copy private email address (#344)
  Reset tracker info on page change (#335)
  remove history menu and re-home other items (#343)
  Update the credit card model + UI tweaks (#342)
  0.17.6
  Add Usage Pixel (#336)
  Bump find-in-page to latest version (#337)
  Forward delete collision with suffix resolved (#334)
  Avoid using a specific browser as the default. (#341)
  Closing animation duration changed to 0.15 (#333)
  Hiding the favicon view when favicon is nil (#326)
  export bookmarks (#339)
  Ensure ITP database is cleared (#328)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants