Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump privacy dashboard to latest version #349

Merged
merged 1 commit into from
Nov 26, 2021

Conversation

alistairjcbrown
Copy link
Member

@alistairjcbrown alistairjcbrown commented Nov 25, 2021

Task/Issue URL: https://app.asana.com/0/1177771139624306/1200473629312157/f
Tech Design URL:
CC: @tomasstrba @mallexxx @samsymons

Description:
Updates Privacy Dashboard

Steps to test this PR:

  1. Go to macOS System Prefernces > General and change the "Appearance" to "Dark"
  2. Privacy Dashboard should now appear with dark theme

Testing checklist:

  • Test with Release configuration

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@brindy brindy self-assigned this Nov 25, 2021
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bootiful Bernard!

@brindy brindy assigned alistairjcbrown and unassigned brindy Nov 25, 2021
@alistairjcbrown alistairjcbrown merged commit 93a4a6e into develop Nov 26, 2021
@alistairjcbrown alistairjcbrown deleted the abrown/bump-privacy-dashboard branch November 26, 2021 10:06
samsymons added a commit that referenced this pull request Nov 26, 2021
* develop:
  Address Bar visual tweaks (#310)
  Bump find-in-page to latest version (#352)
  Bump privacy dashboard to latest version (#349)
  fix popover message bug (#348)
  Add missing next and previous find-in-page button handlers (#351)
  add asserts to check that atb and install date are nil before being set (#350)
  copy private email address (#344)
  Reset tracker info on page change (#335)
  remove history menu and re-home other items (#343)
samsymons added a commit that referenced this pull request Dec 6, 2021
# By Alistair Brown (9) and others
# Via GitHub
* develop: (36 commits)
  Partial tech debt cleanup (#345)
  Address Bar visual tweaks (#310)
  Bump find-in-page to latest version (#352)
  Bump privacy dashboard to latest version (#349)
  fix popover message bug (#348)
  Add missing next and previous find-in-page button handlers (#351)
  add asserts to check that atb and install date are nil before being set (#350)
  copy private email address (#344)
  Reset tracker info on page change (#335)
  remove history menu and re-home other items (#343)
  Update the credit card model + UI tweaks (#342)
  0.17.6
  Add Usage Pixel (#336)
  Bump find-in-page to latest version (#337)
  Forward delete collision with suffix resolved (#334)
  Avoid using a specific browser as the default. (#341)
  Closing animation duration changed to 0.15 (#333)
  Hiding the favicon view when favicon is nil (#326)
  export bookmarks (#339)
  Ensure ITP database is cleared (#328)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants