-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add contextual onboarding pixels #3447
Conversation
DuckDuckGo/NavigationBar/View/NavigationBarViewController.swift
Outdated
Show resolved
Hide resolved
DuckDuckGo/Onboarding/ContextualOnboarding/ContextualDaxDialogsFactory.swift
Outdated
Show resolved
Hide resolved
DuckDuckGo/Onboarding/ContextualOnboarding/ContextualDaxDialogsFactory.swift
Outdated
Show resolved
Hide resolved
DuckDuckGo/Onboarding/ContextualOnboarding/OnboardingFireButtonDialogViewModel.swift
Outdated
Show resolved
Hide resolved
IntegrationTests/Onboarding/ContextualDaxDialogFactoryIntegrationTests.swift
Show resolved
Hide resolved
DuckDuckGo/Onboarding/ContextualOnboarding/OnboardingPixelReporter.swift
Show resolved
Hide resolved
DuckDuckGo/Onboarding/ContextualOnboarding/OnboardingPixelReporter.swift
Show resolved
Hide resolved
UnitTests/Onboarding/ContextualOnboarding/OnboardingPixelReporterTests.swift
Show resolved
Hide resolved
UnitTests/Onboarding/ContextualOnboarding/OnboardingPixelReporterTests.swift
Outdated
Show resolved
Hide resolved
The PR works as expected. I left few comments. Let me know if you want to discuss any of them. |
The requirement was to have send the pixel when typing |
# By Dax the Duck (5) and others # Via GitHub (4) and Diego Rey Mendez (1) * main: (26 commits) PIR broker configs: Add sub actions to ExpectationAction (#3452) Fix Neighbor Report Broker JSON and include optOutUrl for all brokers (#3463) Freemium DBP: Feature Branch to Main PR (#3426) Remove noisy PIR pixels (#3459) Bump version to 1.112.0 (290) Set marketing version to 1.112.0 Update embedded files update fe onboarding (#3415) fire pixels when showing the error screen (#3462) Disable NTP animation when toggling Privacy Feed (#3460) Bump version to 1.111.0 (289) Check the config test pixel from the subscription monitor (#3455) Update OnboardingUserScript to use a weak script broker reference (#3456) fix flaky bookmark store tests (#3431) Workaround for stuck scans on Xcode 16 (#3453) Set autohidesScrollers in Bookmarks Manager; Fix scrollers positioning (#3451) fix Suggestions not reacting to clicks after being interacted with using keyboard (#3457) Fix testWhenChangingSortingInThePanelIsReflectedInTheManager UI Test (#3454) add contextual onboarding pixels (#3447) Bump version to 1.111.0 (288) ... # Conflicts: # DuckDuckGo/Preferences/View/PreferencesViewController.swift
Task/Issue URL: https://app.asana.com/0/0/1208559887614395/f
Description: Add Contextual onboarding pixels
Steps to test this PR:
<!—
Tagging instructions
If this PR isn't ready to be merged for whatever reason it should be marked with the
DO NOT MERGE
label (particularly if it's a draft)If it's pending Product Review/PFR, please add the
Pending Product Review
label.If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information.
—>
Definition of Done:
—
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation