Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add contextual onboarding pixels #3447

Merged
merged 17 commits into from
Oct 25, 2024
Merged

Conversation

SabrinaTardio
Copy link
Collaborator

@SabrinaTardio SabrinaTardio commented Oct 23, 2024

Task/Issue URL: https://app.asana.com/0/0/1208559887614395/f

Description: Add Contextual onboarding pixels

Steps to test this PR:

  1. Run contextual onboarding
  2. Check that when choosing a recommended search m_mac_onboarding_search_option_tapped_unique is sent once
  3. When typing in the bar while this dialog is on m_mac_onboarding_search_custom_unique is sent once
  4. Check that when choosing a recommended site visit m_mac_onboarding_site_option_tapped_unique is sent once
  5. When typing in the bar while this dialog is on m_mac_onboarding_site_custom_unique is sent once
  6. When clicking skip on fire button dialog check m_mac_onboarding_fire_button_prompt_skip_pressed_unique is sent once
  7. When clicking try it on fire button dialog check m_mac_onboarding_fire_button_prompt_try_it_pressed_unique is sent once
  8. When pressing on the fire button while the the onboarding is on m_mac_onboarding_fire_button_pressed_u is sent once
  9. Check the above is not sent if the onboarding is finished
  10. When pressing on the shield icon while the the onboarding is on m_mac_onboarding_privacy_dashboard_opened_u is sent once
  11. Check the above is not sent if the onboarding is finished
  12. Check that on High Five Dialog m_mac_onboarding_finished_u is sent once
  13. Check that when a second site is visited m_mac_second_site_visit_u is sent once
  14. Check m_mac_second_site_visit_u is not sent when doing a second search

<!—
Tagging instructions
If this PR isn't ready to be merged for whatever reason it should be marked with the DO NOT MERGE label (particularly if it's a draft)
If it's pending Product Review/PFR, please add the Pending Product Review label.

If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information.
—>

Definition of Done:

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Contributor

github-actions bot commented Oct 23, 2024

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against e5d1408

@SabrinaTardio SabrinaTardio marked this pull request as ready for review October 24, 2024 13:46
@alessandroboron
Copy link
Contributor

The PR works as expected. I left few comments. Let me know if you want to discuss any of them.
The only thing in terms of behaviour is that I think we should send the pixel not when the user start typing on the address bar but once it actually performs a navigation? It’s possible they input something then they change their mind and use a suggested search/site.

@SabrinaTardio
Copy link
Collaborator Author

The PR works as expected. I left few comments. Let me know if you want to discuss any of them. The only thing in terms of behaviour is that I think we should send the pixel not when the user start typing on the address bar but once it actually performs a navigation? It’s possible they input something then they change their mind and use a suggested search/site.

The requirement was to have send the pixel when typing

@SabrinaTardio SabrinaTardio changed the title add pixels draft add contextual onboarding pixels Oct 25, 2024
@SabrinaTardio SabrinaTardio merged commit c9ffeea into main Oct 25, 2024
22 checks passed
@SabrinaTardio SabrinaTardio deleted the sabrina/onboarding-pixels branch October 25, 2024 11:27
samsymons added a commit that referenced this pull request Oct 29, 2024
# By Dax the Duck (5) and others
# Via GitHub (4) and Diego Rey Mendez (1)
* main: (26 commits)
  PIR broker configs: Add sub actions to ExpectationAction (#3452)
  Fix Neighbor Report Broker JSON and include optOutUrl for all brokers (#3463)
  Freemium DBP: Feature Branch to Main PR (#3426)
  Remove noisy PIR pixels (#3459)
  Bump version to 1.112.0 (290)
  Set marketing version to 1.112.0
  Update embedded files
  update fe onboarding (#3415)
  fire pixels when showing the error screen (#3462)
  Disable NTP animation when toggling Privacy Feed (#3460)
  Bump version to 1.111.0 (289)
  Check the config test pixel from the subscription monitor (#3455)
  Update OnboardingUserScript to use a weak script broker reference (#3456)
  fix flaky bookmark store tests (#3431)
  Workaround for stuck scans on Xcode 16 (#3453)
  Set autohidesScrollers in Bookmarks Manager; Fix scrollers positioning (#3451)
  fix Suggestions not reacting to clicks after being interacted with using keyboard (#3457)
  Fix testWhenChangingSortingInThePanelIsReflectedInTheManager UI Test (#3454)
  add contextual onboarding pixels  (#3447)
  Bump version to 1.111.0 (288)
  ...

# Conflicts:
#	DuckDuckGo/Preferences/View/PreferencesViewController.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants