Disable NTP animation when toggling Privacy Feed #3460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
added a commit
that referenced
this pull request
Oct 29, 2024
# By Dax the Duck (5) and others # Via GitHub (4) and Diego Rey Mendez (1) * main: (26 commits) PIR broker configs: Add sub actions to ExpectationAction (#3452) Fix Neighbor Report Broker JSON and include optOutUrl for all brokers (#3463) Freemium DBP: Feature Branch to Main PR (#3426) Remove noisy PIR pixels (#3459) Bump version to 1.112.0 (290) Set marketing version to 1.112.0 Update embedded files update fe onboarding (#3415) fire pixels when showing the error screen (#3462) Disable NTP animation when toggling Privacy Feed (#3460) Bump version to 1.111.0 (289) Check the config test pixel from the subscription monitor (#3455) Update OnboardingUserScript to use a weak script broker reference (#3456) fix flaky bookmark store tests (#3431) Workaround for stuck scans on Xcode 16 (#3453) Set autohidesScrollers in Bookmarks Manager; Fix scrollers positioning (#3451) fix Suggestions not reacting to clicks after being interacted with using keyboard (#3457) Fix testWhenChangingSortingInThePanelIsReflectedInTheManager UI Test (#3454) add contextual onboarding pixels (#3447) Bump version to 1.111.0 (288) ... # Conflicts: # DuckDuckGo/Preferences/View/PreferencesViewController.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1208626779582462/f
Description:
This is to avoid weird implicit animation of the NTP layout.
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation