Fix testWhenChangingSortingInThePanelIsReflectedInTheManager UI Test #3454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jotaemepereira
commented
Oct 25, 2024
| @@ -61,6 +61,7 @@ class BookmarkSortTests: XCTestCase { | |||
| app.dismissPopover(buttonIdentifier: "Hide") | |||
| app.openBookmarksPanel() | |||
| selectSortByName(mode: .panel) | |||
| app.openBookmarksPanel() // Here we do not open the panel, we close it by tapping the shortcut button again. | |||
There was a problem hiding this comment.
I plan to refactor this method in the future; this method, in reality, taps the bookmarks panel button, and if it is not present, it will show it using a keyboard shortcut, and then tap it.
The open part is confusing because if you call this method and the panel is already opened, it will close it.
There was a problem hiding this comment.
We could consider renaming the method to something like clickBookmarksShortcut perhaps, but I wouldn't block the PR on it.
samsymons
approved these changes
Oct 25, 2024
| @@ -61,6 +61,7 @@ class BookmarkSortTests: XCTestCase { | |||
| app.dismissPopover(buttonIdentifier: "Hide") | |||
| app.openBookmarksPanel() | |||
| selectSortByName(mode: .panel) | |||
| app.openBookmarksPanel() // Here we do not open the panel, we close it by tapping the shortcut button again. | |||
There was a problem hiding this comment.
We could consider renaming the method to something like clickBookmarksShortcut perhaps, but I wouldn't block the PR on it.
jotaemepereira
deleted the
juan/fix-testWhenChangingSortingInThePanelIsReflectedInTheManager
branch
samsymons
added a commit
that referenced
this pull request
Oct 29, 2024
# By Dax the Duck (5) and others # Via GitHub (4) and Diego Rey Mendez (1) * main: (26 commits) PIR broker configs: Add sub actions to ExpectationAction (#3452) Fix Neighbor Report Broker JSON and include optOutUrl for all brokers (#3463) Freemium DBP: Feature Branch to Main PR (#3426) Remove noisy PIR pixels (#3459) Bump version to 1.112.0 (290) Set marketing version to 1.112.0 Update embedded files update fe onboarding (#3415) fire pixels when showing the error screen (#3462) Disable NTP animation when toggling Privacy Feed (#3460) Bump version to 1.111.0 (289) Check the config test pixel from the subscription monitor (#3455) Update OnboardingUserScript to use a weak script broker reference (#3456) fix flaky bookmark store tests (#3431) Workaround for stuck scans on Xcode 16 (#3453) Set autohidesScrollers in Bookmarks Manager; Fix scrollers positioning (#3451) fix Suggestions not reacting to clicks after being interacted with using keyboard (#3457) Fix testWhenChangingSortingInThePanelIsReflectedInTheManager UI Test (#3454) add contextual onboarding pixels (#3447) Bump version to 1.111.0 (288) ... # Conflicts: # DuckDuckGo/Preferences/View/PreferencesViewController.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201037661562251/1208616327102876/f
Tech Design URL:
CC:
Description:
Fixes
testWhenChangingSortingInThePanelIsReflectedInTheManagerUI test. The problem is that depending on the window size, the bookmarks panel might be above the sort button in the manager, causing it not to be tappable.This started happening in the latest internal because we added a new option (delete bookmark) on the bookmarks manager, which pushed the sort button to the right.
Steps to test this PR:
We should run the workflow and see if it works.
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation