Fix inserting selected tab into a scrollable tab collection #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
added a commit
that referenced
this pull request
Jul 19, 2022
* develop: Revert "bump BSK to shane/autofill-username" bump BSK to shane/autofill-username Scroll to selected tab after inserting to ensure that it is visible (#642)
samsymons
added a commit
that referenced
this pull request
Jul 25, 2022
* release/0.27.0: Set version to 0.27.0. Update embedded data. Avoid the data import button being disabled too frequently (#650) Autoconsent refactoring (#643) Refresh top level entities when updating a bookmark (#651) Pinned tabs (#639) Remove local history of the remaining window's tab collection after burning all data (#645) Revert "bump BSK to shane/autofill-username" bump BSK to shane/autofill-username Scroll to selected tab after inserting to ensure that it is visible (#642)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1202608828742665/f
Description:
If the item was inserted outside of collection's visible content rect, the collection needs
an explicit API call to scroll to reveal it.
Steps to test this PR:
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM