Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid the data import button being disabled too frequently #650

Merged
merged 2 commits into from
Jul 22, 2022
Merged

Avoid the data import button being disabled too frequently #650

merged 2 commits into from
Jul 22, 2022

Conversation

samsymons
Copy link
Collaborator

@samsymons samsymons commented Jul 21, 2022 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/1177771139624306/1202637004056115/f
Tech Design URL:
CC:

Description:

This PR fixes two issues:

  1. The import button was disabled in some cases, like when selecting a file for CSV import then changing import type
  2. When selecting LastPass or 1Password and then changing to Safari, the Safari import state was skipping the checkbox selection step

Steps to test this PR:

To test the Safari selection bug:

  1. Select LastPass or 1Password as an import source
  2. Change to Safari and verify that you get put back on the checkbox selection state

To test the disabled import button bug:

  1. Test import for LastPass, 1Password, and Safari - select a CSV file, import it, verify that the button works as expected

Testing checklist:

  • Test with Release configuration
  • Test proper deallocation of tabs
  • Make sure committed submodule changes are desired
Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@amddg44 amddg44 self-assigned this Jul 22, 2022
@amddg44 amddg44 self-requested a review July 22, 2022 15:37
amddg44
amddg44 approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@amddg44 amddg44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Everything worked perfectly 😄

@samsymons samsymons merged commit 54edefc into develop Jul 22, 2022
@samsymons samsymons deleted the sam/prevent-data-import-button-from-being-disabled-too-frequently branch July 22, 2022 16:02
samsymons added a commit that referenced this pull request Jul 24, 2022
@samsymons
Merge branch 'develop' into sam/bookmarks-improvements-phase-1
0883a34 
* develop:
  bump BSK to 18.0.4 (#646)
  Bump BSK to latest version to include CBR compilation fixes (#652)
  Avoid the data import button being disabled too frequently (#650)
  Autoconsent refactoring (#643)
  Refresh top level entities when updating a bookmark (#651)
samsymons added a commit that referenced this pull request Jul 25, 2022
@samsymons
Merge branch 'release/0.27.0'
bd30af1 
* release/0.27.0:
  Set version to 0.27.0.
  Update embedded data.
  Avoid the data import button being disabled too frequently (#650)
  Autoconsent refactoring (#643)
  Refresh top level entities when updating a bookmark (#651)
  Pinned tabs (#639)
  Remove local history of the remaining window's tab collection after burning all data (#645)
  Revert "bump BSK to shane/autofill-username"
  bump BSK to shane/autofill-username
  Scroll to selected tab after inserting to ensure that it is visible (#642)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amddg44 amddg44 amddg44 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsymons @amddg44