Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove local history of the remaining window's tab collection after burning all data #645

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Remove local history of the remaining window's tab collection after burning all data #645

merged 1 commit into from
Jul 20, 2022

Conversation

ayoy
Copy link
Collaborator

@ayoy ayoy commented Jul 18, 2022

Task/Issue URL: https://app.asana.com/0/1177771139624306/1202309934776042/f

Description:
When all data is burned, it closes all windows and clears tabs in the active one.
The "Current window" fire button mode takes the list of domains to be burned
from tab collection's localHistoryOfRemovedTabs. This one wasn't getting wiped
in the active window when all data was cleared.

Steps to test this PR:

  1. Open a couple of tabs, ideally create a history in one of the tabs (open a website and then open another website in the same tab)
  2. Open Fire popover, verify that domains are listed in "Clear All Data" as well as in "Clear Current Window" modes
  3. Clear all data
  4. Open Fire popover again, verify that there is "No data to clear" in "Clear Current Window" mode
  5. Repeat the same, but log in on one of the websites and fireproof it, verify that after burning all data you are still logged in on that website.

Testing checklist:

  • Test with Release configuration
Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@ayoy ayoy requested a review from tomasstrba July 18, 2022 11:03
tomasstrba
tomasstrba approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@tomasstrba tomasstrba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Good catch Dominik! 🎖️ 🏅

@tomasstrba tomasstrba assigned ayoy and unassigned tomasstrba Jul 19, 2022
@ayoy ayoy merged commit e5c116c into develop Jul 20, 2022
@ayoy ayoy deleted the dominik/fix-burn-all branch July 20, 2022 04:24
samsymons added a commit that referenced this pull request Jul 22, 2022
@samsymons
Merge branch 'develop' into sam/bookmarks-improvements-phase-1
33e097d 
* develop:
  Pinned tabs (#639)
  Remove local history of the remaining window's tab collection after burning all data (#645)
samsymons added a commit that referenced this pull request Jul 25, 2022
@samsymons
Merge branch 'release/0.27.0'
bd30af1 
* release/0.27.0:
  Set version to 0.27.0.
  Update embedded data.
  Avoid the data import button being disabled too frequently (#650)
  Autoconsent refactoring (#643)
  Refresh top level entities when updating a bookmark (#651)
  Pinned tabs (#639)
  Remove local history of the remaining window's tab collection after burning all data (#645)
  Revert "bump BSK to shane/autofill-username"
  bump BSK to shane/autofill-username
  Scroll to selected tab after inserting to ensure that it is visible (#642)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasstrba tomasstrba tomasstrba approved these changes

Assignees

@ayoy ayoy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayoy @tomasstrba