Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch upstream #20

Open
wants to merge 549 commits into
base: master
Choose a base branch
from
Open

Fetch upstream #20

wants to merge 549 commits into from

Conversation

Valerionn
Copy link
Member

No description provided.

michaelschattgen and others added 30 commits November 29, 2023 14:44
…on-change-licensedialog-crash

#1231 - Fix crash in License and Changelog dialogs on configuration change
Users understandably get confused by the "No persisted URI permissions"
error. This patch adds some text to the dialog explaining why this
happened and how the user can fix the issue.

This permission issue can happen for one of two reasons:
- The user made a change to the backup destination (renamed, moved,
  deleted, etc)
- Aegis was restored from an Android backup
Explain vault backup permission error
…count-fallback

Improve issuer and account sorting
Some people have managed to snatch the OTP details from Steam using
Xposed while it is being decrypted by the app. Aegis still won't be
able to do the decryption part, but we can add support for importing
the decrypted JSON blob, which only differs slightly from the old
format.
Co-authored-by: Alexander Bakker <ab@alexbakker.me>
feat: Update references to FreeOTP and add version hint "1.x"
Add support for importing decrypted Steam JSON blob
This is mostly a cleanup of the way we do Glide in-memory caching. It
also fixes a few minor issues along the way:

- Entry icon cache keys were based on entry UUID's. This could cause
  problems when changing an entry's icon.
- A TextDrawable could get replaced by the icon of a different entry
  when scrolling through the entry list quickly.
Icon packs may have very generic issuers for their icons (like [aegis-simple-icons](https://github.com/alexbakker/aegis-simple-icons)).
For example, this causes the icon assigning view to suggest the "C" icon for every
entry that contains a "c".

This patch addresses that by giving inverse matches (where the entry
issuer contains the icon issuer) a lower position in the suggested icons
list.
Add support for importing 2FAS schema v4 backups
Use the hash of entry icons as keys for Glide caching
Here some changes to the vault documentation are made. The documentation
is updated to reflect the latest versions of both the vault and the
database, i.e. vault version 1 and database version 3.

Co-authored-by: Alexander Bakker <ab@alexbakker.me>
This prevents a crash that could occur when double tapping the Unlock
button.
This trades performance for making VaultManager a bit easier to reason
about.

This also fixes a rare crash that could occur if the user retries to unlock
the app after the previous attempt resulted in an error related to
parsing the vault. The vault file would no longer be present in memory
after the first attempt, causing the second attempt to crash the app.
This should fix the following crash:

```
Exception java.lang.IndexOutOfBoundsException: setSpan (-1 ... 0) starts before 0
  at android.text.SpannableStringInternal.checkRange (SpannableStringInternal.java:499)
  at android.text.SpannableStringInternal.setSpan (SpannableStringInternal.java:199)
  at android.text.SpannableStringInternal.setSpan (SpannableStringInternal.java:186)
  at android.text.SpannableString.setSpan (SpannableString.java:60)
  at com.beemdevelopment.aegis.ui.views.EntryAdapter$FooterView.refresh (EntryAdapter.java:596)
```
This fixes an issue where the entry list items no longer animated upon
move, insert, delete, etc.

RecyclerView's DefaultItemAnimator automatically scales the animations
according to the user's settings.

Introduced in 9ff8efa
Co-authored-by: Michael Schättgen <michael@schattgen.me>
Prioritize normal icon issuer matches over inverse matches
alexbakker and others added 30 commits November 25, 2024 20:47
Turns out I was a little too enthusiastically removing things in 9d383b8.
The menu may not necessarily have been created yet in all cases.
…ments

Improve search feature for better UX
…tries

Add fix for importing multiple entries
Fix state updates for the lock and sort menu items
…me-share

Make file name of exports consistent
Apply window insets to accommodate system UI.
Required for the ubuntu-latest switch to ubuntu-24.04
Store service name as issuer and tolerate spaces in secret for 2FAS
This is a temporary measure to help users who are stuck in a situation
where they run into OOM conditions due to large icons in their vault
file.
Set largeHeap to true in AndroidManifest
Rename Authenticator Pro -> Stratum
Store non-SVG icons at a maximum of 512x512 and migrate existing icons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.