Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When viewing Serverless project, user should be able to see the name of the project #166182

Closed
rayafratkina opened this issue Sep 11, 2023 · 10 comments · Fixed by #166442
Closed

When viewing Serverless project, user should be able to see the name of the project #166182

rayafratkina opened this issue Sep 11, 2023 · 10 comments · Fixed by #166442
Assignees
@ryankeairns @pgayvallet @Dosant @sixstringcode
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@rayafratkina
Copy link
Contributor

After logging into a project, users should be able to see the name of the project in the header (today it just shows "Projects")
image-20230906-124110

In order to get this done, we need to pass the project name from CP into Kibana, which means if the name is changed this may trigger a Kibana update, but we don't expect this to happen frequently so it's acceptable.
@rayafratkina rayafratkina added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Sep 11, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@vadimkibana
Copy link
Contributor

More info: https://github.com/elastic/cloud/issues/98847

@osmanis
Copy link

osmanis commented Sep 11, 2023

Here's the design:
image

@rayafratkina
Copy link
Contributor Author

Just to clarify: the goal of this issue is just to replace the generic "Project" with the actual name of the project. We are not adding links back to Cloud UI as part of this

@pgayvallet pgayvallet self-assigned this Sep 13, 2023
@pgayvallet
Copy link
Contributor

pgayvallet commented Sep 13, 2023 •
edited
Loading

Apparently the info (project name) is already available in the k8s project controller.

I will update the cloud plugin configuration to add the project_name, similar to what we did for the serverless project id in #161728 (I'll take care of the upstream PR in the project controller too)

@pgayvallet pgayvallet mentioned this issue Sep 13, 2023
Merged
@pgayvallet
Copy link
Contributor

I created #166330 to add the config setting to Kibana and expose it from the cloud plugin, and https://github.com/elastic/project-controller/pull/529 (internal repository) on the controller side.

Note that this PR will need to be deployed to production before being able to merge the controller counter-part, otherwise Kibana will fail to start in environment where the Kibana change is not present because of unknown config key. (I made the config more permissive in #166330 to avoid that situation if we need to add more fields later)

pgayvallet added a commit that referenced this issue Sep 14, 2023
@pgayvallet
[cloud plugin] Add serverless projectName to configuration and contra…
b1bfe92 
…ct (#166330)

## Summary

Part of #166182
Similar to #161728

Add the `serverless.project_name` config setting to the cloud plugin,
and expose the `serverless.projectName` info from the cloud plugin's
API.
@pgayvallet
Copy link
Contributor

#166330 has been merged, meaning that development on the UI side can be started.

The controller PR still has to wait for the kibana PR to be in a version promoted to production

@Dosant Dosant self-assigned this Sep 14, 2023
@Dosant Dosant mentioned this issue Sep 14, 2023
Merged
@vadimkibana vadimkibana assigned vadimkibana and Dosant and unassigned Dosant and vadimkibana Sep 18, 2023
@Dosant Dosant mentioned this issue Sep 18, 2023
Closed
Dosant added a commit that referenced this issue Sep 18, 2023
@Dosant
[Serverless] Show project name in the header (#166442)
05e0666 
> [!IMPORTANT]  
> I plan to merge this as an intermediate state. The next step is
changing the breadcrumbs component and make the project name as part of
it #166593


## Summary

close #166182
Shows project name in the Kibana header. 
To test locally add to the `config/serverless.yml`: 

```
xpack.cloud.serverless.project_id: "random"
xpack.cloud.serverless.project_name: "My Search Project"
```

![Screenshot 2023-09-14 at 13 01
44](https://github.com/elastic/kibana/assets/7784120/4c658e19-5509-4a56-8752-a3a0f677d454)


I hardcoded 320px max-width to enable truncation for longer titles:
![Screenshot 2023-09-14 at 13 02
11](https://github.com/elastic/kibana/assets/7784120/4cab9643-3eb2-4d50-a737-66bb98a46109)

In general, the header is not very flexible and has issues on smaller
screen, but this needs to be fixed separately.


The link still leads to the `/projects` page of the cloud UI
@Dosant
Copy link
Contributor

Dosant commented Sep 18, 2023 •
edited
Loading

Closed by #166442 where we updated the "Projects" label with the "Project name" if available. The link still leads to the /projects page.

I opened #166593 to update the breadcrumbs to use different style and make the project name the part of the breadcrumbs as it is here:

@osmanis
Copy link

osmanis commented Sep 18, 2023

The link still leads to the /projects page.

If we're showing the project name, can we update the link to go to /projects/<project-type>/<project-id>?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryankeairns ryankeairns

@pgayvallet pgayvallet

@Dosant Dosant

@sixstringcode sixstringcode

Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Serverless] Show project name in the header Dosant/kibana
8 participants
@ryankeairns @pgayvallet @Dosant @elasticmachine @rayafratkina @osmanis @vadimkibana @sixstringcode