-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Serverless] Show project name in the header #166442
Conversation
Pinging @elastic/appex-sharedux (Team:SharedUX) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reviewed the code changes and found them to be straightforward, not complex.
There's a TODO comment about the max-width, I think this is for the Product/Design groups to discuss.
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
Important
I plan to merge this as an intermediate state. The next step is changing the breadcrumbs component and make the project name as part of it #166593
Summary
close #166182
Shows project name in the Kibana header.
To test locally add to the
config/serverless.yml
:I hardcoded 320px max-width to enable truncation for longer titles:
In general, the header is not very flexible and has issues on smaller screen, but this needs to be fixed separately.
The link still leads to the
/projects
page of the cloud UI