Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serverless] Show project name in the header #166442

Merged
merged 4 commits into from
Sep 18, 2023

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Sep 14, 2023

Important

I plan to merge this as an intermediate state. The next step is changing the breadcrumbs component and make the project name as part of it #166593

Summary

close #166182
Shows project name in the Kibana header.
To test locally add to the config/serverless.yml:

xpack.cloud.serverless.project_id: "random"
xpack.cloud.serverless.project_name: "My Search Project"

Screenshot 2023-09-14 at 13 01 44

I hardcoded 320px max-width to enable truncation for longer titles:
Screenshot 2023-09-14 at 13 02 11

In general, the header is not very flexible and has issues on smaller screen, but this needs to be fixed separately.

The link still leads to the /projects page of the cloud UI

@Dosant Dosant changed the title show project name [Serverless] Show project name in the header Sep 14, 2023
@Dosant Dosant added release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Sep 14, 2023
@Dosant Dosant marked this pull request as ready for review September 14, 2023 13:30
@Dosant Dosant requested a review from a team as a code owner September 14, 2023 13:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed the code changes and found them to be straightforward, not complex.

There's a TODO comment about the max-width, I think this is for the Product/Design groups to discuss.

@Dosant
Copy link
Contributor Author

Dosant commented Sep 18, 2023

@elasticmachine merge upstream

@Dosant
Copy link
Contributor Author

Dosant commented Sep 18, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #19 / serverless search UI navigation navigate search sidenav & breadcrumbs

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 365.4KB 365.8KB +352.0B
serverless 5.4KB 5.5KB +81.0B
total +433.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When viewing Serverless project, user should be able to see the name of the project
5 participants