-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Serverless] Use EuiBreadcrumbs
instead of EuiHeaderBreadcrumbs
#166593
Comments
Pinging @elastic/appex-sharedux (Team:SharedUX) |
> [!IMPORTANT] > I plan to merge this as an intermediate state. The next step is changing the breadcrumbs component and make the project name as part of it #166593 ## Summary close #166182 Shows project name in the Kibana header. To test locally add to the `config/serverless.yml`: ``` xpack.cloud.serverless.project_id: "random" xpack.cloud.serverless.project_name: "My Search Project" ``` ![Screenshot 2023-09-14 at 13 01 44](https://github.com/elastic/kibana/assets/7784120/4c658e19-5509-4a56-8752-a3a0f677d454) I hardcoded 320px max-width to enable truncation for longer titles: ![Screenshot 2023-09-14 at 13 02 11](https://github.com/elastic/kibana/assets/7784120/4cab9643-3eb2-4d50-a737-66bb98a46109) In general, the header is not very flexible and has issues on smaller screen, but this needs to be fixed separately. The link still leads to the `/projects` page of the cloud UI
Thanks Anton! |
Talked with @ryankeairns , we're going with the text root breadcrumb with the project type instead of the icon. The project selector will be linked to the actual project name. The Figma designs (design 2 above) are current. |
@sixstringcode, @ryankeairns, in this case, would would be the correct labels to use here for the project types. I assume:
|
@ryankeairns, @Dosant: This sounds largely as I had intended. The only thing that caught my eye was the notion that we would include an ever-present project (i.e. solution) type name as part of the root breadcrumbs:
This wasn't my original intent. Given the design in screenshot 2, "Elasticsearch" would only appear as the second breadcrumb if/when a user was currently viewing a page within the Elasticsearch solution navigation bucket. If the user were to navigate to a page within "Project settings", that second breadcrumb should change to "Project settings". Let me know if that makes sense or if further discussion is needed. |
…eadcrumbs` (#169838) ## Summary fix #166593 https://github.com/elastic/kibana/assets/7784120/2569007b-92b6-47d0-a893-8747fbf17d2b - "Projects" link removed, now it is part of breadcrumb. This also makes the header more responsive as we get the flexibility from the breadcrumbs. - Added "View all projects" - Added "Manage project" link
…eadcrumbs` (elastic#169838) ## Summary fix elastic#166593 https://github.com/elastic/kibana/assets/7784120/2569007b-92b6-47d0-a893-8747fbf17d2b - "Projects" link removed, now it is part of breadcrumb. This also makes the header more responsive as we get the flexibility from the breadcrumbs. - Added "View all projects" - Added "Manage project" link
Currently serverless breadcrumbs use EuiHeaderBreadcrumbs but in the design suggests EuiBreadcrumbs were intended to be used
Currently:
Desired:
We should update the component and also adjust the content structure.
This will also fix #165515
And also will help with as the project name becomes part of the breadcrumbs that provides the popover #166182
For the content structure I suggest:
cc @ryankeairns
The text was updated successfully, but these errors were encountered: