Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serverless] Use EuiBreadcrumbs instead of EuiHeaderBreadcrumbs #166593

Closed
Dosant opened this issue Sep 18, 2023 · 5 comments · Fixed by #169838
Closed

[Serverless] Use EuiBreadcrumbs instead of EuiHeaderBreadcrumbs #166593

Dosant opened this issue Sep 18, 2023 · 5 comments · Fixed by #169838
Assignees
Labels
Feature:Chrome Core's Chrome UI (sidenav, header, breadcrumbs) Project:Serverless Work as part of the Serverless project for its initial release Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@Dosant
Copy link
Contributor

Dosant commented Sep 18, 2023

Currently serverless breadcrumbs use EuiHeaderBreadcrumbs but in the design suggests EuiBreadcrumbs were intended to be used

Currently:

image

Desired:

image

We should update the component and also adjust the content structure.

This will also fix #165515
And also will help with as the project name becomes part of the breadcrumbs that provides the popover #166182

For the content structure I suggest:

  • The elastic logo will link to the “home” of the project (getting started / landing / etc)
  • Breadcrumbs:
    • Root breadcrumbs are
      • the “Project Name” with a popup to "manage project" / "view all projects"
      • the project type name
    • Then go navigational breadcrumbs

cc @ryankeairns

@Dosant Dosant added Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) Project:Serverless Work as part of the Serverless project for its initial release Feature:Chrome Core's Chrome UI (sidenav, header, breadcrumbs) labels Sep 18, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@Dosant Dosant self-assigned this Sep 18, 2023
Dosant added a commit that referenced this issue Sep 18, 2023
> [!IMPORTANT]  
> I plan to merge this as an intermediate state. The next step is
changing the breadcrumbs component and make the project name as part of
it #166593


## Summary

close #166182
Shows project name in the Kibana header. 
To test locally add to the `config/serverless.yml`: 

```
xpack.cloud.serverless.project_id: "random"
xpack.cloud.serverless.project_name: "My Search Project"
```

![Screenshot 2023-09-14 at 13 01
44](https://github.com/elastic/kibana/assets/7784120/4c658e19-5509-4a56-8752-a3a0f677d454)


I hardcoded 320px max-width to enable truncation for longer titles:
![Screenshot 2023-09-14 at 13 02
11](https://github.com/elastic/kibana/assets/7784120/4cab9643-3eb2-4d50-a737-66bb98a46109)

In general, the header is not very flexible and has issues on smaller
screen, but this needs to be fixed separately.


The link still leads to the `/projects` page of the cloud UI
@ryankeairns
Copy link
Contributor

Thanks Anton!
Does this look accurate to you @MichaelMarcialis ?

@sixstringcode
Copy link

Talked with @ryankeairns , we're going with the text root breadcrumb with the project type instead of the icon. The project selector will be linked to the actual project name. The Figma designs (design 2 above) are current.

@Dosant
Copy link
Contributor Author

Dosant commented Sep 19, 2023

Talked with @ryankeairns , we're going with the text root breadcrumb with the project type instead of the icon. The project selector will be linked to the actual project name. The Figma designs (design 2 above) are current.

@sixstringcode, @ryankeairns, in this case, would would be the correct labels to use here for the project types. I assume:

  • Elasticsearch
  • Observability
  • Security

@MichaelMarcialis
Copy link
Contributor

Thanks Anton! Does this look accurate to you @MichaelMarcialis ?

@ryankeairns, @Dosant: This sounds largely as I had intended. The only thing that caught my eye was the notion that we would include an ever-present project (i.e. solution) type name as part of the root breadcrumbs:

  • Breadcrumbs:

    • Root breadcrumbs are

      • the “Project Name” with a popup to "manage project" / "view all projects"
      • the project type name
    • Then go navigational breadcrumbs

This wasn't my original intent. Given the design in screenshot 2, "Elasticsearch" would only appear as the second breadcrumb if/when a user was currently viewing a page within the Elasticsearch solution navigation bucket. If the user were to navigate to a page within "Project settings", that second breadcrumb should change to "Project settings". Let me know if that makes sense or if further discussion is needed.

Dosant added a commit that referenced this issue Oct 31, 2023
…eadcrumbs` (#169838)

## Summary

fix #166593


https://github.com/elastic/kibana/assets/7784120/2569007b-92b6-47d0-a893-8747fbf17d2b

- "Projects" link removed, now it is part of breadcrumb. This also makes
the header more responsive as we get the flexibility from the
breadcrumbs.
- Added "View all projects"
- Added "Manage project" link
delanni pushed a commit to delanni/kibana that referenced this issue Nov 6, 2023
…eadcrumbs` (elastic#169838)

## Summary

fix elastic#166593


https://github.com/elastic/kibana/assets/7784120/2569007b-92b6-47d0-a893-8747fbf17d2b

- "Projects" link removed, now it is part of breadcrumb. This also makes
the header more responsive as we get the flexibility from the
breadcrumbs.
- Added "View all projects"
- Added "Manage project" link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Chrome Core's Chrome UI (sidenav, header, breadcrumbs) Project:Serverless Work as part of the Serverless project for its initial release Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants