[ftr] migrate screenshots and snapshots services to FtrService class #100514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
force-pushed
the
migrate/ftr-service-class/misc-common
branch
from
a213098
to
4398279
Compare
spalger
added
release_note:skip
|
Pinging @elastic/kibana-operations (Team:Operations) |
|
Pinging @elastic/kibana-qa (Team:QA) |
spalger
added
the
auto-backport
dmlemeshko
reviewed
May 26, 2021
Comment on lines
+39
to
+41
| ctx.getService('lifecycle').beforeTests.add(async () => { | ||
| await del([this.SESSION_DIRECTORY, this.FAILURE_DIRECTORY]); | ||
| }); |
jbudz
approved these changes
May 26, 2021
💚 Build Succeeded
Metrics [docs]Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: |
💔 Backport failed
To backport manually run: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 26, 2021
* master: (60 commits) [Docs] Index patterns REST API docs (elastic#100549) [Ingest pipelines] add support for fingerprint processor (elastic#100541) ping Core team when renovate bot bumps es client version (elastic#100662) [Maps] Add draw wizard (elastic#100278) Use documentation link service for index pattern field editor (elastic#100609) [Maps] filter dashboard by map extent (elastic#99860) [ftr] migrate screenshots and snapshots services to FtrService class (elastic#100514) fix anomaly functional test (elastic#100504) update breaking changes template to incorporate ES deprecations (elastic#100621) improve default time ranges (elastic#100536) [Gauge] Fixes wrong translations on ranges less than symbol (elastic#100535) [ftr] migrate "globalNav" service to FtrService class (elastic#100604) [ftr] migrate "testSubjects" to FtrService class (elastic#100512) Fix spaces test flakyness (elastic#100605) [Ingest pipelines] add support for ip type in convert processor (elastic#100531) [ftr] migrate "browser" to FtrService class (elastic#100507) [ftr] migrate "find" service to FtrService class (elastic#100509) [telemetry] report config deprecations (elastic#99887) [ftr] migrate "docTable" service to FtrService class (elastic#100595) [ftr] migrate "listingTable" service to FtrService class (elastic#100606) ...
ecezalp
pushed a commit
to ecezalp/kibana
that referenced
this pull request
May 26, 2021
…lastic#100514) Co-authored-by: spalger <spalger@users.noreply.github.com>
ecezalp
pushed a commit
to ecezalp/kibana
that referenced
this pull request
May 26, 2021
…lastic#100514) Co-authored-by: spalger <spalger@users.noreply.github.com>
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
May 28, 2021
…lastic#100514) Co-authored-by: spalger <spalger@users.noreply.github.com> # Conflicts: # test/functional/services/index.ts
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to migrate the root
testdirectory to its own TypeScript project that can be ref'd we need to stop returning class expressions from provider functions. Part of #99148Migrates the 'screenshots' and 'snapshots' services to new
FtrServiceclass, basically just extracted the classes from the providers and remapped variables from scopes to private properties on the service instances. Viewing changes with whitespace disabled will help with review.