Update breaking changes template to incorporate ES deprecations #100621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisonelizabeth
added
backport:skip
cjcenizal
approved these changes
May 26, 2021
There was a problem hiding this comment.
This is great! The guidance you added in the comments seems really helpful. I don't think it's too confusing to use a single template for this. It might even be easier to use than two separate templates, since a confused dev might need to read both to understand which they should use.
|
Thanks @cjcenizal! I'm going to go ahead and merge. @jethr0null I can open a follow-up PR if you see anything else that should be changed/added. |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 26, 2021
* master: (60 commits) [Docs] Index patterns REST API docs (elastic#100549) [Ingest pipelines] add support for fingerprint processor (elastic#100541) ping Core team when renovate bot bumps es client version (elastic#100662) [Maps] Add draw wizard (elastic#100278) Use documentation link service for index pattern field editor (elastic#100609) [Maps] filter dashboard by map extent (elastic#99860) [ftr] migrate screenshots and snapshots services to FtrService class (elastic#100514) fix anomaly functional test (elastic#100504) update breaking changes template to incorporate ES deprecations (elastic#100621) improve default time ranges (elastic#100536) [Gauge] Fixes wrong translations on ranges less than symbol (elastic#100535) [ftr] migrate "globalNav" service to FtrService class (elastic#100604) [ftr] migrate "testSubjects" to FtrService class (elastic#100512) Fix spaces test flakyness (elastic#100605) [Ingest pipelines] add support for ip type in convert processor (elastic#100531) [ftr] migrate "browser" to FtrService class (elastic#100507) [ftr] migrate "find" service to FtrService class (elastic#100509) [telemetry] report config deprecations (elastic#99887) [ftr] migrate "docTable" service to FtrService class (elastic#100595) [ftr] migrate "listingTable" service to FtrService class (elastic#100606) ...
ecezalp
pushed a commit
to ecezalp/kibana
that referenced
this pull request
May 26, 2021
ecezalp
pushed a commit
to ecezalp/kibana
that referenced
this pull request
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
8.0 Breaking changesissue template to incorporate ES deprecations.Background:
We'd like to streamline the process for gaining awareness of any Elasticsearch-specific deprecations that may need support in Upgrade Assistant. My hope is that we can direct ES engineers to open issues using this template when additional work in UA is needed.
How to review:
Looking for feedback as to if it's confusing combining Kibana and Elasticsearch deprecations in the same template, and if it would be clearer if we had two separate issue templates. Also, anything else you think would be helpful to include here.