[Ingest pipelines] add support for fingerprint processor #100541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabarasaba
added
v8.0.0
Team:Kibana Management
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
jrodewig
suggested changes
May 25, 2021
There was a problem hiding this comment.
Thanks for adding this @sabarasaba.
The help text for Target field and Ignore missing require some changes. I also left some minor suggestions for a few other fields. After those are addressed, I'll take another look.
.../application/components/pipeline_editor/components/processor_form/processors/fingerprint.tsx
Show resolved
Hide resolved
.../application/components/pipeline_editor/components/processor_form/processors/fingerprint.tsx
Outdated
Show resolved
Hide resolved
.../application/components/pipeline_editor/components/processor_form/processors/fingerprint.tsx
Show resolved
Hide resolved
.../application/components/pipeline_editor/components/processor_form/processors/fingerprint.tsx
Outdated
Show resolved
Hide resolved
jrodewig
approved these changes
May 25, 2021
.../application/components/pipeline_editor/components/processor_form/processors/fingerprint.tsx
Outdated
Show resolved
Hide resolved
.../application/components/pipeline_editor/components/processor_form/processors/fingerprint.tsx
Show resolved
Hide resolved
...lines/public/application/components/pipeline_editor/__jest__/processors/fingerprint.test.tsx
Outdated
Show resolved
Hide resolved
...lines/public/application/components/pipeline_editor/__jest__/processors/fingerprint.test.tsx
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
alisonelizabeth
approved these changes
May 26, 2021
There was a problem hiding this comment.
Thanks for making the changes @sabarasaba! I left another comment around the implementation for the method default value. Let me know what you think. I'm going to go ahead and approve to unblock.
| method: { | ||
| type: FIELD_TYPES.TEXT, | ||
| defaultValue: 'SHA-1', | ||
| serializer: from.emptyStringToUndefined, |
There was a problem hiding this comment.
I think the serializer will need to be updated as well. If you take a look at the serializer for sort processor/order parameter linked to above, you'll see we're stripping the default value from the request. I think we should follow the same approach here to be consistent.
There was a problem hiding this comment.
uhh, thanks for having a look again @alisonelizabeth! 🙏🏼🙏🏼🙏🏼
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: cc @sabarasaba |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 26, 2021
* master: (60 commits) [Docs] Index patterns REST API docs (elastic#100549) [Ingest pipelines] add support for fingerprint processor (elastic#100541) ping Core team when renovate bot bumps es client version (elastic#100662) [Maps] Add draw wizard (elastic#100278) Use documentation link service for index pattern field editor (elastic#100609) [Maps] filter dashboard by map extent (elastic#99860) [ftr] migrate screenshots and snapshots services to FtrService class (elastic#100514) fix anomaly functional test (elastic#100504) update breaking changes template to incorporate ES deprecations (elastic#100621) improve default time ranges (elastic#100536) [Gauge] Fixes wrong translations on ranges less than symbol (elastic#100535) [ftr] migrate "globalNav" service to FtrService class (elastic#100604) [ftr] migrate "testSubjects" to FtrService class (elastic#100512) Fix spaces test flakyness (elastic#100605) [Ingest pipelines] add support for ip type in convert processor (elastic#100531) [ftr] migrate "browser" to FtrService class (elastic#100507) [ftr] migrate "find" service to FtrService class (elastic#100509) [telemetry] report config deprecations (elastic#99887) [ftr] migrate "docTable" service to FtrService class (elastic#100595) [ftr] migrate "listingTable" service to FtrService class (elastic#100606) ...
sabarasaba
added a commit
to sabarasaba/kibana
that referenced
this pull request
May 26, 2021
sabarasaba
added a commit
that referenced
this pull request
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #90708
Release Note
The Ingest Node Pipelines UI added support to configure a fingerprint processor. This processor computes a hash based on certain fields of the document’s content.
Default description
New processor fields