Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Migrate angular routing to react router #107042

Merged
merged 60 commits into from
Aug 30, 2021
Merged

[Discover] Migrate angular routing to react router #107042

merged 60 commits into from
Aug 30, 2021

Conversation

majagrubic
Copy link
Contributor

@majagrubic majagrubic commented Jul 28, 2021 •
edited by kertal
Loading

Summary

Fixes: #104942.

This change replaces legacy Angular routing with the React router. Functionality-wise, there should be no new changes.

Testing

When testing this, some things to look out for:

  1. loading an existing saved search
  2. filtering/querying
  3. changing index pattern
  4. navigating to discover from an embeddable
  5. sharing a saved search

Basically anything that deals with navigation or a state update is a good candidate to test.

Checklist

Delete any items that are not applicable to this PR.

@majagrubic majagrubic changed the title React router 1 [Discover] Migrate angular routing to react router Jul 28, 2021
dimaanj
dimaanj reviewed Aug 19, 2021
View reviewed changes
Copy link
Contributor

@dimaanj dimaanj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I have gone through test cases and in general looks good, except some of the things, like that.

86ABE996-B437-483E-9A2D-03C791BA46F0_4_5005_c

src/plugins/discover/public/application/apps/context/context_app_route.tsx Outdated Show resolved Hide resolved
src/plugins/discover/public/application/apps/context/context_app_route.tsx Outdated Show resolved Hide resolved
src/plugins/discover/public/application/apps/not_found/not_found_route.tsx Show resolved Hide resolved
src/plugins/discover/public/application/application.ts Outdated Show resolved Hide resolved
src/plugins/discover/public/application/apps/main/discover_main_app.tsx Show resolved Hide resolved
src/plugins/discover/public/application/apps/main/discover_main_route.tsx Show resolved Hide resolved
@majagrubic
Copy link
Contributor Author

@elasticmachine merge upstream

@kertal
Copy link
Member

kertal commented Aug 26, 2021

@elasticmachine merge upstream

@kertal kertal self-requested a review August 26, 2021 17:02
kertal
kertal approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last issue fixed, congrats! Huge step before removing last Angular stuff 🥳 ! Tested over the weeks with Chrome, Firefox, Safari. Works as expected

@kertal
Copy link
Member

kertal commented Aug 30, 2021

@elasticmachine merge upstream

@kertal kertal added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes technical debt Improvement of the software architecture and operational architecture and removed release_note:enhancement labels Aug 30, 2021
dimaanj
dimaanj approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@dimaanj dimaanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!, tested in Chrome.

@kertal kertal merged commit a4c0c1c into elastic:master Aug 30, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 30, 2021
@kibanamachine
[Discover] Migrate angular routing to react router (elastic#107042)
9d240b1
@kibanamachine kibanamachine mentioned this pull request Aug 30, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 567.5KB 550.7KB -16.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
discover 91.9KB 91.8KB -65.0B
Unknown metric groups

async chunk count

id before after diff
discover 7 6 -1

References to deprecated APIs

id before after diff
discover 146 149 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine added a commit that referenced this pull request Aug 30, 2021
@kibanamachine
[Discover] Migrate angular routing to react router (#107042) (#110438)
613b535 
Co-authored-by: Maja Grubic <maja.grubic@elastic.co>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 30, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into vis/migrate-r…
fcc34f0 
…eporting-to-v2

* 'master' of github.com:elastic/kibana: (120 commits)
  [Lens] should register "suffix" field formatter in setup lifecycle (elastic#110218)
  skip flaky suite (elastic#98463)
  skip flaky suite (elastic#108633)
  [Data Table] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#98903)
  fixes failing tests (elastic#110436)
  [TSVB] Remove deprecated `IFieldType` (elastic#110404)
  [Lens] Remove deprecated `IFieldType` (elastic#109825)
  [Vega] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#99023)
  [Visualizations] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#99031)
  [TSVB] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#98914)
  Don't add split part of UI if we have one series (elastic#109483)
  [Discover] Migrate angular routing to react router (elastic#107042)
  [Security Solution][Endpoint][Event Filters] Fixes missing spacers between event filters cards (elastic#110282)
  [ML] Data Grid: Fix alignment of sorting arrow when histogram charts are enabled (elastic#110053)
  [canvas] Fix image argument form issues (elastic#109767)
  Fix asset in Pitch template (elastic#109742)
  chore(NA): moving @kbn/securitysolution-list-api to babel transpiler (elastic#110265)
  chore(NA): moving @kbn/securitysolution-list-constants to babel transpiler (elastic#110269)
  [Fleet] Fix upgrade link in Fleet policy table (elastic#110228)
  [ML] APM Latency Correlations: Fix empty state (elastic#109813)
  ...

# Conflicts:
#	src/plugins/data/common/query/timefilter/types.ts
@kertal kertal mentioned this pull request Jan 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timroes timroes timroes left review comments

@dimaanj dimaanj dimaanj approved these changes

@kertal kertal kertal approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Discover] Migrate to react router
7 participants
@majagrubic @elasticmachine @kertal @kibanamachine @timroes @dimaanj @mistic