Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] Remove deprecated IFieldType #110404

Merged
merged 2 commits into from
Aug 30, 2021
Merged

[TSVB] Remove deprecated IFieldType #110404

merged 2 commits into from
Aug 30, 2021

Conversation

DianaDerevyankina
Copy link
Contributor

Part of #104000

Summary

Removed deprecated IFieldType from TSVB.

For maintainers

@DianaDerevyankina DianaDerevyankina added Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.16.0 labels Aug 27, 2021
@DianaDerevyankina DianaDerevyankina self-assigned this Aug 27, 2021
alexwizp
alexwizp reviewed Aug 27, 2021
View reviewed changes
src/plugins/vis_type_timeseries/public/application/components/aggs/agg.tsx

interface AggProps extends HTMLAttributes<HTMLElement> {
disableDelete: boolean;
fields: IFieldType[];
fields: Record<string, SanitizedFieldType[]>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that IFieldType[] was a wrong type for that component. Issue was introduced on typescriptifying that component (#68519)

I checked this locally:
image

alexwizp
alexwizp approved these changes Aug 27, 2021
View reviewed changes
Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you

@DianaDerevyankina DianaDerevyankina mentioned this pull request Aug 30, 2021
Merged
6 tasks
@DianaDerevyankina DianaDerevyankina marked this pull request as ready for review August 30, 2021 08:05
@DianaDerevyankina DianaDerevyankina requested a review from a team August 30, 2021 08:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@DianaDerevyankina
Copy link
Contributor Author

@elasticmachine merge upstream

stratoula
stratoula approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only, LGTM!

VladLasitsa
VladLasitsa approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@VladLasitsa VladLasitsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
visTypeTimeseries 25 19 -6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

@DianaDerevyankina DianaDerevyankina merged commit e11e3fd into elastic:master Aug 30, 2021
DianaDerevyankina added a commit to DianaDerevyankina/kibana that referenced this pull request Aug 30, 2021
@DianaDerevyankina @kibanamachine
[TSVB] Remove deprecated IFieldType (elastic#110404)
fdd39f5 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@DianaDerevyankina DianaDerevyankina mentioned this pull request Aug 30, 2021
Merged
DianaDerevyankina added a commit that referenced this pull request Aug 30, 2021
@DianaDerevyankina @kibanamachine
[TSVB] Remove deprecated IFieldType (#110404) (#110450)
6910818 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 30, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into vis/migrate-r…
fcc34f0 
…eporting-to-v2

* 'master' of github.com:elastic/kibana: (120 commits)
  [Lens] should register "suffix" field formatter in setup lifecycle (elastic#110218)
  skip flaky suite (elastic#98463)
  skip flaky suite (elastic#108633)
  [Data Table] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#98903)
  fixes failing tests (elastic#110436)
  [TSVB] Remove deprecated `IFieldType` (elastic#110404)
  [Lens] Remove deprecated `IFieldType` (elastic#109825)
  [Vega] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#99023)
  [Visualizations] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#99031)
  [TSVB] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#98914)
  Don't add split part of UI if we have one series (elastic#109483)
  [Discover] Migrate angular routing to react router (elastic#107042)
  [Security Solution][Endpoint][Event Filters] Fixes missing spacers between event filters cards (elastic#110282)
  [ML] Data Grid: Fix alignment of sorting arrow when histogram charts are enabled (elastic#110053)
  [canvas] Fix image argument form issues (elastic#109767)
  Fix asset in Pitch template (elastic#109742)
  chore(NA): moving @kbn/securitysolution-list-api to babel transpiler (elastic#110265)
  chore(NA): moving @kbn/securitysolution-list-constants to babel transpiler (elastic#110269)
  [Fleet] Fix upgrade link in Fleet policy table (elastic#110228)
  [ML] APM Latency Correlations: Fix empty state (elastic#109813)
  ...

# Conflicts:
#	src/plugins/data/common/query/timefilter/types.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexwizp alexwizp alexwizp approved these changes

@stratoula stratoula stratoula approved these changes

@VladLasitsa VladLasitsa VladLasitsa approved these changes

Assignees

@DianaDerevyankina DianaDerevyankina

Labels
Feature:TSVB TSVB (Time Series Visual Builder) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DianaDerevyankina @elasticmachine @kibanamachine @VladLasitsa @stratoula @alexwizp