Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data Table] Expensive queries are causing unnecessary load and delays on Elasticsearch #98903

Merged
merged 13 commits into from
Aug 30, 2021
Merged

[Data Table] Expensive queries are causing unnecessary load and delays on Elasticsearch #98903

merged 13 commits into from
Aug 30, 2021

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Apr 30, 2021 •
edited
Loading

Part of #93770

Summary

This PR is a part of #93770 for src/plugins/vis_type_table/server/usage_collector/get_stats.ts
What was done:

  • Size parameter was changed from 10000 to 1000
  • The paging is used through the soClient.createPointInTimeFinder method
  • Code was optimized, extra cycles were removed

@alexwizp alexwizp self-assigned this Apr 30, 2021
@alexwizp alexwizp added v7.14.0 v8.0.0 Feature:Data Table Data table visualization feature Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Apr 30, 2021
@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@elastic elastic deleted a comment from kibanamachine Apr 30, 2021
afharo
afharo approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@afharo afharo requested a review from lukeelmers April 30, 2021 14:57
@afharo
Copy link
Member

afharo commented Apr 30, 2021

Adding @lukeelmers as a reviewer since he created the PIT API and will have better insights in whether a perPage: 1000 is low enough :)

@alexwizp
Copy link
Contributor Author

@afharo thanks, if @lukeelmers agrees with these changes, I'll update the other telemetries (related to KibanaApp team) in the same way.

lukeelmers
lukeelmers reviewed Apr 30, 2021
View reviewed changes
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whether a perPage: 1000 is low enough :)

I think a size of 1000 is probably fine here. It's a tradeoff between network communication overhead and payload size. AFAIK the visualization SOs are typically not huge in their size, so I'm sure you can get away with retrieving 1000 at a time. FWIW the default size for point in time finder is 1000, and this is what we use in our code for handling SO exports.

src/plugins/vis_type_table/server/usage_collector/get_stats.ts Outdated Show resolved Hide resolved
@alexwizp alexwizp marked this pull request as ready for review May 3, 2021 07:58
@alexwizp alexwizp requested a review from a team May 3, 2021 07:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

This was referenced May 3, 2021
Merged
Open
@lukeelmers lukeelmers mentioned this pull request May 5, 2021
Closed
@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@spalger spalger added v7.15.0 and removed v7.14.0 labels Jun 30, 2021
@mistic mistic added v7.16.0 and removed v7.15.0 labels Aug 18, 2021
@alexwizp
Copy link
Contributor Author

@afharo @stratoula, blocker issue was fixed - PR was rebased to latest master, tested locally and ready to your final review

@stratoula
Copy link
Contributor

@elasticmachine merge upstream

stratoula
stratoula approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested it locally and works fine. Please merge in case of green CI

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

@alexwizp alexwizp merged commit 265fed5 into elastic:master Aug 30, 2021
alexwizp added a commit to alexwizp/kibana that referenced this pull request Aug 30, 2021
@alexwizp @kibanamachine
[Data Table] Expensive queries are causing unnecessary load and delay…
3cda4d9 
…s on Elasticsearch (elastic#98903)

* [Data Table] Expensive queries are causing unnecessary load and delays on Elasticsearch

Part of elastic#93770

* remove extra cycles

* fix PR comments

* fix finder.close

* code cleanup

* add namespaces: ['*'],

* fix jest

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@alexwizp alexwizp mentioned this pull request Aug 30, 2021
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 30, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into vis/migrate-r…
fcc34f0 
…eporting-to-v2

* 'master' of github.com:elastic/kibana: (120 commits)
  [Lens] should register "suffix" field formatter in setup lifecycle (elastic#110218)
  skip flaky suite (elastic#98463)
  skip flaky suite (elastic#108633)
  [Data Table] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#98903)
  fixes failing tests (elastic#110436)
  [TSVB] Remove deprecated `IFieldType` (elastic#110404)
  [Lens] Remove deprecated `IFieldType` (elastic#109825)
  [Vega] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#99023)
  [Visualizations] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#99031)
  [TSVB] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#98914)
  Don't add split part of UI if we have one series (elastic#109483)
  [Discover] Migrate angular routing to react router (elastic#107042)
  [Security Solution][Endpoint][Event Filters] Fixes missing spacers between event filters cards (elastic#110282)
  [ML] Data Grid: Fix alignment of sorting arrow when histogram charts are enabled (elastic#110053)
  [canvas] Fix image argument form issues (elastic#109767)
  Fix asset in Pitch template (elastic#109742)
  chore(NA): moving @kbn/securitysolution-list-api to babel transpiler (elastic#110265)
  chore(NA): moving @kbn/securitysolution-list-constants to babel transpiler (elastic#110269)
  [Fleet] Fix upgrade link in Fleet policy table (elastic#110228)
  [ML] APM Latency Correlations: Fix empty state (elastic#109813)
  ...

# Conflicts:
#	src/plugins/data/common/query/timefilter/types.ts
alexwizp added a commit that referenced this pull request Aug 30, 2021
@alexwizp @kibanamachine
[Data Table] Expensive queries are causing unnecessary load and delay…
eaec7f5 
…s on Elasticsearch (#98903) (#110457)

* [Data Table] Expensive queries are causing unnecessary load and delays on Elasticsearch

Part of #93770

* remove extra cycles

* fix PR comments

* fix finder.close

* code cleanup

* add namespaces: ['*'],

* fix jest

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeelmers lukeelmers lukeelmers left review comments

@stratoula stratoula stratoula approved these changes

@afharo afharo afharo approved these changes

@VladLasitsa VladLasitsa Awaiting requested review from VladLasitsa

@DianaDerevyankina DianaDerevyankina Awaiting requested review from DianaDerevyankina

@dimaanj dimaanj Awaiting requested review from dimaanj

Assignees

@alexwizp alexwizp

Labels
Feature:Data Table Data table visualization feature Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@alexwizp @afharo @elasticmachine @stratoula @kibanamachine @lukeelmers @spalger @mistic