-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sample data] update web log geo.src field to match country code of geo.coordinates #110885
Conversation
Pinging @elastic/kibana-gis (Team:Geo) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested sample data dashboard and it seems consistant and visualizations making all sense. thanks for taking care of it. LGTM
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
…eo.coordinates (elastic#110885) * [sample data] update web log geo.src field to match country code of geo.coordinates * fix functional tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
…-link-to-kibana-app * 'master' of github.com:elastic/kibana: (61 commits) [Logs UI] Fix alert previews for thresholds of `0` (elastic#111150) [Archive Migration][Partial] discover apps-discover (elastic#110437) [APM] Set start date of APM ML job to -4 weeks (elastic#111375) [ML] APM Latency Correlations: Code consolidation. (elastic#110790) [Discover] Fix indices permission for multiline test (elastic#111284) [Detection Rules] Add 7.15 rules (elastic#111464) [Security Solution][Endpoint][Host Isolation] Hide isolate host option in alert details rather than disabling (elastic#111064) React version of angular license view (elastic#111317) [APM] Fix link in readme (elastic#111362) [Security Solution] add agent field to generator (elastic#111428) [Dashboard] Retain Tags on Quicksave (elastic#111015) Reorder App Search ingestion methods (elastic#111361) Port performance docs to new docs system. (elastic#111063) [Security Solution][RAC] Fixes updatedAt loading bug (elastic#111010) [sample data] update web log geo.src field to match country code of geo.coordinates (elastic#110885) [Security solution] [Endpoint] Fix bad artifact migration (elastic#111294) Fix copy typo. (elastic#111203) [build] Remove empty optimize directory (elastic#111393) [Maps] fix term join not updating when editing right field (elastic#111030) [Fleet] Set default settings in component template instead of the index template (elastic#111197) ... # Conflicts: # x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap # x-pack/plugins/reporting/public/management/report_listing.test.tsx
…eo.coordinates (elastic#110885) * [sample data] update web log geo.src field to match country code of geo.coordinates * fix functional tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Fixes #40401
Web logs sample data has inconsistencies between
geo.src
,geo.dest
andgeo. coordinates
where in most casesgeo. coordinates
is not contained in either country denoted bygeo.src
orgeo.dest
. This inconsistency makes understanding the web logs samples impossible and diminishes the usefulness of web logs dashboard and maps.When web logs were originally generated,
geo.coordinates
were assigned based on a random pick in US airport locations. This assignment did not verify that the src or dest country were US.This PR fixes the problem by assigning
geo.src
for each row to "US". That way, the source country and the geo.coordinates are always consistent. Below is the script used to update the data set.Why not update
geo.coordinates
for original geo.src country? Well, Maps has a tutorial wheregeo.coordinates
are reverse geo coded with United States Census Bureau Combined Statistical Area (CSA). Changinggeo.coordinates
would have broken this tutorial. Also, changinggeo.coordinates
to match original geo.src country would have been harder to code.There were a few visualizations that used geo.src. Since geo.src is now always "US", these charts had to be updated to provide more meaningful visualizations. For example, the old sanky diagram kind of sucks when geo.src is always the same value
Updated charts: