Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Endpoint][Host Isolation] Hide isolate host option in alert details rather than disabling #111064

Merged
merged 4 commits into from
Sep 8, 2021
Merged

[Security Solution][Endpoint][Host Isolation] Hide isolate host option in alert details rather than disabling #111064

merged 4 commits into from
Sep 8, 2021

Conversation

parkiino
Copy link
Contributor

@parkiino parkiino commented Sep 2, 2021

Summary

  • Fixes a bug where the "isolate host" is disabled inconsistently in the alert details panel. Instead of disabling the option while waiting for the api calls to finish, we completely hide the option until all the calls come back.

Screenshot

Using slow 3g network connection
hostisolate

@parkiino parkiino added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Endpoint Elastic Endpoint feature Team:Defend Workflows “EDR Workflows” sub-team of Security Solution auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 v7.16.0 labels Sep 2, 2021
@parkiino parkiino requested a review from a team as a code owner September 2, 2021 22:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/esecurity-onboarding-and-lifecycle-mgt (Feature:Endpoint)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

parkiino
parkiino commented Sep 2, 2021
View reviewed changes
.../security_solution/public/detections/components/host_isolation/use_host_isolation_action.tsx Outdated
isHostIsolationPanelOpen === false
isHostIsolationPanelOpen === false &&
loadingHostIsolationStatus === false &&
agentStatus !== HostStatus.UNENROLLED
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to confirm if we should still have the isolate option disabled when the host status is UNENROLLED

@parkiino parkiino mentioned this pull request Sep 3, 2021
Closed
@ashokaditya
Copy link
Member

The menu item showing up suddenly doesn't seem right. Makes the menu jump in size. Is there no way to keep the item disabled until the API response is done?

@parkiino
Copy link
Contributor Author

parkiino commented Sep 7, 2021

The menu item showing up suddenly doesn't seem right. Makes the menu jump in size. Is there no way to keep the item disabled until the API response is done?

That is actually what was originally happening, but I think because the API calls take a variable amount of time to become active, it might confuse the user more than if we were just to hide the option until it is valid.

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

Kibana Pipeline / general / Chrome X-Pack UI Functional Tests Basic License.x-pack/test/functional_basic/apps/ml/permissions/read_ml_access·ts.apps machine learning basic license permissions for user with read ML access (ft_ml_viewer) should display elements on Index Data Visualizer page correctly

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:00]         └-: apps
[00:00:00]           └-> "before all" hook in "apps"
[00:00:00]           └-: machine learning basic license
[00:00:00]             └-> "before all" hook in "machine learning basic license"
[00:00:00]             └-> "before all" hook in "machine learning basic license"
[00:00:00]               │ debg creating role ft_ml_source
[00:00:00]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_source]
[00:00:00]               │ debg creating role ft_ml_source_readonly
[00:00:00]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_source_readonly]
[00:00:00]               │ debg creating role ft_ml_dest
[00:00:00]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_dest]
[00:00:00]               │ debg creating role ft_ml_dest_readonly
[00:00:00]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_dest_readonly]
[00:00:00]               │ debg creating role ft_ml_ui_extras
[00:00:00]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_ml_ui_extras]
[00:00:00]               │ debg creating role ft_default_space_ml_all
[00:00:00]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space_ml_all]
[00:00:00]               │ debg creating role ft_default_space1_ml_all
[00:00:00]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space1_ml_all]
[00:00:00]               │ debg creating role ft_all_spaces_ml_all
[00:00:00]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_all_spaces_ml_all]
[00:00:00]               │ debg creating role ft_default_space_ml_read
[00:00:00]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space_ml_read]
[00:00:00]               │ debg creating role ft_default_space1_ml_read
[00:00:00]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space1_ml_read]
[00:00:00]               │ debg creating role ft_all_spaces_ml_read
[00:00:00]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_all_spaces_ml_read]
[00:00:00]               │ debg creating role ft_default_space_ml_none
[00:00:00]               │ info [o.e.x.s.a.r.TransportPutRoleAction] [node-01] added role [ft_default_space_ml_none]
[00:00:00]               │ debg creating user ft_ml_poweruser
[00:00:00]               │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_poweruser]
[00:00:00]               │ debg created user ft_ml_poweruser
[00:00:00]               │ debg creating user ft_ml_poweruser_spaces
[00:00:00]               │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_poweruser_spaces]
[00:00:00]               │ debg created user ft_ml_poweruser_spaces
[00:00:00]               │ debg creating user ft_ml_poweruser_space1
[00:00:00]               │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_poweruser_space1]
[00:00:00]               │ debg created user ft_ml_poweruser_space1
[00:00:00]               │ debg creating user ft_ml_poweruser_all_spaces
[00:00:00]               │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_poweruser_all_spaces]
[00:00:00]               │ debg created user ft_ml_poweruser_all_spaces
[00:00:00]               │ debg creating user ft_ml_viewer
[00:00:01]               │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_viewer]
[00:00:01]               │ debg created user ft_ml_viewer
[00:00:01]               │ debg creating user ft_ml_viewer_spaces
[00:00:01]               │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_viewer_spaces]
[00:00:01]               │ debg created user ft_ml_viewer_spaces
[00:00:01]               │ debg creating user ft_ml_viewer_space1
[00:00:01]               │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_viewer_space1]
[00:00:01]               │ debg created user ft_ml_viewer_space1
[00:00:01]               │ debg creating user ft_ml_viewer_all_spaces
[00:00:01]               │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_viewer_all_spaces]
[00:00:01]               │ debg created user ft_ml_viewer_all_spaces
[00:00:01]               │ debg creating user ft_ml_unauthorized
[00:00:01]               │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_unauthorized]
[00:00:01]               │ debg created user ft_ml_unauthorized
[00:00:01]               │ debg creating user ft_ml_unauthorized_spaces
[00:00:01]               │ info [o.e.x.s.a.u.TransportPutUserAction] [node-01] added user [ft_ml_unauthorized_spaces]
[00:00:01]               │ debg created user ft_ml_unauthorized_spaces
[00:00:01]             └-: permissions
[00:00:01]               └-> "before all" hook in "permissions"
[00:01:12]               └-: for user with read ML access
[00:01:12]                 └-> "before all" hook in "for user with read ML access"
[00:01:12]                 └-: (ft_ml_viewer)
[00:01:12]                   └-> "before all" hook for "should display the ML entry in Kibana app menu"
[00:01:12]                   └-> "before all" hook for "should display the ML entry in Kibana app menu"
[00:01:12]                     │ debg No indices to delete [pattern=.ml-*]
[00:01:12]                     │ info [x-pack/test/functional/es_archives/ml/module_sample_ecommerce] Loading "mappings.json"
[00:01:12]                     │ info [x-pack/test/functional/es_archives/ml/module_sample_ecommerce] Loading "data.json.gz"
[00:01:12]                     │ info [x-pack/test/functional/es_archives/ml/module_sample_ecommerce] Skipped restore for existing index "ft_module_sample_ecommerce"
[00:01:12]                     │ debg Searching for 'index-pattern' with title 'ft_module_sample_ecommerce'...
[00:01:12]                     │ debg  > Found '625f1b80-0fff-11ec-9eb4-57a6d9f665ff'
[00:01:12]                     │ debg Index pattern with title 'ft_module_sample_ecommerce' already exists. Nothing to create.
[00:01:12]                     │ debg SecurityPage.forceLogout
[00:01:12]                     │ debg Find.existsByDisplayedByCssSelector('.login-form') with timeout=100
[00:01:12]                     │ debg Already on the login page, not forcing anything
[00:01:12]                     │ debg TestSubjects.exists(loginForm)
[00:01:12]                     │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="loginForm"]') with timeout=2500
[00:01:12]                     │ debg Waiting for Login Form to appear.
[00:01:12]                     │ debg Waiting up to 100000ms for login form...
[00:01:12]                     │ debg TestSubjects.exists(loginForm)
[00:01:12]                     │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="loginForm"]') with timeout=2500
[00:01:12]                     │ debg TestSubjects.setValue(loginUsername, ft_ml_viewer)
[00:01:12]                     │ debg TestSubjects.click(loginUsername)
[00:01:12]                     │ debg Find.clickByCssSelector('[data-test-subj="loginUsername"]') with timeout=10000
[00:01:12]                     │ debg Find.findByCssSelector('[data-test-subj="loginUsername"]') with timeout=10000
[00:01:12]                     │ debg TestSubjects.setValue(loginPassword, mlv001)
[00:01:12]                     │ debg TestSubjects.click(loginPassword)
[00:01:12]                     │ debg Find.clickByCssSelector('[data-test-subj="loginPassword"]') with timeout=10000
[00:01:12]                     │ debg Find.findByCssSelector('[data-test-subj="loginPassword"]') with timeout=10000
[00:01:12]                     │ debg TestSubjects.click(loginSubmit)
[00:01:12]                     │ debg Find.clickByCssSelector('[data-test-subj="loginSubmit"]') with timeout=10000
[00:01:12]                     │ debg Find.findByCssSelector('[data-test-subj="loginSubmit"]') with timeout=10000
[00:01:12]                     │ debg Waiting for login result, expected: chrome.
[00:01:12]                     │ debg Find.findByCssSelector('[data-test-subj="userMenuAvatar"]') with timeout=20000
[00:01:12]                     │ proc [kibana]   log   [17:17:58.947] [info][plugins][routes][security] Logging in with provider "basic" (basic)
[00:01:15]                     │ debg browser[INFO] http://localhost:6191/app/home 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:01:15]                     │
[00:01:15]                     │ debg browser[INFO] http://localhost:6191/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:01:15]                     │ debg Finished login process currentUrl = http://localhost:6191/app/home#/
[00:01:15]                     │ debg Waiting up to 20000ms for logout button visible...
[00:01:15]                     │ debg TestSubjects.exists(userMenuButton)
[00:01:15]                     │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="userMenuButton"]') with timeout=2500
[00:01:15]                     │ debg TestSubjects.exists(userMenu)
[00:01:15]                     │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="userMenu"]') with timeout=2500
[00:01:18]                     │ debg --- retry.tryForTime error: [data-test-subj="userMenu"] is not displayed
[00:01:18]                     │ debg TestSubjects.click(userMenuButton)
[00:01:18]                     │ debg Find.clickByCssSelector('[data-test-subj="userMenuButton"]') with timeout=10000
[00:01:18]                     │ debg Find.findByCssSelector('[data-test-subj="userMenuButton"]') with timeout=10000
[00:01:18]                     │ debg TestSubjects.exists(userMenu)
[00:01:18]                     │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="userMenu"]') with timeout=120000
[00:01:19]                     │ debg TestSubjects.exists(userMenu > logoutLink)
[00:01:19]                     │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="userMenu"] [data-test-subj="logoutLink"]') with timeout=2500
[00:01:19]                   └-> should display the ML entry in Kibana app menu
[00:01:19]                     └-> "before each" hook: global before each for "should display the ML entry in Kibana app menu"
[00:01:19]                     │ debg === TEST STEP === should open the Kibana app menu
[00:01:19]                     │ debg TestSubjects.exists(collapsibleNav)
[00:01:19]                     │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=2500
[00:01:21]                     │ debg --- retry.tryForTime error: [data-test-subj="collapsibleNav"] is not displayed
[00:01:22]                     │ debg TestSubjects.click(toggleNavButton)
[00:01:22]                     │ debg Find.clickByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:01:22]                     │ debg Find.findByCssSelector('[data-test-subj="toggleNavButton"]') with timeout=10000
[00:01:22]                     │ debg TestSubjects.exists(collapsibleNav)
[00:01:22]                     │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=120000
[00:01:22]                     │ debg === TEST STEP === should display the ML nav link
[00:01:22]                     │ debg TestSubjects.find(collapsibleNav)
[00:01:22]                     │ debg Find.findByCssSelector('[data-test-subj="collapsibleNav"]') with timeout=10000
[00:01:22]                     └- ✓ pass  (3.4s) "apps machine learning basic license permissions for user with read ML access (ft_ml_viewer) should display the ML entry in Kibana app menu"
[00:01:22]                   └-> should display tabs in the ML app correctly
[00:01:22]                     └-> "before each" hook: global before each for "should display tabs in the ML app correctly"
[00:01:22]                     │ debg === TEST STEP === should load the ML app
[00:01:22]                     │ debg navigating to ml url: http://localhost:6191/app/ml
[00:01:22]                     │ debg navigate to: http://localhost:6191/app/ml
[00:01:22]                     │ debg browser[INFO] http://localhost:6191/app/ml?_t=1631035088383 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:01:22]                     │
[00:01:22]                     │ debg browser[INFO] http://localhost:6191/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:01:22]                     │ debg ... sleep(700) start
[00:01:23]                     │ debg ... sleep(700) end
[00:01:23]                     │ debg returned from get, calling refresh
[00:01:24]                     │ debg browser[INFO] http://localhost:6191/app/ml?_t=1631035088383 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:01:24]                     │
[00:01:24]                     │ debg browser[INFO] http://localhost:6191/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:01:24]                     │ debg currentUrl = http://localhost:6191/app/ml
[00:01:24]                     │          appUrl = http://localhost:6191/app/ml
[00:01:24]                     │ debg TestSubjects.find(kibanaChrome)
[00:01:24]                     │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:01:24]                     │ debg ... sleep(501) start
[00:01:25]                     │ debg ... sleep(501) end
[00:01:25]                     │ debg in navigateTo url = http://localhost:6191/app/ml/datavisualizer
[00:01:25]                     │ debg --- retry.tryForTime error: URL changed, waiting for it to settle
[00:01:25]                     │ debg ... sleep(501) start
[00:01:26]                     │ debg ... sleep(501) end
[00:01:26]                     │ debg in navigateTo url = http://localhost:6191/app/ml/datavisualizer
[00:01:26]                     │ debg TestSubjects.exists(mlApp)
[00:01:26]                     │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="mlApp"]') with timeout=2000
[00:01:26]                     │ debg === TEST STEP === should display the disabled "Overview" tab
[00:01:26]                     │ debg TestSubjects.isEnabled(~mlMainTab & ~overview)
[00:01:26]                     │ debg TestSubjects.find(~mlMainTab & ~overview)
[00:01:26]                     │ debg Find.findByCssSelector('[data-test-subj~="mlMainTab"][data-test-subj~="overview"]') with timeout=10000
[00:01:26]                     │ debg === TEST STEP === should display the disabled "Anomaly Detection" tab
[00:01:26]                     │ debg TestSubjects.isEnabled(~mlMainTab & ~anomalyDetection)
[00:01:26]                     │ debg TestSubjects.find(~mlMainTab & ~anomalyDetection)
[00:01:26]                     │ debg Find.findByCssSelector('[data-test-subj~="mlMainTab"][data-test-subj~="anomalyDetection"]') with timeout=10000
[00:01:26]                     │ debg === TEST STEP === should display the disabled "Data Frame Analytics" tab
[00:01:26]                     │ debg TestSubjects.isEnabled(~mlMainTab & ~dataFrameAnalytics)
[00:01:26]                     │ debg TestSubjects.find(~mlMainTab & ~dataFrameAnalytics)
[00:01:26]                     │ debg Find.findByCssSelector('[data-test-subj~="mlMainTab"][data-test-subj~="dataFrameAnalytics"]') with timeout=10000
[00:01:26]                     │ debg === TEST STEP === should display the enabled "Data Visualizer" tab
[00:01:26]                     │ debg TestSubjects.isEnabled(~mlMainTab & ~dataVisualizer)
[00:01:26]                     │ debg TestSubjects.find(~mlMainTab & ~dataVisualizer)
[00:01:26]                     │ debg Find.findByCssSelector('[data-test-subj~="mlMainTab"][data-test-subj~="dataVisualizer"]') with timeout=10000
[00:01:26]                     │ debg === TEST STEP === should display the disabled "Settings" tab
[00:01:26]                     │ debg TestSubjects.isEnabled(~mlMainTab & ~settings)
[00:01:26]                     │ debg TestSubjects.find(~mlMainTab & ~settings)
[00:01:26]                     │ debg Find.findByCssSelector('[data-test-subj~="mlMainTab"][data-test-subj~="settings"]') with timeout=10000
[00:01:26]                     └- ✓ pass  (4.1s) "apps machine learning basic license permissions for user with read ML access (ft_ml_viewer) should display tabs in the ML app correctly"
[00:01:26]                   └-> should display elements on Data Visualizer home page correctly
[00:01:26]                     └-> "before each" hook: global before each for "should display elements on Data Visualizer home page correctly"
[00:01:26]                     │ debg === TEST STEP === should load the data visualizer page
[00:01:26]                     │ debg TestSubjects.click(~mlMainTab & ~dataVisualizer)
[00:01:26]                     │ debg Find.clickByCssSelector('[data-test-subj~="mlMainTab"][data-test-subj~="dataVisualizer"]') with timeout=10000
[00:01:26]                     │ debg Find.findByCssSelector('[data-test-subj~="mlMainTab"][data-test-subj~="dataVisualizer"]') with timeout=10000
[00:01:26]                     │ debg TestSubjects.exists(~mlMainTab & ~dataVisualizer & ~selected)
[00:01:26]                     │ debg Find.existsByDisplayedByCssSelector('[data-test-subj~="mlMainTab"][data-test-subj~="dataVisualizer"][data-test-subj~="selected"]') with timeout=120000
[00:01:26]                     │ debg TestSubjects.exists(mlPageDataVisualizerSelector)
[00:01:26]                     │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="mlPageDataVisualizerSelector"]') with timeout=120000
[00:01:26]                     │ debg === TEST STEP === should display the "import data" card with enabled button
[00:01:26]                     │ debg TestSubjects.exists(mlDataVisualizerCardImportData)
[00:01:26]                     │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="mlDataVisualizerCardImportData"]') with timeout=120000
[00:01:26]                     │ debg TestSubjects.isEnabled(mlDataVisualizerUploadFileButton)
[00:01:26]                     │ debg TestSubjects.find(mlDataVisualizerUploadFileButton)
[00:01:26]                     │ debg Find.findByCssSelector('[data-test-subj="mlDataVisualizerUploadFileButton"]') with timeout=10000
[00:01:26]                     │ debg === TEST STEP === should display the "select index pattern" card with enabled button
[00:01:26]                     │ debg TestSubjects.exists(mlDataVisualizerCardIndexData)
[00:01:26]                     │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="mlDataVisualizerCardIndexData"]') with timeout=120000
[00:01:26]                     │ debg TestSubjects.isEnabled(mlDataVisualizerSelectIndexButton)
[00:01:26]                     │ debg TestSubjects.find(mlDataVisualizerSelectIndexButton)
[00:01:26]                     │ debg Find.findByCssSelector('[data-test-subj="mlDataVisualizerSelectIndexButton"]') with timeout=10000
[00:01:26]                     │ debg === TEST STEP === should display the "start trial" card with enabled button
[00:01:26]                     │ debg TestSubjects.exists(mlDataVisualizerCardStartTrial)
[00:01:26]                     │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="mlDataVisualizerCardStartTrial"]') with timeout=120000
[00:01:26]                     │ debg TestSubjects.isEnabled(mlDataVisualizerStartTrialButton)
[00:01:26]                     │ debg TestSubjects.find(mlDataVisualizerStartTrialButton)
[00:01:26]                     │ debg Find.findByCssSelector('[data-test-subj="mlDataVisualizerStartTrialButton"]') with timeout=10000
[00:01:26]                     └- ✓ pass  (351ms) "apps machine learning basic license permissions for user with read ML access (ft_ml_viewer) should display elements on Data Visualizer home page correctly"
[00:01:26]                   └-> should display elements on Index Data Visualizer page correctly
[00:01:26]                     └-> "before each" hook: global before each for "should display elements on Index Data Visualizer page correctly"
[00:01:26]                     │ debg === TEST STEP === should load an index into the data visualizer page
[00:01:26]                     │ debg TestSubjects.click(mlDataVisualizerSelectIndexButton)
[00:01:26]                     │ debg Find.clickByCssSelector('[data-test-subj="mlDataVisualizerSelectIndexButton"]') with timeout=10000
[00:01:26]                     │ debg Find.findByCssSelector('[data-test-subj="mlDataVisualizerSelectIndexButton"]') with timeout=10000
[00:01:26]                     │ debg TestSubjects.exists(mlPageSourceSelection)
[00:01:26]                     │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="mlPageSourceSelection"]') with timeout=120000
[00:01:27]                     │ debg TestSubjects.setValue(savedObjectFinderSearchInput, ft_module_sample_ecommerce)
[00:01:27]                     │ debg TestSubjects.click(savedObjectFinderSearchInput)
[00:01:27]                     │ debg Find.clickByCssSelector('[data-test-subj="savedObjectFinderSearchInput"]') with timeout=10000
[00:01:27]                     │ debg Find.findByCssSelector('[data-test-subj="savedObjectFinderSearchInput"]') with timeout=10000
[00:01:27]                     │ debg TestSubjects.exists(savedObjectTitleft_module_sample_ecommerce)
[00:01:27]                     │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="savedObjectTitleft_module_sample_ecommerce"]') with timeout=120000
[00:01:27]                     │ debg TestSubjects.clickWhenNotDisabled(savedObjectTitleft_module_sample_ecommerce)
[00:01:27]                     │ debg Find.clickByCssSelectorWhenNotDisabled('[data-test-subj="savedObjectTitleft_module_sample_ecommerce"]') with timeout=10000
[00:01:27]                     │ debg Find.findByCssSelector('[data-test-subj="savedObjectTitleft_module_sample_ecommerce"]') with timeout=10000
[00:01:28]                     │ debg TestSubjects.exists(dataVisualizerIndexPage)
[00:01:28]                     │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="dataVisualizerIndexPage"]') with timeout=10000
[00:01:29]                     │ debg === TEST STEP === should display the time range step
[00:01:29]                     │ debg TestSubjects.exists(dataVisualizerTimeRangeSelectorSection)
[00:01:29]                     │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="dataVisualizerTimeRangeSelectorSection"]') with timeout=120000
[00:01:29]                     │ debg === TEST STEP === should load data for full time range
[00:01:29]                     │ debg TestSubjects.clickWhenNotDisabled(dataVisualizerButtonUseFullData)
[00:01:29]                     │ debg Find.clickByCssSelectorWhenNotDisabled('[data-test-subj="dataVisualizerButtonUseFullData"]') with timeout=10000
[00:01:29]                     │ debg Find.findByCssSelector('[data-test-subj="dataVisualizerButtonUseFullData"]') with timeout=10000
[00:01:29]                     │ debg TestSubjects.getVisibleText(dataVisualizerTotalDocCount)
[00:01:29]                     │ debg TestSubjects.find(dataVisualizerTotalDocCount)
[00:01:29]                     │ debg Find.findByCssSelector('[data-test-subj="dataVisualizerTotalDocCount"]') with timeout=10000
[00:01:29]                     │ debg --- retry.tryForTime error: Expected total document count to be '287' (got '0')
[00:01:30]                     │ debg TestSubjects.getVisibleText(dataVisualizerTotalDocCount)
[00:01:30]                     │ debg TestSubjects.find(dataVisualizerTotalDocCount)
[00:01:30]                     │ debg Find.findByCssSelector('[data-test-subj="dataVisualizerTotalDocCount"]') with timeout=10000
[00:01:30]                     │ debg --- retry.tryForTime failed again with the same message...
[00:01:30]                     │ debg TestSubjects.getVisibleText(dataVisualizerTotalDocCount)
[00:01:30]                     │ debg TestSubjects.find(dataVisualizerTotalDocCount)
[00:01:30]                     │ debg Find.findByCssSelector('[data-test-subj="dataVisualizerTotalDocCount"]') with timeout=10000
[00:01:30]                     │ debg --- retry.tryForTime failed again with the same message...
[00:01:31]                     │ debg TestSubjects.getVisibleText(dataVisualizerTotalDocCount)
[00:01:31]                     │ debg TestSubjects.find(dataVisualizerTotalDocCount)
[00:01:31]                     │ debg Find.findByCssSelector('[data-test-subj="dataVisualizerTotalDocCount"]') with timeout=10000
[00:01:31]                     │ debg --- retry.tryForTime failed again with the same message...
[00:01:31]                     │ debg TestSubjects.getVisibleText(dataVisualizerTotalDocCount)
[00:01:31]                     │ debg TestSubjects.find(dataVisualizerTotalDocCount)
[00:01:31]                     │ debg Find.findByCssSelector('[data-test-subj="dataVisualizerTotalDocCount"]') with timeout=10000
[00:01:31]                     │ debg --- retry.tryForTime failed again with the same message...
[00:01:32]                     │ debg TestSubjects.getVisibleText(dataVisualizerTotalDocCount)
[00:01:32]                     │ debg TestSubjects.find(dataVisualizerTotalDocCount)
[00:01:32]                     │ debg Find.findByCssSelector('[data-test-subj="dataVisualizerTotalDocCount"]') with timeout=10000
[00:01:32]                     │ debg --- retry.tryForTime failed again with the same message...
[00:01:32]                     │ debg TestSubjects.getVisibleText(dataVisualizerTotalDocCount)
[00:01:32]                     │ debg TestSubjects.find(dataVisualizerTotalDocCount)
[00:01:32]                     │ debg Find.findByCssSelector('[data-test-subj="dataVisualizerTotalDocCount"]') with timeout=10000
[00:01:32]                     │ debg --- retry.tryForTime failed again with the same message...
[00:01:33]                     │ debg TestSubjects.getVisibleText(dataVisualizerTotalDocCount)
[00:01:33]                     │ debg TestSubjects.find(dataVisualizerTotalDocCount)
[00:01:33]                     │ debg Find.findByCssSelector('[data-test-subj="dataVisualizerTotalDocCount"]') with timeout=10000
[00:01:33]                     │ debg --- retry.tryForTime failed again with the same message...
[00:01:33]                     │ debg TestSubjects.getVisibleText(dataVisualizerTotalDocCount)
[00:01:33]                     │ debg TestSubjects.find(dataVisualizerTotalDocCount)
[00:01:33]                     │ debg Find.findByCssSelector('[data-test-subj="dataVisualizerTotalDocCount"]') with timeout=10000
[00:01:33]                     │ debg --- retry.tryForTime failed again with the same message...
[00:01:34]                     │ info Taking screenshot "/dev/shm/workspace/parallel/9/kibana/x-pack/test/functional/screenshots/failure/apps machine learning basic license permissions for user with read ML access _ft_ml_viewer_ should display elements on Index Data Visualizer page correctly.png"
[00:01:34]                     │ info Current URL is: http://localhost:6191/app/ml/jobs/new_job/datavisualizer?index=625f1b80-0fff-11ec-9eb4-57a6d9f665ff
[00:01:34]                     │ info Saving page source to: /dev/shm/workspace/parallel/9/kibana/x-pack/test/functional/failure_debug/html/apps machine learning basic license permissions for user with read ML access _ft_ml_viewer_ should display elements on Index Data Visualizer page correctly.html
[00:01:34]                     └- ✖ fail: apps machine learning basic license permissions for user with read ML access (ft_ml_viewer) should display elements on Index Data Visualizer page correctly
[00:01:34]                     │      retry.tryForTime timeout: Error: Expected total document count to be '287' (got '0')
[00:01:34]                     │     at Assertion.assert (/dev/shm/workspace/parallel/9/kibana/node_modules/@kbn/expect/expect.js:100:11)
[00:01:34]                     │     at Assertion.eql (/dev/shm/workspace/parallel/9/kibana/node_modules/@kbn/expect/expect.js:244:8)
[00:01:34]                     │     at /dev/shm/workspace/parallel/9/kibana/x-pack/test/functional/services/ml/data_visualizer_index_based.ts:28:29
[00:01:34]                     │     at runMicrotasks (<anonymous>)
[00:01:34]                     │     at processTicksAndRejections (internal/process/task_queues.js:95:5)
[00:01:34]                     │     at runAttempt (/dev/shm/workspace/parallel/9/kibana/test/common/services/retry/retry_for_success.ts:27:15)
[00:01:34]                     │     at retryForSuccess (/dev/shm/workspace/parallel/9/kibana/test/common/services/retry/retry_for_success.ts:66:21)
[00:01:34]                     │     at RetryService.tryForTime (/dev/shm/workspace/parallel/9/kibana/test/common/services/retry/retry.ts:22:12)
[00:01:34]                     │     at Object.assertTotalDocumentCount (/dev/shm/workspace/parallel/9/kibana/x-pack/test/functional/services/ml/data_visualizer_index_based.ts:26:7)
[00:01:34]                     │     at Object.clickUseFullDataButton (/dev/shm/workspace/parallel/9/kibana/x-pack/test/functional/services/ml/data_visualizer_index_based.ts:37:7)
[00:01:34]                     │     at Context.<anonymous> (/dev/shm/workspace/parallel/9/kibana/x-pack/test/functional_basic/apps/ml/permissions/read_ml_access.ts:121:11)
[00:01:34]                     │     at Object.apply (/dev/shm/workspace/parallel/9/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
[00:01:34]                     │   Error: retry.tryForTime timeout: Error: Expected total document count to be '287' (got '0')
[00:01:34]                     │       at Assertion.assert (/dev/shm/workspace/parallel/9/kibana/node_modules/@kbn/expect/expect.js:100:11)
[00:01:34]                     │       at Assertion.eql (/dev/shm/workspace/parallel/9/kibana/node_modules/@kbn/expect/expect.js:244:8)
[00:01:34]                     │       at /dev/shm/workspace/parallel/9/kibana/x-pack/test/functional/services/ml/data_visualizer_index_based.ts:28:29
[00:01:34]                     │       at runMicrotasks (<anonymous>)
[00:01:34]                     │       at processTicksAndRejections (internal/process/task_queues.js:95:5)
[00:01:34]                     │       at runAttempt (/dev/shm/workspace/parallel/9/kibana/test/common/services/retry/retry_for_success.ts:27:15)
[00:01:34]                     │       at retryForSuccess (/dev/shm/workspace/parallel/9/kibana/test/common/services/retry/retry_for_success.ts:66:21)
[00:01:34]                     │       at RetryService.tryForTime (/dev/shm/workspace/parallel/9/kibana/test/common/services/retry/retry.ts:22:12)
[00:01:34]                     │       at Object.assertTotalDocumentCount (test/functional/services/ml/data_visualizer_index_based.ts:26:7)
[00:01:34]                     │       at Object.clickUseFullDataButton (test/functional/services/ml/data_visualizer_index_based.ts:37:7)
[00:01:34]                     │       at Context.<anonymous> (test/functional_basic/apps/ml/permissions/read_ml_access.ts:121:11)
[00:01:34]                     │       at Object.apply (/dev/shm/workspace/parallel/9/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
[00:01:34]                     │       at onFailure (/dev/shm/workspace/parallel/9/kibana/test/common/services/retry/retry_for_success.ts:17:9)
[00:01:34]                     │       at retryForSuccess (/dev/shm/workspace/parallel/9/kibana/test/common/services/retry/retry_for_success.ts:57:13)
[00:01:34]                     │       at RetryService.tryForTime (/dev/shm/workspace/parallel/9/kibana/test/common/services/retry/retry.ts:22:12)
[00:01:34]                     │       at Object.assertTotalDocumentCount (test/functional/services/ml/data_visualizer_index_based.ts:26:7)
[00:01:34]                     │       at Object.clickUseFullDataButton (test/functional/services/ml/data_visualizer_index_based.ts:37:7)
[00:01:34]                     │       at Context.<anonymous> (test/functional_basic/apps/ml/permissions/read_ml_access.ts:121:11)
[00:01:34]                     │       at Object.apply (/dev/shm/workspace/parallel/9/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
[00:01:34]                     │ 
[00:01:34]                     │

Stack Trace

Error: retry.tryForTime timeout: Error: Expected total document count to be '287' (got '0')
    at Assertion.assert (/dev/shm/workspace/parallel/9/kibana/node_modules/@kbn/expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/parallel/9/kibana/node_modules/@kbn/expect/expect.js:244:8)
    at /dev/shm/workspace/parallel/9/kibana/x-pack/test/functional/services/ml/data_visualizer_index_based.ts:28:29
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at runAttempt (/dev/shm/workspace/parallel/9/kibana/test/common/services/retry/retry_for_success.ts:27:15)
    at retryForSuccess (/dev/shm/workspace/parallel/9/kibana/test/common/services/retry/retry_for_success.ts:66:21)
    at RetryService.tryForTime (/dev/shm/workspace/parallel/9/kibana/test/common/services/retry/retry.ts:22:12)
    at Object.assertTotalDocumentCount (test/functional/services/ml/data_visualizer_index_based.ts:26:7)
    at Object.clickUseFullDataButton (test/functional/services/ml/data_visualizer_index_based.ts:37:7)
    at Context.<anonymous> (test/functional_basic/apps/ml/permissions/read_ml_access.ts:121:11)
    at Object.apply (/dev/shm/workspace/parallel/9/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
    at onFailure (/dev/shm/workspace/parallel/9/kibana/test/common/services/retry/retry_for_success.ts:17:9)
    at retryForSuccess (/dev/shm/workspace/parallel/9/kibana/test/common/services/retry/retry_for_success.ts:57:13)
    at RetryService.tryForTime (/dev/shm/workspace/parallel/9/kibana/test/common/services/retry/retry.ts:22:12)
    at Object.assertTotalDocumentCount (test/functional/services/ml/data_visualizer_index_based.ts:26:7)
    at Object.clickUseFullDataButton (test/functional/services/ml/data_visualizer_index_based.ts:37:7)
    at Context.<anonymous> (test/functional_basic/apps/ml/permissions/read_ml_access.ts:121:11)
    at Object.apply (/dev/shm/workspace/parallel/9/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.5MB 6.5MB +5.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@parkiino parkiino merged commit a4828ba into elastic:master Sep 8, 2021
@parkiino parkiino deleted the bug/host-isolation-disabled branch September 8, 2021 00:43
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 8, 2021
@parkiino @kibanamachine
[Security Solution][Endpoint][Host Isolation] Hide isolate host optio…
e1db6fa 
…n in alert details rather than disabling (elastic#111064)
@kibanamachine kibanamachine mentioned this pull request Sep 8, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 8, 2021
@parkiino @kibanamachine
[Security Solution][Endpoint][Host Isolation] Hide isolate host optio…
5777d56 
…n in alert details rather than disabling (elastic#111064)
@kibanamachine kibanamachine mentioned this pull request Sep 8, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.15
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 8, 2021
@kibanamachine @parkiino
[Security Solution][Endpoint][Host Isolation] Hide isolate host optio…
a41e450 
…n in alert details rather than disabling (#111064) (#111476)

Co-authored-by: Candace Park <56409205+parkiino@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 8, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reporting/add…
47aa554 
…-link-to-kibana-app

* 'master' of github.com:elastic/kibana: (61 commits)
  [Logs UI] Fix alert previews for thresholds of `0` (elastic#111150)
  [Archive Migration][Partial] discover apps-discover (elastic#110437)
  [APM] Set start date of APM ML job to -4 weeks (elastic#111375)
  [ML] APM Latency Correlations: Code consolidation. (elastic#110790)
  [Discover] Fix indices permission for multiline test (elastic#111284)
  [Detection Rules] Add 7.15 rules (elastic#111464)
  [Security Solution][Endpoint][Host Isolation] Hide isolate host option in alert details rather than disabling (elastic#111064)
  React version of angular license view (elastic#111317)
  [APM] Fix link in readme (elastic#111362)
  [Security Solution] add agent field to generator (elastic#111428)
  [Dashboard] Retain Tags on Quicksave (elastic#111015)
  Reorder App Search ingestion methods (elastic#111361)
  Port performance docs to new docs system. (elastic#111063)
  [Security Solution][RAC] Fixes updatedAt loading bug (elastic#111010)
  [sample data] update web log geo.src field to match country code of geo.coordinates (elastic#110885)
  [Security solution] [Endpoint] Fix bad artifact migration (elastic#111294)
  Fix copy typo. (elastic#111203)
  [build] Remove empty optimize directory (elastic#111393)
  [Maps] fix term join not updating when editing right field (elastic#111030)
  [Fleet] Set default settings in component template instead of the index template (elastic#111197)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap
#	x-pack/plugins/reporting/public/management/report_listing.test.tsx
kibanamachine added a commit that referenced this pull request Sep 8, 2021
@kibanamachine @parkiino
[Security Solution][Endpoint][Host Isolation] Hide isolate host optio…
b1c465d 
…n in alert details rather than disabling (#111064) (#111475)

Co-authored-by: Candace Park <56409205+parkiino@users.noreply.github.com>
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Sep 8, 2021
@parkiino @chrisronline
[Security Solution][Endpoint][Host Isolation] Hide isolate host optio…
514463a 
…n in alert details rather than disabling (elastic#111064)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinlog kevinlog kevinlog approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Endpoint Elastic Endpoint feature release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@parkiino @elasticmachine @ashokaditya @kibanamachine @kevinlog