Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React version of angular license view #111317

Merged
merged 10 commits into from
Sep 8, 2021
Merged

React version of angular license view #111317

merged 10 commits into from
Sep 8, 2021

Conversation

matschaffer
Copy link
Contributor

@matschaffer matschaffer commented Sep 7, 2021 •
edited
Loading

Summary

Reactified version of the angular license view

Screen Shot 2021-09-08 at 0 22 31

Note that the time selection bar is a bit different.

The angular version has two oddities:

  • Shows "10s", even though the XHR call is for a 15 minute range
  • Includes a refresh button and allows refresh interval changes, but neither cause any requests to fire or data to update

I've opted not replicate those since they seem like bugs and it's simpler to just disable the time bar.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@matschaffer matschaffer added v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Feature:Stack Monitoring auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 Epic: Stack Monitoring de-angularization labels Sep 7, 2021
@matschaffer matschaffer self-assigned this Sep 7, 2021
@matschaffer matschaffer mentioned this pull request Sep 7, 2021
Closed
19 tasks
@matschaffer
Copy link
Contributor Author

@elasticmachine update master

@matschaffer
Copy link
Contributor Author

@elasticmachine merge upstream

@matschaffer matschaffer marked this pull request as ready for review September 7, 2021 15:07
@matschaffer matschaffer requested a review from a team as a code owner September 7, 2021 15:07
@matschaffer matschaffer requested review from a team September 7, 2021 15:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@matschaffer matschaffer added the release_note:skip Skip the PR/issue when compiling release notes label Sep 7, 2021
estermv
estermv approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@estermv estermv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
monitoring 583 584 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 778.3KB 781.5KB +3.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @matschaffer

@matschaffer matschaffer merged commit 7fc4c29 into elastic:master Sep 8, 2021
@matschaffer matschaffer deleted the sm-react-license-page branch September 8, 2021 00:19
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 8, 2021
@matschaffer @kibanamachine
React version of angular license view (elastic#111317)
ee516f9 
* React version of angular license view

* Fix time handling and linking to license upload

* Use getPageData pattern instead of useClusters

* Add note about locked time picker

* Add disable support to monitoring toolbar

* Disable toolbar on license page only

* Remove old todo

* Clean up render setup method ordering

* Fix CI checks

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Sep 8, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 8, 2021
@kibanamachine @matschaffer
React version of angular license view (#111317) (#111474)
43f3a61 
* React version of angular license view

* Fix time handling and linking to license upload

* Use getPageData pattern instead of useClusters

* Add note about locked time picker

* Add disable support to monitoring toolbar

* Disable toolbar on license page only

* Remove old todo

* Clean up render setup method ordering

* Fix CI checks

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Mat Schaffer <mat@elastic.co>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 8, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reporting/add…
47aa554 
…-link-to-kibana-app

* 'master' of github.com:elastic/kibana: (61 commits)
  [Logs UI] Fix alert previews for thresholds of `0` (elastic#111150)
  [Archive Migration][Partial] discover apps-discover (elastic#110437)
  [APM] Set start date of APM ML job to -4 weeks (elastic#111375)
  [ML] APM Latency Correlations: Code consolidation. (elastic#110790)
  [Discover] Fix indices permission for multiline test (elastic#111284)
  [Detection Rules] Add 7.15 rules (elastic#111464)
  [Security Solution][Endpoint][Host Isolation] Hide isolate host option in alert details rather than disabling (elastic#111064)
  React version of angular license view (elastic#111317)
  [APM] Fix link in readme (elastic#111362)
  [Security Solution] add agent field to generator (elastic#111428)
  [Dashboard] Retain Tags on Quicksave (elastic#111015)
  Reorder App Search ingestion methods (elastic#111361)
  Port performance docs to new docs system. (elastic#111063)
  [Security Solution][RAC] Fixes updatedAt loading bug (elastic#111010)
  [sample data] update web log geo.src field to match country code of geo.coordinates (elastic#110885)
  [Security solution] [Endpoint] Fix bad artifact migration (elastic#111294)
  Fix copy typo. (elastic#111203)
  [build] Remove empty optimize directory (elastic#111393)
  [Maps] fix term join not updating when editing right field (elastic#111030)
  [Fleet] Set default settings in component template instead of the index template (elastic#111197)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap
#	x-pack/plugins/reporting/public/management/report_listing.test.tsx
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Sep 8, 2021
@matschaffer @kibanamachine @chrisronline
React version of angular license view (elastic#111317)
f57f6b2 
* React version of angular license view

* Fix time handling and linking to license upload

* Use getPageData pattern instead of useClusters

* Add note about locked time picker

* Add disable support to monitoring toolbar

* Disable toolbar on license page only

* Remove old todo

* Clean up render setup method ordering

* Fix CI checks

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estermv estermv estermv approved these changes

Assignees

@matschaffer matschaffer

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Epic: Stack Monitoring de-angularization Feature:Stack Monitoring release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matschaffer @elasticmachine @kibanamachine @estermv