-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIEM][CASES] Configure cases: Final #59358
Conversation
e3b8896
to
f6ec4c1
Compare
Pinging @elastic/siem (Team:SIEM) |
fa8e929
to
cc8edcc
Compare
cc8edcc
to
788fe87
Compare
x-pack/legacy/plugins/siem/public/containers/case/configure/use_configure.tsx
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/pages/case/components/configure_cases/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/pages/case/components/configure_cases/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/pages/case/components/configure_cases/field_mapping_row.tsx
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/containers/case/configure/use_connectors.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/lib/connectors/servicenow.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/lib/connectors/servicenow.tsx
Outdated
Show resolved
Hide resolved
...k/legacy/plugins/siem/public/pages/case/components/configure_cases/closure_options_radio.tsx
Show resolved
Hide resolved
ee35958
to
bda81be
Compare
bda81be
to
f2bff31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the hard work! LGTM once we have a green build 🚀 🎸
#60137 has been merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from an operations perspective
* Create action schema * Create createRequestHandler util function * Add actions plugins * Create action * Validate actionTypeId * [SIEM][CASE] Add find actions schema * Create find actions route * Create HttpRequestError * Support http status codes * Create check action health types * Create check action health route * Show field mapping * Leave spaces between sections * Export CasesConfiguration from servicenow action type * Create IdSchema * Create UpdateCaseConfiguration interface * Create update action route * Add constants * Create fetchConnectors api function * Create useConnector * Create reducer * Dynamic connectors * Fix conflicts * Create servicenow connector * Register servicenow connector * Add ServiceNow logo * Create connnectors mapping * Create validators in utils * Use validators in connectors * Validate URL * Use connectors from config * Enable triggers_aciton_ui plugin * Show flyout * Add closures options * cleanup configure api * simplify UI + add configure API * Add mapping to flyout * Fix error * add all plumbing and main functionality to get configure working * Fix naming * Fix tests * Show error when failed * Remove version from query * Disable when loading connectors * fix config update * Fix flyout * fix two bugs * Change defaults * Disable closure options when no connector is selected * Use default mappings from lib * Set mapping if empty * Reset connector to none if deleted from settings * Change lib structure * fix type * review with christos * Do not patch connector with id none * Fix bug * Show icon in dropdown * Rename variable * Show callout when connectors does not exists * Adapt to new error handling * Fix rebase wrong resolve * Improve errors * Remove async * Fix spelling * Refactor hooks * Fix naming * Better translation * Fix bug with different action type attributes * Fix linting errors * Remove unnecessary comment * Fix translation * Normalized mapping before updating connector * Fix type * Memoized capitalized * Dynamic data-subj-test variable * Fix routes Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
* Create action schema * Create createRequestHandler util function * Add actions plugins * Create action * Validate actionTypeId * [SIEM][CASE] Add find actions schema * Create find actions route * Create HttpRequestError * Support http status codes * Create check action health types * Create check action health route * Show field mapping * Leave spaces between sections * Export CasesConfiguration from servicenow action type * Create IdSchema * Create UpdateCaseConfiguration interface * Create update action route * Add constants * Create fetchConnectors api function * Create useConnector * Create reducer * Dynamic connectors * Fix conflicts * Create servicenow connector * Register servicenow connector * Add ServiceNow logo * Create connnectors mapping * Create validators in utils * Use validators in connectors * Validate URL * Use connectors from config * Enable triggers_aciton_ui plugin * Show flyout * Add closures options * cleanup configure api * simplify UI + add configure API * Add mapping to flyout * Fix error * add all plumbing and main functionality to get configure working * Fix naming * Fix tests * Show error when failed * Remove version from query * Disable when loading connectors * fix config update * Fix flyout * fix two bugs * Change defaults * Disable closure options when no connector is selected * Use default mappings from lib * Set mapping if empty * Reset connector to none if deleted from settings * Change lib structure * fix type * review with christos * Do not patch connector with id none * Fix bug * Show icon in dropdown * Rename variable * Show callout when connectors does not exists * Adapt to new error handling * Fix rebase wrong resolve * Improve errors * Remove async * Fix spelling * Refactor hooks * Fix naming * Better translation * Fix bug with different action type attributes * Fix linting errors * Remove unnecessary comment * Fix translation * Normalized mapping before updating connector * Fix type * Memoized capitalized * Dynamic data-subj-test variable * Fix routes Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com> Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
…o alerting/view-in-app * 'alerting/view-in-app' of github.com:gmmorris/kibana: (33 commits) [SIEM] Adds 'Closes and opens signals' Cypress test (elastic#59950) [NP] Graph migration (elastic#59409) [ML] Clone analytics job (elastic#59791) Move VALUE_CLICK_TRIGGER and APPLY_FILTER_TRIGGER to ui_action… (elastic#60202) Handle improperly defined Watcher Logging Action text parameter. (elastic#60169) Move select range trigger to uiActions (elastic#60168) [SIEM][CASES] Configure cases: Final (elastic#59358) Closes elastic#59784. Sets xpack.apm.serviceMapEnabled default value true. (elastic#60153) [siem/cypress] update junit filename to be picked up by runbld (elastic#60156) OSS logic added to test environment (elastic#60134) Move canvas setup into app mount (elastic#59926) enable triggers_actions_ui plugin by default (elastic#60137) Expose Elasticsearch from start and deprecate from setup (elastic#59886) [SIEM] [Case] Insert timeline bugfix and limit 25 cases (elastic#60136) [ML] Client side cut over (elastic#60100) Disable query bar on service map routes (elastic#60118) Move subscribe_with_scope to kibana_legacy (elastic#59781) [Ingest] Agent Config create with sys monitoring (elastic#60111) [Watcher UI] Not possible to edit a watch that was created with the API if the ID contains a dot (elastic#59383) Actually fetch functionbeat fields needed for telemetry (elastic#60054) ...
* master: (40 commits) skips 'config_open.ts' files from linter check (elastic#60248) [Searchprofiler] Spacing between rendered shards (elastic#60238) Add UiSettings validation & Kibana default route redirection (elastic#59694) [SIEM][CASE] Change configuration button (elastic#60229) [Step 1][App Arch] Saved object migrations from kibana plugin to new platform (elastic#59044) adds new test (elastic#60064) [Uptime] Index Status API to Rest (elastic#59657) [SIEM] Adds 'Closes and opens signals' Cypress test (elastic#59950) [NP] Graph migration (elastic#59409) [ML] Clone analytics job (elastic#59791) Move VALUE_CLICK_TRIGGER and APPLY_FILTER_TRIGGER to ui_action… (elastic#60202) Handle improperly defined Watcher Logging Action text parameter. (elastic#60169) Move select range trigger to uiActions (elastic#60168) [SIEM][CASES] Configure cases: Final (elastic#59358) Closes elastic#59784. Sets xpack.apm.serviceMapEnabled default value true. (elastic#60153) [siem/cypress] update junit filename to be picked up by runbld (elastic#60156) OSS logic added to test environment (elastic#60134) Move canvas setup into app mount (elastic#59926) enable triggers_actions_ui plugin by default (elastic#60137) Expose Elasticsearch from start and deprecate from setup (elastic#59886) ...
💔 Build FailedTest FailuresKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/discover/_errors·js.discover app errors invalid scripted field error is renderedStandard Out
Stack Trace
Kibana Pipeline / kibana-intake-agent / Jest Integration Tests.packages/kbn-plugin-generator/integration_tests.running the plugin-generator via 'node scripts/generate_plugin.js plugin-name' with default config then running with es instance 'yarn start' should result in the spec plugin being initialized on kibana's stdoutStandard Out
Stack Trace
Kibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/discover/_errors·js.discover app errors invalid scripted field error is renderedStandard Out
Stack Trace
History
To update your PR or re-run it, just comment with: |
Summary
The PR implements all the needed functionality of the configuration page.
Depends on: #58894
Will be refactored when #59265 is merged with master.(Done)Fixes: #59316 , #57864
Ref: #57866, #50103
Routes:
Get connectors
Get all connectors supported by the Case Management System.
Endpoint:
/api/cases/configure/connectors/_find
Method:
GET
Example parameters:
Example response:
Patch connector
Update a connector supported by the Case Management System.
Endpoint:
/api/cases/configure/connectors/{connector_id}
Method:
PATCH
Example payload:
Example response:
Get configuration
Get configuration of Case Management System.
Endpoint:
/api/cases/configure
Method:
GET
Example parameters:
Example response:
Post configuration
Create a configuration for the Case Management System.
Endpoint:
/api/cases/configure
Method:
POST
Example payload:
Example response:
Patch configuration
Update a configuration of the Case Management System.
Endpoint:
/api/cases/configure
Method:
PATCH
Example payload:
Example response:
Checklist
Delete any items that are not applicable to this PR.
For maintainers