[Security Solution]Fix in-app links and popup window text #71403

benskelker · 2020-07-13T08:18:38Z

Summary

Updates the Security Solution in-app links to the documentation.
Updates the Kibana help popup:

From:

To:

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support

benskelker · 2020-07-13T08:24:05Z

@spong @randomuserid - there are issues with the links from the ML prebuilt rules to the documentation because the current branch of the new Security docs doesn't exist yet. We can just wait until it does, or link to the ML docs which have the same descriptions: https://www.elastic.co/guide/en/machine-learning/current/ootb-ml-jobs-siem.html

@marrasherrier - The link to give feedback in the Kibana help popup window is cut. Should we change the text, to something like Security Solution feedback?

benskelker · 2020-07-13T08:25:53Z

@randomuserid - Do the prebuild rule descriptions need to be updated in your rules repo, so the text isn't replaced if one of the rules is updated?

rw-access

The prebuilt rules shouldn't be modified here and are derived from
elastic/detection-rules

Also, we have a pending PR for import of the latest rules for 7.9. If we update the rules in elastic/detection-rules, then I can pull those changes into #71332 before we merge it

This reverts commit aaa7e2a, as it will be done via the rules repo.

This reverts commit to update links from prebuilt jobs, will be done via the rules repo.

spong · 2020-07-13T17:19:08Z

@spong @randomuserid - there are issues with the links from the ML prebuilt rules to the documentation because the current branch of the new Security docs doesn't exist yet. We can just wait until it does, or link to the ML docs which have the same descriptions: https://www.elastic.co/guide/en/machine-learning/current/ootb-ml-jobs-siem.html

I'm 👍 waiting till the new Security docs get created (unless there's additional benefit to point to the ML docs directly).

thanks for the separate PR!

rw-access · 2020-07-13T19:02:37Z

@benskelker this commit contains your updates in the other PR
fc2294b

benskelker · 2020-07-14T14:37:26Z

@spong - I need your help here. I chatted with @marrasherrier and we decided it was ok to change the Give feedback on text in the help window because it is cut when we use Security Solution. But this is code used by other Kibana apps (https://github.com/elastic/kibana/blob/master/src/core/public/chrome/ui/header/header_help_menu.tsx). Any ideas?

spong · 2020-07-14T19:38:48Z

@spong - I need your help here. I chatted with @marrasherrier and we decided it was ok to change the Give feedback on text in the help window because it is cut when we use Security Solution. But this is code used by other Kibana apps (https://github.com/elastic/kibana/blob/master/src/core/public/chrome/ui/header/header_help_menu.tsx). Any ideas?

What's the text we want to use? Thinking through how we could provide the override text to that area of the codebase -- we may want to ask the Kibana core team for their thoughts here, as they might just prefer to increase the width of that popover to accommodate the larger app name since it's only around ~225px right now.

cnasikas · 2020-07-15T08:56:54Z

@elasticmachine merge upstream

benskelker · 2020-07-15T14:36:03Z

@spong @marrasherrier
Updated the text, now looks like this:

kibanamachine · 2020-07-15T16:21:22Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: e225ba1

Build metrics

async chunks size

id	value	diff	baseline
securitySolution	9.1MB	+35.0B	9.1MB

miscellaneous assets size

id	value	diff	baseline
core	464.0KB	+88.0B	463.9KB
upgradeAssistant	22.6KB	+24.0B	22.6KB
total	-	+112.0B	-

page load bundle size

id	value	diff	baseline
core	1.3MB	-4.0B	1.3MB

Saved Objects .kibana field count

id	value	diff	baseline
_data_stream_timestamp	1	+1	-

History

💚 Build #61851 succeeded e700b2fddbdb71244e0cbb7b1728de0b64eee2c7
💛 Build #60949 was flaky 6b76da6
💚 Build #60740 succeeded aaa7e2a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

spong

LGTM! Thanks @benskelker! 🙂

) * updates in-app links * updates links from prebuilt ML jobs * updates kibana help window text and link * removes problematic terminolgy from prebuilt job descriptions * Revert "removes problematic terminolgy from prebuilt job descriptions" This reverts commit aaa7e2a, as it will be done via the rules repo. * Revert "updates links from prebuilt ML jobs" This reverts commit to update links from prebuilt jobs, will be done via the rules repo. * recommits the link correction after revert * changes help window app name to Security

* master: (37 commits) [Lens] Handle failing existence check (elastic#70718) [Security Solution]Fix in-app links and popup window text (elastic#71403) [esArchiver] automatically retry if alias creation fails (elastic#71910) Move data stream index pattern creation test to xpack (elastic#71511) [Maps] Improve language for mvt card (elastic#71947) [Security][Detections] Unskip failing modal tests (elastic#71969) skip flaky suite (elastic#71987) skip flaky suite (elastic#71979) [Security Solution] [Detections] Revert "[Security Solution] [Detections] Fixes bug for determining when we hit max signals after filtering with lists (elastic#71768)" (elastic#71956) rename ilm policy to remove -default (elastic#71952) Adjust ordering of Management category apps to make Ingest Manager higher (elastic#71948) skip flaky suite (elastic#71971) skip flaky suite (elastic#71951) [kbn/optimizer] ignore compressed files when reporting stats (elastic#71940) skip flaky suite (elastic#71867) [ML] Fix new job with must_not saved search (elastic#71831) [Resolver] Fix bug where process detail panel doesn't show up (elastic#71754) Cleanup (elastic#71849) [Resolver] aria-level and aria-flowto support enhancements (elastic#71887) skip flaky suite (elastic#71304) ...

…72005) * updates in-app links * updates links from prebuilt ML jobs * updates kibana help window text and link * removes problematic terminolgy from prebuilt job descriptions * Revert "removes problematic terminolgy from prebuilt job descriptions" This reverts commit aaa7e2a, as it will be done via the rules repo. * Revert "updates links from prebuilt ML jobs" This reverts commit to update links from prebuilt jobs, will be done via the rules repo. * recommits the link correction after revert * changes help window app name to Security

…72006) * updates in-app links * updates links from prebuilt ML jobs * updates kibana help window text and link * removes problematic terminolgy from prebuilt job descriptions * Revert "removes problematic terminolgy from prebuilt job descriptions" This reverts commit aaa7e2a, as it will be done via the rules repo. * Revert "updates links from prebuilt ML jobs" This reverts commit to update links from prebuilt jobs, will be done via the rules repo. * recommits the link correction after revert * changes help window app name to Security

…feature-privileges * alerting/consumer-based-rbac: (491 commits) [Lens] Handle failing existence check (elastic#70718) [Security Solution]Fix in-app links and popup window text (elastic#71403) [esArchiver] automatically retry if alias creation fails (elastic#71910) Move data stream index pattern creation test to xpack (elastic#71511) [Maps] Improve language for mvt card (elastic#71947) [Security][Detections] Unskip failing modal tests (elastic#71969) skip flaky suite (elastic#71987) skip flaky suite (elastic#71979) [Security Solution] [Detections] Revert "[Security Solution] [Detections] Fixes bug for determining when we hit max signals after filtering with lists (elastic#71768)" (elastic#71956) rename ilm policy to remove -default (elastic#71952) Adjust ordering of Management category apps to make Ingest Manager higher (elastic#71948) skip flaky suite (elastic#71971) skip flaky suite (elastic#71951) [kbn/optimizer] ignore compressed files when reporting stats (elastic#71940) skip flaky suite (elastic#71867) [ML] Fix new job with must_not saved search (elastic#71831) [Resolver] Fix bug where process detail panel doesn't show up (elastic#71754) Cleanup (elastic#71849) [Resolver] aria-level and aria-flowto support enhancements (elastic#71887) skip flaky suite (elastic#71304) ...

elasticmachine · 2020-07-16T17:09:27Z

Pinging @elastic/siem (Team:SIEM)

elasticmachine · 2021-09-23T14:31:22Z

Pinging @elastic/security-solution (Team: SecuritySolution)

Ben Skelker added 4 commits July 13, 2020 09:06

updates in-app links

0a8efb4

updates links from prebuilt ML jobs

4cb9f79

updates kibana help window text and link

e9d8b3f

removes problematic terminolgy from prebuilt job descriptions

aaa7e2a

benskelker added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 13, 2020

benskelker requested review from randomuserid, spong, MadameSheema and marrasherrier July 13, 2020 08:18

benskelker requested review from a team as code owners July 13, 2020 08:18

This was referenced Jul 13, 2020

[Security docs] 7.9 doc updates (Ben's stuff) elastic/security-docs#44

Closed

[SIEM][Endpoint]Update in-app links to documentation #68062

Closed

benskelker linked an issue Jul 13, 2020 that may be closed by this pull request

[SIEM][Endpoint]Update in-app links to documentation #68062

Closed

benskelker requested review from jmikell821 and narcher7 July 13, 2020 08:39

mshustov approved these changes Jul 13, 2020

View reviewed changes

rw-access previously requested changes Jul 13, 2020

View reviewed changes

Ben Skelker added 3 commits July 13, 2020 18:55

Revert "removes problematic terminolgy from prebuilt job descriptions"

eb86e96

This reverts commit aaa7e2a, as it will be done via the rules repo.

Revert "updates links from prebuilt ML jobs"

9234481

This reverts commit to update links from prebuilt jobs, will be done via the rules repo.

recommits the link correction after revert

6b76da6

rw-access approved these changes Jul 13, 2020

View reviewed changes

benskelker mentioned this pull request Jul 13, 2020

Fixes terminology and doc links elastic/detection-rules#54

Merged

benskelker changed the title ~~[Security Solution]Fix in-app links and problematic terminology~~ [Security Solution]Fix in-app links and popup window text Jul 14, 2020

marrasherrier approved these changes Jul 14, 2020

View reviewed changes

Ben Skelker added 2 commits July 15, 2020 17:14

changes help window app name to Security

be91bf3

Merge branch 'master' into in-app-links-and-terminology

e225ba1

benskelker force-pushed the in-app-links-and-terminology branch from e700b2f to e225ba1 Compare July 15, 2020 14:34

spong approved these changes Jul 15, 2020

View reviewed changes

mshustov approved these changes Jul 16, 2020

View reviewed changes

benskelker merged commit a0dc26f into elastic:master Jul 16, 2020

benskelker mentioned this pull request Jul 16, 2020

[7.x] [Security Solution]Fix in-app links and popup window text (#71403) #72005

Merged

benskelker mentioned this pull request Jul 16, 2020

[7.9] [Security Solution]Fix in-app links and popup window text (#71403) #72006

Merged

benskelker deleted the in-app-links-and-terminology branch July 16, 2020 06:52

LeeDr added the Team:SIEM label Jul 16, 2020

MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution]Fix in-app links and popup window text #71403

[Security Solution]Fix in-app links and popup window text #71403

benskelker commented Jul 13, 2020 •

edited

Loading

benskelker commented Jul 13, 2020 •

edited

Loading

benskelker commented Jul 13, 2020 •

edited

Loading

rw-access left a comment •

edited

Loading

spong commented Jul 13, 2020

rw-access commented Jul 13, 2020

benskelker commented Jul 14, 2020

spong commented Jul 14, 2020

cnasikas commented Jul 15, 2020

benskelker commented Jul 15, 2020

kibanamachine commented Jul 15, 2020

spong left a comment

elasticmachine commented Jul 16, 2020

elasticmachine commented Sep 23, 2021

[Security Solution]Fix in-app links and popup window text #71403

[Security Solution]Fix in-app links and popup window text #71403

Conversation

benskelker commented Jul 13, 2020 • edited Loading

Summary

Checklist

benskelker commented Jul 13, 2020 • edited Loading

benskelker commented Jul 13, 2020 • edited Loading

rw-access left a comment • edited Loading

Choose a reason for hiding this comment

spong commented Jul 13, 2020

rw-access commented Jul 13, 2020

benskelker commented Jul 14, 2020

spong commented Jul 14, 2020

cnasikas commented Jul 15, 2020

benskelker commented Jul 15, 2020

kibanamachine commented Jul 15, 2020

💚 Build Succeeded

Build metrics

async chunks size

miscellaneous assets size

page load bundle size

Saved Objects .kibana field count

History

spong left a comment

Choose a reason for hiding this comment

elasticmachine commented Jul 16, 2020

elasticmachine commented Sep 23, 2021

benskelker commented Jul 13, 2020 •

edited

Loading

benskelker commented Jul 13, 2020 •

edited

Loading

benskelker commented Jul 13, 2020 •

edited

Loading

rw-access left a comment •

edited

Loading