Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data.search.SearchSource] Move some SearchSource dependencies to the server. #74607

Merged
merged 6 commits into from
Aug 11, 2020
Merged

[data.search.SearchSource] Move some SearchSource dependencies to the server. #74607

merged 6 commits into from
Aug 11, 2020

Conversation

lukeelmers
Copy link
Member

Part of #65069

This performs some initial prep work on some utilities which SearchSource relies on, to make it easier to move SearchSource to the server:

  • Converts SearchError to an interface (as the class appears to be unused)
  • Remove getSearchErrorType from data plugin contract (appears to be unused)
  • Relocate invalidJSONProperty and fieldWildcardFilter in kibana_utils to live in common so they can be exposed on the server
  • Move migrateLegacyQuery to common so it can be exposed on the server

Dev Docs

getSearchErrorType and the SearchError class have been removed from the static exports of the data plugin's contract. If you rely on these, please copy the code directly into your plugin. Note that the SearchError interface is still exposed.

@lukeelmers lukeelmers added Feature:Search Querying infrastructure in Kibana release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. v8.0.0 Team:AppArch v7.10.0 labels Aug 6, 2020
@lukeelmers lukeelmers requested a review from a team August 6, 2020 23:05
@lukeelmers lukeelmers requested a review from a team as a code owner August 6, 2020 23:05
@lukeelmers lukeelmers self-assigned this Aug 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@ppisljar ppisljar mentioned this pull request Aug 6, 2020
Closed
28 tasks
@lukeelmers lukeelmers force-pushed the fix/ssource-prep-utils branch from 3df74a6 to 4ec9875 Compare August 7, 2020 17:13
@lukeelmers lukeelmers force-pushed the fix/ssource-prep-utils branch from 4ec9875 to 20838b3 Compare August 7, 2020 19:19
@lukeelmers
Copy link
Member Author

@elasticmachine merge upstream

ppisljar
ppisljar approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@lukeelmers
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
data 536 -1 537
kibanaLegacy 134 +1 133
kibanaUtils 190 -1 191
total -1

async chunks size

id value diff baseline
kibanaLegacy 147.1KB +2.0B 147.1KB

page load bundle size

id value diff baseline
data 1.4MB -4.7KB 1.4MB
kibanaLegacy 247.7KB +471.0B 247.2KB
kibanaUtils 470.0KB +1.0KB 469.0KB
total -3.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

flash1293
flash1293 approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kibana app changes LGTM, code review only

@lukeelmers lukeelmers merged commit d84777f into elastic:master Aug 11, 2020
@lukeelmers lukeelmers deleted the fix/ssource-prep-utils branch August 11, 2020 15:53
lukeelmers added a commit to lukeelmers/kibana that referenced this pull request Aug 11, 2020
@lukeelmers
[data.search.SearchSource] Move some SearchSource dependencies to the…
d62ce1c 
… server. (elastic#74607)
@lukeelmers lukeelmers mentioned this pull request Aug 11, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 11, 2020
@gmmorris
Merge branch 'master' into actions/webhook-remove-header
1dbf2f2 
* master: (106 commits)
  [Functional Tests] Adds a wait time between setting the index pattern and the time field on TSVB (elastic#74736)
  [Lens] Add styling options for x and y axes on the settings popover (elastic#71829)
  [Maps] add initial location option that fits to data bounds (elastic#74583)
  theme function (elastic#73451)
  [data.ui.query] Write filters to query log from default editor. (elastic#74474)
  [data.search.SearchSource] Move some SearchSource dependencies to the server. (elastic#74607)
  [Canvas][tech-debt] Convert renderers (elastic#74134)
  [security solutions][lists] Adds end to end tests (elastic#74473)
  pluralized for occurrences vs occurrence (elastic#74564)
  Update links that pointed to CONTRIBUTING.md (elastic#74757)
  [Ingest pipelines] Implement tabs in processor flyout (elastic#74469)
  [Event log] Use Alerts client & Actions client when fetching these types of SOs (elastic#73257)
  Bump chalk to 4.1.0 (elastic#73397)
  Index pattern field list - transition away from extending array - introduce and use getAll() (elastic#74718)
  [SECURITY] Bugs css/inspect (elastic#74711)
  [telemetry] update README to downplay ui_metrics (elastic#74635)
  Fixed grammar (elastic#74725)
  [Telemetry][API Integration] size_in_bytes to be a number (elastic#74664)
  [ILM] Convert node details flyout to TS (elastic#73707)
  [Ingest Node Pipelines] Sentence-case processor names (elastic#74645)
  ...
lukeelmers added a commit that referenced this pull request Aug 11, 2020
@lukeelmers
[data.search.SearchSource] Move some SearchSource dependencies to the…
6c89fd1 
… server. (#74607) (#74772)
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 12, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ingest-pipeli…
bbbe9d2 
…nes/processor-forms-a-d

* 'master' of github.com:elastic/kibana: (25 commits)
  [ML] Removing full lodash library imports (elastic#74742)
  [Search] Server strategy example (elastic#71679)
  [Reporting] Fix and test for Listing of Reports (elastic#74453)
  [maps] fix drawing shapes (elastic#74689)
  [Resolver] Improve simulator. Add more click-through tests and panel tests. (elastic#74601)
  Deprecate schema-less specs in Vega (elastic#73805)
  [Security Solution] Rename Administration > Hosts subtab to Endpoints (elastic#74287)
  Timelion deprecation doc (elastic#74508)
  [Functional Tests] Adds a wait time between setting the index pattern and the time field on TSVB (elastic#74736)
  [Lens] Add styling options for x and y axes on the settings popover (elastic#71829)
  [Maps] add initial location option that fits to data bounds (elastic#74583)
  theme function (elastic#73451)
  [data.ui.query] Write filters to query log from default editor. (elastic#74474)
  [data.search.SearchSource] Move some SearchSource dependencies to the server. (elastic#74607)
  [Canvas][tech-debt] Convert renderers (elastic#74134)
  [security solutions][lists] Adds end to end tests (elastic#74473)
  pluralized for occurrences vs occurrence (elastic#74564)
  Update links that pointed to CONTRIBUTING.md (elastic#74757)
  [Ingest pipelines] Implement tabs in processor flyout (elastic#74469)
  [Event log] Use Alerts client & Actions client when fetching these types of SOs (elastic#73257)
  ...

# Conflicts:
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/field_components/text_editor.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/manage_processor_form.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/append.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/bytes.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/circle.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/common_fields/field_name_field.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/common_fields/ignore_missing_field.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/convert.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/csv.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/date.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/date_index_name.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/dissect.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/dot_expander.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/drop.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/index.ts
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/shared.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

@flash1293 flash1293 flash1293 approved these changes

Assignees

@lukeelmers lukeelmers

Labels
Feature:Search Querying infrastructure in Kibana release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lukeelmers @elasticmachine @kibanamachine @flash1293 @ppisljar