[Security Solution] Rename Administration > Hosts subtab to Endpoints #74287

pzl · 2020-08-04T17:51:55Z

Summary

Changing the language, since a top-level Hosts tab exists under Security. The sub-page under Administration will be called Endpoints

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios

kevinlog · 2020-08-04T18:55:59Z

FYI @parkiino @paul-tavares

...ck/plugins/security_solution/public/management/pages/endpoint_hosts/store/middleware.test.ts

x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/index.test.tsx

kevinlog · 2020-08-05T14:53:02Z

I failed to mention this in the original ticket, but I think we should also rename some files here.

ex:
host_pagination.test.ts -> endpoint_pagination.test.ts
host_details.tsx -> endpoint_details.tsx

FYI @paul-tavares @parkiino are there other name changes top of mind? We can document what we should change in the original ticket

paul-tavares

Left some comments.

Also

Remember to tag this for 8.0 as well.
There may be other areas where we need adjustment - example: the breadcrumbs. I think those are in a SIEM component somewhere (Candace made that change two weeks ago, so you will be able to find the Commit)

x-pack/plugins/security_solution/public/management/common/constants.ts

.../security_solution/public/management/pages/endpoint_hosts/store/mock_endpoint_result_list.ts

...s/security_solution/public/management/pages/endpoint_hosts/view/details/endpoint_details.tsx

paul-tavares · 2020-08-05T17:51:38Z

x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/index.tsx

                  />
                </h1>
              </EuiTitle>
            </EuiFlexItem>
            <EuiFlexItem grow={false}>
              <EuiBetaBadge
-                label={i18n.translate('xpack.securitySolution.endpoint.hostList.beta', {
+                label={i18n.translate('xpack.securitySolution.endpoint.endpointList.beta', {


Unrelated to you change: maybe remove .endpoint. from this id. Maybe it was left over. I think all ids in this module should have the same prefix.

Happy to remove it here. I don't know what's considered a module (file? folder? parent folder? subfolders?) but I will say these i18n keys vary a bit. I searched for "xpack.securitySolution.endpoint" and came up with.. lots.

There's also a lot of inconsistencies overall. See:

i18n.translate('xpack.securitySolution.endpoint.hostDetails.policyResponse.load_config', {

and

title: i18n.translate('xpack.securitySolution.endpoint.host.details.policyStatus', {

note hostDetails and host.details. Perhaps we should make a backlog ticket for auditing these and use consistent namespaces?

I'm ok with opening another issue to track. This is left over from when we moved from the endpoint plugin to SIEM (not Security_Solution) 🙂
I think we're free to come up with our own conventions if we see it necessary. At a minimum, xpack.securitySolution should be on all entries - I think this makes it clear (when these are all extracted from Kibana) which plugin owns what. After that value, we can come up with anything we want. My main point in my prior comment was that within a single module (file), all the keys should at least have the same prefix.

paul-tavares

👍 🚀

pzl · 2020-08-10T16:41:44Z

rebased on master to deal with conflicts

elasticmachine · 2020-08-10T18:18:30Z

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

elasticmachine · 2020-08-10T18:18:31Z

Pinging @elastic/endpoint-management (Team:Endpoint Management)

paul-tavares

🚢

kibanamachine · 2020-08-11T15:41:34Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: c8112f1

Build metrics

async chunks size

id	value	diff	baseline
securitySolution	7.3MB	+672.0B	7.3MB

page load bundle size

id	value	diff	baseline
securitySolution	805.8KB	+72.0B	805.8KB

History

💔 Build #67313 failed d2a4457
💔 Build #67037 failed 5761d63040e82265e00487767bb847b0302a9c6e
💔 Build #67017 failed 14c0becd6009e2a3065287d7802d274f1a00100e
💔 Build #66712 failed 2eaf9dad05a0d26927d901662be98a1f628c4cd8
💔 Build #66447 failed bbcc47272d33770dddab7b730c61d79fe6f58a80

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…nes/processor-forms-a-d * 'master' of github.com:elastic/kibana: (25 commits) [ML] Removing full lodash library imports (elastic#74742) [Search] Server strategy example (elastic#71679) [Reporting] Fix and test for Listing of Reports (elastic#74453) [maps] fix drawing shapes (elastic#74689) [Resolver] Improve simulator. Add more click-through tests and panel tests. (elastic#74601) Deprecate schema-less specs in Vega (elastic#73805) [Security Solution] Rename Administration > Hosts subtab to Endpoints (elastic#74287) Timelion deprecation doc (elastic#74508) [Functional Tests] Adds a wait time between setting the index pattern and the time field on TSVB (elastic#74736) [Lens] Add styling options for x and y axes on the settings popover (elastic#71829) [Maps] add initial location option that fits to data bounds (elastic#74583) theme function (elastic#73451) [data.ui.query] Write filters to query log from default editor. (elastic#74474) [data.search.SearchSource] Move some SearchSource dependencies to the server. (elastic#74607) [Canvas][tech-debt] Convert renderers (elastic#74134) [security solutions][lists] Adds end to end tests (elastic#74473) pluralized for occurrences vs occurrence (elastic#74564) Update links that pointed to CONTRIBUTING.md (elastic#74757) [Ingest pipelines] Implement tabs in processor flyout (elastic#74469) [Event log] Use Alerts client & Actions client when fetching these types of SOs (elastic#73257) ... # Conflicts: # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/field_components/text_editor.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/manage_processor_form.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/append.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/bytes.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/circle.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/common_fields/field_name_field.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/common_fields/ignore_missing_field.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/convert.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/csv.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/date.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/date_index_name.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/dissect.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/dot_expander.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/drop.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/index.ts # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/shared.ts

* master: [Vega] add functional tests for Vega visualization (elastic#74097) [ML] Removing full lodash library imports (elastic#74742) [Search] Server strategy example (elastic#71679) [Reporting] Fix and test for Listing of Reports (elastic#74453) [maps] fix drawing shapes (elastic#74689) [Resolver] Improve simulator. Add more click-through tests and panel tests. (elastic#74601) Deprecate schema-less specs in Vega (elastic#73805) [Security Solution] Rename Administration > Hosts subtab to Endpoints (elastic#74287) Timelion deprecation doc (elastic#74508)

…elastic#74287)

…#74287) (#74853)

pzl added release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Management Feature:Endpoint Elastic Endpoint feature v7.10.0 labels Aug 4, 2020

kevinlog reviewed Aug 5, 2020

View reviewed changes

...ck/plugins/security_solution/public/management/pages/endpoint_hosts/store/middleware.test.ts Outdated Show resolved Hide resolved

kevinlog reviewed Aug 5, 2020

View reviewed changes

x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/index.test.tsx Outdated Show resolved Hide resolved

paul-tavares requested changes Aug 5, 2020

View reviewed changes

pzl added the v8.0.0 label Aug 5, 2020

paul-tavares approved these changes Aug 5, 2020

View reviewed changes

pzl added 7 commits August 10, 2020 12:33

basically human sed s/hosts/endpoints/gi

c87879a

this time, sed AND mv

94f6e22

even less hosts

6d85bfb

fix weird replace artifacts

e50a1b1

remove .endpoint from i18n namespace here

1f71a9b

fix types typo

bb3eefa

fix page title check, more renames

50970b4

pzl force-pushed the rename-hosts-endpoints branch from 21ac7b4 to d2a4457 Compare August 10, 2020 16:41

rename test-subj elements, this time I did actually use sed

1386b21

pzl added 3 commits August 10, 2020 12:41

host host host host -> endpoint endpoint endpoint endpoint

09cddc5

fix renames in tests

5480bd7

i18n fixes

d2a4457

pzl marked this pull request as ready for review August 10, 2020 18:18

pzl requested review from a team as code owners August 10, 2020 18:18

rename status column, a few local vars

92d309e

kevinlog approved these changes Aug 11, 2020

View reviewed changes

change table header to Agent Status

c8112f1

paul-tavares approved these changes Aug 11, 2020

View reviewed changes

pzl merged commit 80a5c4b into elastic:master Aug 11, 2020

pzl added a commit to pzl/kibana that referenced this pull request Aug 12, 2020

[Security Solution] Rename Administration > Hosts subtab to Endpoints (…

f30ea0f

…elastic#74287)

pzl mentioned this pull request Aug 12, 2020

[7.x] [Security Solution] Rename Administration > Hosts subtab to Endpoints (#74287) #74853

Merged

pzl added a commit that referenced this pull request Aug 12, 2020

[Security Solution] Rename Administration > Hosts subtab to Endpoints (…

abcb93e

…#74287) (#74853)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution] Rename Administration > Hosts subtab to Endpoints #74287

[Security Solution] Rename Administration > Hosts subtab to Endpoints #74287

pzl commented Aug 4, 2020 •

edited

Loading

kevinlog commented Aug 4, 2020

kevinlog commented Aug 5, 2020

paul-tavares left a comment

paul-tavares Aug 5, 2020

pzl Aug 6, 2020

paul-tavares Aug 6, 2020

paul-tavares left a comment

pzl commented Aug 10, 2020

elasticmachine commented Aug 10, 2020

elasticmachine commented Aug 10, 2020

paul-tavares left a comment

kibanamachine commented Aug 11, 2020

[Security Solution] Rename Administration > Hosts subtab to Endpoints #74287

[Security Solution] Rename Administration > Hosts subtab to Endpoints #74287

Conversation

pzl commented Aug 4, 2020 • edited Loading

Summary

Checklist

kevinlog commented Aug 4, 2020

kevinlog commented Aug 5, 2020

paul-tavares left a comment

Choose a reason for hiding this comment

paul-tavares Aug 5, 2020

Choose a reason for hiding this comment

pzl Aug 6, 2020

Choose a reason for hiding this comment

paul-tavares Aug 6, 2020

Choose a reason for hiding this comment

paul-tavares left a comment

Choose a reason for hiding this comment

pzl commented Aug 10, 2020

elasticmachine commented Aug 10, 2020

elasticmachine commented Aug 10, 2020

paul-tavares left a comment

Choose a reason for hiding this comment

kibanamachine commented Aug 11, 2020

💚 Build Succeeded

Build metrics

async chunks size

page load bundle size

History

pzl commented Aug 4, 2020 •

edited

Loading