Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update saved object management UI text #76826

Merged

Conversation

jportner
Copy link
Contributor

@jportner jportner commented Sep 4, 2020

Resolves #76649.

We have a direct dependency on node-forge `0.9.1`, and a also a
transitive dependency via:
@elastic/request-crypto@1.1.4 > node-jose@1.1.0 > node-forge@0.7.6

This commit updates both of these to `0.10.0`.
@jportner jportner added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 4, 2020
@jportner jportner requested a review from gchaps September 4, 2020 20:55
@jportner jportner requested review from a team as code owners September 4, 2020 20:55
@jportner jportner force-pushed the issue-76649-update-saved-object-ui-text branch from 608e1b1 to 84cc53a Compare September 4, 2020 20:57
Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed text changes with @jportner. LGTM

Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Joe!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
savedObjectsManagement 203.9KB +216.0B 203.6KB

page load bundle size

id value diff baseline
spaces 488.0KB -215.0B 488.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jportner jportner merged commit 60294cb into elastic:master Sep 9, 2020
@jportner jportner deleted the issue-76649-update-saved-object-ui-text branch September 9, 2020 12:56
jportner added a commit to jportner/kibana that referenced this pull request Sep 9, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 9, 2020
* master: (68 commits)
  a11y tests on spaces home page including feature control  (elastic#76515)
  [ML] Transforms list: persist pagination through refresh interval (elastic#76786)
  [ML] Replace all use of date_histogram interval with fixed_interval (elastic#76876)
  [Timelion] Update timelion deprecation links (elastic#77008)
  [Security Solution] Refactor Network Details to use Search Strategy (elastic#76928)
  Upgrade elastic charts to 21.1.2 (elastic#76939)
  [Alerting][Connectors] Refactor Jira: Generic Implementation (phase one) (elastic#73778)
  [Snapshot & Restore] fix pre existing policy with no existing repository (elastic#76861)
  Update saved object management UI text (elastic#76826)
  [Form lib] Add validations prop to UseArray and expose "moveItem" handler (elastic#76949)
  [Logs UI] Use fields api in log stream (elastic#76919)
  [UI Metrics] Support multi-colon keys (elastic#76913)
  [APM] Script for creating functional test archive (elastic#76926)
  [ENDPOINT] First version of the trusted apps list. (elastic#76304)
  Correct field for rum page url (elastic#76916)
  [Security Solution] Fix redirect properly old SIEM App routes (elastic#76868)
  Bump http-proxy from 1.17.0 to 1.18.1 (elastic#76924)
  [RUM Dashboard] Visitor breakdown usability (elastic#76834)
  [Search] Add a new advanced setting searchTimeout (elastic#75728)
  [DOCS] Adds timelion deprecation to new visualize docs structure (elastic#76959)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update saved object management UI text
5 participants