[Snapshot & Restore] fix pre existing policy with no existing repository #76861

jloleysens · 2020-09-07T10:38:13Z

Summary

Fix an issue where the snapshot and restore policy creation wizard does not allow you to select a different repo when the pre-existing repo for the policy was deleted - also inform the user of when this has happened.

There is an edge case where a user can be blocked if they only have one other policy to select from; the form will not allow the user to select another repo in this case.

Screenshot

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios

Release note

The snapshot and restore wizard will now notify a user when a policy configured with a non-existing repository is being updated and require that the user select a new repository.

elasticmachine · 2020-09-07T10:38:15Z

Pinging @elastic/es-ui (Team:Elasticsearch UI)

yuliacech

Hi @jloleysens,
I tested your changes locally and the fix works!
I was just wondering if it would be possible to make the step invalid when a pre-selected repo was deleted? Since we are setting the value of the select to an empty string, I think the Next button should be disabled. Currently, the form can still progress to "Snapshot settings" step with an empty select, which is not possible when the from first loads (for a new policy).
Also, personally I would prefer having this callout and "no repositories" section similar to each other, maybe make this callout to be of type "danger" or use `SectionError' without the button.
What do you think?

cjcenizal · 2020-09-08T03:45:46Z

.../plugins/snapshot_restore/public/application/components/policy_form/steps/step_logistics.tsx

+      <>
+        {!policyRepositoryExists && (
+          <>
+            <EuiCallOut


A screenshot would be 💣 !

cjcenizal · 2020-09-08T03:48:40Z

@jloleysens Great job spotting and fixing this! Is this fixing a bug from a prior release? If so, can we add the release_note:fix label and add a release note?

…und repo

jloleysens · 2020-09-08T08:57:20Z

@yuliacech @cjcenizal Thanks both for the review!

@yuliacech great catch regarding the form not blocking. After your comment about making the callout "danger" I also revised the copy a bit to also mention the currently configured repository and state that that does not exist. Would you mind taking another look?

jloleysens · 2020-09-08T08:57:31Z

@elasticmachine merge upstream

…ng-repository

…' of github.com:jloleysens/kibana into ilm/fix/pre-existing-policy-with-no-existing-repository * 'ilm/fix/pre-existing-policy-with-no-existing-repository' of github.com:jloleysens/kibana: fix empty string in selected indices (elastic#76855) [Security Solution] Refactor OverviewHost and OverviewNetwork to use Search Strategy (elastic#76409) Use Search API in Timelion (sync) (elastic#75115) [telemetry] expose getIsOptedIn function in plugin start contract (elastic#75143) [ILM] Clean up remaining js files and any typings (elastic#76803) [Logs UI] Shared `<LogStream />` component (elastic#76262) [Security Solution] Add unit test for all hosts (elastic#76752) [Security Solution] Add unit test for authentications search strategy (elastic#76665) Do not apply search source data for tsvb (elastic#75137) [Security Solution] Refactor NetworkDns to use Search Strategy (elastic#76250) [SECURITY SOLUTION] Adds 'cypress:open-as-ci' command (elastic#76125) [Logs UI] Update alert executor tests (elastic#75764) [Functional] Unskip vega tests and fix flakiness (elastic#76600) [Data] Query String Input accepts classname prop (elastic#76848) [ML] Swim lane pagination for viewing by job id (elastic#76847) [Security Solution] Refactor MatrixHistogram to use Search Strategy (elastic#76603) [APM] Use the outcome field to calculate the transaction error rate chart (elastic#75528) [APM] Use observer.hostname instead of observer.name (elastic#76074) Legacy logging: fix remoteAddress being duplicated in userAgent field (elastic#76751)

cjcenizal · 2020-09-08T17:47:42Z

@jloleysens I noticed a couple accessibility issues with this change:

Clicking on the "Repository" label should focus the select, but it doesn't. You can test this with the labels for the other fields, though it gets a little broken with the "Time" field.
There's no aria-label associated with the "Repository" field, meaning that a screen-reader won't be able to tell the user what the field corresponds to.

My suggestion is to move the callout outside of the field/label area and use the EuiFormRow component to group the label and field per the typical pattern. This will solve the accessibility issues I mentioned. The UI will change a bit, but personally I think this visual hierarchy looks a little more familiar. I'm used to seeing callouts above or below forms, but not inside of fields.

yuliacech

Hi @jloleysens,
thanks for fixing the form validation issue! Tested locally and the Next button is now disabled should the repo have been deleted in between. Apart from accessibility issues @cjcenizal mentioned, I'm good with merging this.

…ory (elastic#76861) * implement fix and add callout with copy * added test * make callout a danger callout and revise copy * block the form if we have a repo, but it does not exist * added test to assert that form wizard blocks on validation for not found repo * fix types and add a doc comment * move callout to above the form Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

kibanamachine · 2020-09-09T15:38:00Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 4bb3af6

Build metrics

async chunks size

id	value	diff	baseline
snapshotRestore	763.3KB	+1.8KB	761.6KB

History

💚 Build #73335 succeeded 4bb3af6
💚 Build #73181 succeeded 1a85d85
💚 Build #73027 succeeded 1a85d85
💔 Build #73021 failed e104911
💚 Build #72900 succeeded f0721cc

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…ory (#76861) (#77050) * implement fix and add callout with copy * added test * make callout a danger callout and revise copy * block the form if we have a repo, but it does not exist * added test to assert that form wizard blocks on validation for not found repo * fix types and add a doc comment * move callout to above the form Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…ory (#76861) (#77051) * implement fix and add callout with copy * added test * make callout a danger callout and revise copy * block the form if we have a repo, but it does not exist * added test to assert that form wizard blocks on validation for not found repo * fix types and add a doc comment * move callout to above the form Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: (68 commits) a11y tests on spaces home page including feature control (elastic#76515) [ML] Transforms list: persist pagination through refresh interval (elastic#76786) [ML] Replace all use of date_histogram interval with fixed_interval (elastic#76876) [Timelion] Update timelion deprecation links (elastic#77008) [Security Solution] Refactor Network Details to use Search Strategy (elastic#76928) Upgrade elastic charts to 21.1.2 (elastic#76939) [Alerting][Connectors] Refactor Jira: Generic Implementation (phase one) (elastic#73778) [Snapshot & Restore] fix pre existing policy with no existing repository (elastic#76861) Update saved object management UI text (elastic#76826) [Form lib] Add validations prop to UseArray and expose "moveItem" handler (elastic#76949) [Logs UI] Use fields api in log stream (elastic#76919) [UI Metrics] Support multi-colon keys (elastic#76913) [APM] Script for creating functional test archive (elastic#76926) [ENDPOINT] First version of the trusted apps list. (elastic#76304) Correct field for rum page url (elastic#76916) [Security Solution] Fix redirect properly old SIEM App routes (elastic#76868) Bump http-proxy from 1.17.0 to 1.18.1 (elastic#76924) [RUM Dashboard] Visitor breakdown usability (elastic#76834) [Search] Add a new advanced setting searchTimeout (elastic#75728) [DOCS] Adds timelion deprecation to new visualize docs structure (elastic#76959) ...

jloleysens added 2 commits September 7, 2020 12:23

implement fix and add callout with copy

6da36b5

added test

f0721cc

jloleysens requested a review from alisonelizabeth September 7, 2020 10:38

jloleysens requested a review from a team as a code owner September 7, 2020 10:38

jloleysens requested review from yuliacech and removed request for alisonelizabeth September 7, 2020 14:12

yuliacech reviewed Sep 7, 2020

View reviewed changes

cjcenizal reviewed Sep 8, 2020

View reviewed changes

jloleysens added 3 commits September 8, 2020 10:18

make callout a danger callout and revise copy

94c848c

block the form if we have a repo, but it does not exist

dcf611d

added test to assert that form wizard blocks on validation for not fo…

71b86d7

…und repo

jloleysens added release_note:fix and removed release_note:skip Skip the PR/issue when compiling release notes labels Sep 8, 2020

elasticmachine and others added 3 commits September 8, 2020 02:57

Merge branch 'master' into ilm/fix/pre-existing-policy-with-no-existi…

e104911

…ng-repository

fix types and add a doc comment

0a646d5

yuliacech approved these changes Sep 8, 2020

View reviewed changes

move callout to above the form

4bb3af6

jloleysens merged commit 1c3f0fc into elastic:master Sep 9, 2020

jloleysens deleted the ilm/fix/pre-existing-policy-with-no-existing-repository branch September 9, 2020 13:10

jloleysens mentioned this pull request Sep 9, 2020

[7.x] [Snapshot & Restore] fix pre existing policy with no existing repository (#76861) #77050

Merged

jloleysens mentioned this pull request Sep 9, 2020

[7.9] [Snapshot & Restore] fix pre existing policy with no existing repository (#76861) #77051

Merged

alisonelizabeth mentioned this pull request Apr 19, 2021

[SR] Add error message if repo associated with SLM policy has been deleted #46791

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Snapshot & Restore] fix pre existing policy with no existing repository #76861

[Snapshot & Restore] fix pre existing policy with no existing repository #76861

jloleysens commented Sep 7, 2020 •

edited

Loading

elasticmachine commented Sep 7, 2020

yuliacech left a comment

cjcenizal Sep 8, 2020

jloleysens Sep 8, 2020

cjcenizal commented Sep 8, 2020

jloleysens commented Sep 8, 2020

jloleysens commented Sep 8, 2020

cjcenizal commented Sep 8, 2020 •

edited

Loading

yuliacech left a comment

kibanamachine commented Sep 9, 2020

[Snapshot & Restore] fix pre existing policy with no existing repository #76861

[Snapshot & Restore] fix pre existing policy with no existing repository #76861

Conversation

jloleysens commented Sep 7, 2020 • edited Loading

Summary

Screenshot

Checklist

Release note

elasticmachine commented Sep 7, 2020

yuliacech left a comment

Choose a reason for hiding this comment

cjcenizal Sep 8, 2020

Choose a reason for hiding this comment

jloleysens Sep 8, 2020

Choose a reason for hiding this comment

cjcenizal commented Sep 8, 2020

jloleysens commented Sep 8, 2020

jloleysens commented Sep 8, 2020

cjcenizal commented Sep 8, 2020 • edited Loading

yuliacech left a comment

Choose a reason for hiding this comment

kibanamachine commented Sep 9, 2020

💚 Build Succeeded

Build metrics

async chunks size

History

jloleysens commented Sep 7, 2020 •

edited

Loading

cjcenizal commented Sep 8, 2020 •

edited

Loading