Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUM Dashboard] Visitor breakdown usability #76834

Merged
merged 11 commits into from
Sep 9, 2020

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Sep 6, 2020

Summary

Fixes: #74838

  • Added a legend to the pie charts

  • Changed label to Operating system

  • Changed the order of the slices to clockwiseSectors: false to sort them categorically

  • Used a larger variant of EUI state for the page load duration timings? They're quite small at the moment

  • Split the page load distribution and impressions over time into separate panels

  • Hidden the "device" pie chart for now as the data isn't relevant until we add device type FEATURE: Add field for device type (phone/tablet/etc) to RUM data apm-server#3912

image

@shahzad31 shahzad31 marked this pull request as ready for review September 7, 2020 14:14
@shahzad31 shahzad31 requested a review from a team as a code owner September 7, 2020 14:14
@shahzad31 shahzad31 self-assigned this Sep 7, 2020
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0 labels Sep 7, 2020
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Sep 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested locally with RUM running on my Kibana instance against a number of real and simulated browsers.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
apm 4.9MB +1.2KB 4.9MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit 23e1b74 into elastic:master Sep 9, 2020
@shahzad31 shahzad31 deleted the visitor-breakdown-usability branch September 9, 2020 07:12
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 9, 2020
* master: (68 commits)
  a11y tests on spaces home page including feature control  (elastic#76515)
  [ML] Transforms list: persist pagination through refresh interval (elastic#76786)
  [ML] Replace all use of date_histogram interval with fixed_interval (elastic#76876)
  [Timelion] Update timelion deprecation links (elastic#77008)
  [Security Solution] Refactor Network Details to use Search Strategy (elastic#76928)
  Upgrade elastic charts to 21.1.2 (elastic#76939)
  [Alerting][Connectors] Refactor Jira: Generic Implementation (phase one) (elastic#73778)
  [Snapshot & Restore] fix pre existing policy with no existing repository (elastic#76861)
  Update saved object management UI text (elastic#76826)
  [Form lib] Add validations prop to UseArray and expose "moveItem" handler (elastic#76949)
  [Logs UI] Use fields api in log stream (elastic#76919)
  [UI Metrics] Support multi-colon keys (elastic#76913)
  [APM] Script for creating functional test archive (elastic#76926)
  [ENDPOINT] First version of the trusted apps list. (elastic#76304)
  Correct field for rum page url (elastic#76916)
  [Security Solution] Fix redirect properly old SIEM App routes (elastic#76868)
  Bump http-proxy from 1.17.0 to 1.18.1 (elastic#76924)
  [RUM Dashboard] Visitor breakdown usability (elastic#76834)
  [Search] Add a new advanced setting searchTimeout (elastic#75728)
  [DOCS] Adds timelion deprecation to new visualize docs structure (elastic#76959)
  ...
shahzad31 added a commit to shahzad31/kibana that referenced this pull request Sep 10, 2020
@sorenlouv sorenlouv removed the Team:APM All issues that need APM UI Team support label Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RUM dashboard] visitor breakdown usability improvements
5 participants