Migrate Jest JUnit reporter to TS #79919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylersmalley
force-pushed
the
jest-reporter
branch
2 times, most recently
from
6a51854 to
e5ec519
Compare
tylersmalley
commented
Oct 8, 2020
|
|
||
| root.att({ | ||
| name: 'jest', | ||
| timestamp: msToIso(results.startTime), | ||
| time: msToSec(Date.now() - results.startTime), | ||
| tests: results.numTotalTests, | ||
| failures: results.numFailingTests, | ||
| failures: results.numFailedTests, |
There was a problem hiding this comment.
Was incorrect property.
tylersmalley
commented
Oct 8, 2020
| @@ -55,18 +66,19 @@ export default class JestJUnitReporter { | |||
| 'testsuites', | |||
| { encoding: 'utf-8' }, | |||
| {}, | |||
| { skipNullAttributes: true } | |||
| { keepNullAttributes: false } | |||
There was a problem hiding this comment.
Was incorrect option.
Also moves reporter to @kbn/test package Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
force-pushed
the
jest-reporter
branch
from
e5ec519 to
96b0329
Compare
tylersmalley
changed the title
tylersmalley
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
spalger
approved these changes
Oct 8, 2020
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
tylersmalley
pushed a commit
to tylersmalley/kibana
that referenced
this pull request
Oct 12, 2020
* Converts Jest JUnit reporter to TS Also moves reporter to @kbn/test package Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> # Conflicts: # packages/kbn-test/src/jest/junit_reporter.ts
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 12, 2020
* master: (23 commits) Table visualization renderer (elastic#79455) Migrate Jest JUnit reporter to TS (elastic#79919) store sorted bundleRefExportIds (elastic#80011) update chromedriver dependency to 86.0.0 (elastic#79972) [Security Solution][Case] Fix bug when changing connectors (elastic#80002) [kbn/std] add observable helpers to aid with rxjs 7 upgrade (elastic#79752) [Security Solution][Resolver] Pill numbers in compact notation (elastic#80038) [Logs UI] Sync logs timerange with wider Kibana (elastic#79444) [DOCS] Adds quick start (elastic#78822) [Ingest Manager]Fix ingest manager UI renaming (elastic#80036) [Monitoring] Fixed internal monitoring check (elastic#79241) [Security Solution][Exception Modal] Removes list operators in exception modal for EQL rules (elastic#79871) Update development documentation about REST API best practices (elastic#80009) [Monitoring] Improve indices loading against larger metricbeat-* indices (elastic#79190) [CI] Move kibana build dir outside of repo for functional tests (elastic#80018) [kbn/optimizer] bump low or add missing limits when updating automatically (elastic#80013) [Enterprise Search] Added a Credentials page to App Search (elastic#79749) [DOCS] Canvas refresh for 7.10 (elastic#80017) [TSVB] Add ignore global filters to series options (elastic#79337) Remove this check (elastic#79202) ...
tylersmalley
pushed a commit
that referenced
this pull request
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates the Jest JUnit reporter to Typescript. This exposed issues with the reporter where incorrect options or properties were used. Additionally, this moves the reporter to the
@kbn/testpackage.