Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Case] Fix bug when changing connectors #80002

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented Oct 8, 2020

Summary

This PR closes #79833.

When you change a connector and at the same time you change a field you cannot push the new changes to the connector. You need to do it in two steps, first, change the connector and then change the field.

This PR fixes this issue.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cnasikas cnasikas added bug Fixes for quality problems that affect the customer experience Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.11.0 Team:Threat Hunting Security Solution Threat Hunting Team labels Oct 8, 2020
@cnasikas cnasikas requested review from a team as code owners October 8, 2020 14:09
@cnasikas cnasikas self-assigned this Oct 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@cnasikas cnasikas force-pushed the case_connector_bug branch from 819e534 to 5d55b14 Compare October 8, 2020 14:31
@cnasikas
Copy link
Member Author

cnasikas commented Oct 8, 2020

@elasticmachine merge upstream

@elastic elastic deleted a comment from kibanamachine Oct 8, 2020
@@ -377,5 +385,325 @@ describe('useGetCaseUserActions', () => {
},
});
});

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the bug fix and the thorough test coverage. LGTM!

@cnasikas cnasikas force-pushed the case_connector_bug branch from 4de4012 to 234ea50 Compare October 8, 2020 17:44
@cnasikas cnasikas force-pushed the case_connector_bug branch from 234ea50 to ef85273 Compare October 8, 2020 17:52
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
securitySolution 10.5MB 10.5MB +1.8KB

History

  • 💔 Build #80787 failed 4de4012e5abe9c0fd673980d35cf5dbbc4290dbf

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cnasikas cnasikas merged commit 85ad8a4 into elastic:master Oct 9, 2020
@cnasikas cnasikas deleted the case_connector_bug branch October 9, 2020 06:25
cnasikas added a commit to cnasikas/kibana that referenced this pull request Oct 9, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 12, 2020
* master: (23 commits)
  Table visualization renderer (elastic#79455)
  Migrate Jest JUnit reporter to TS (elastic#79919)
  store sorted bundleRefExportIds (elastic#80011)
  update chromedriver dependency to 86.0.0 (elastic#79972)
  [Security Solution][Case] Fix bug when changing connectors (elastic#80002)
  [kbn/std] add observable helpers to aid with rxjs 7 upgrade (elastic#79752)
  [Security Solution][Resolver] Pill numbers in compact notation (elastic#80038)
  [Logs UI] Sync logs timerange with wider Kibana (elastic#79444)
  [DOCS] Adds quick start (elastic#78822)
  [Ingest Manager]Fix ingest manager UI renaming (elastic#80036)
  [Monitoring] Fixed internal monitoring check (elastic#79241)
  [Security Solution][Exception Modal] Removes list operators in exception modal for EQL rules (elastic#79871)
  Update development documentation about REST API best practices (elastic#80009)
  [Monitoring] Improve indices loading against larger metricbeat-* indices (elastic#79190)
  [CI] Move kibana build dir outside of repo for functional tests (elastic#80018)
  [kbn/optimizer] bump low or add missing limits when updating automatically (elastic#80013)
  [Enterprise Search] Added a Credentials page to App Search (elastic#79749)
  [DOCS] Canvas refresh for 7.10 (elastic#80017)
  [TSVB] Add ignore global filters to series options (elastic#79337)
  Remove this check (elastic#79202)
  ...
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM Team:Threat Hunting Security Solution Threat Hunting Team v7.10.0 v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security Solution][Case] Cannot push to the connector when changing field and connector at the same time
5 participants