[Discover] Fix navigating back when changing index pattern #84061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-23-discover-fix-navigate-back-on-index-pattern-change
kertal
commented
Nov 24, 2020
| @@ -301,8 +302,7 @@ function discoverController($element, $route, $scope, $timeout, $window, Promise | |||
| $scope.state.sort, | |||
| config.get(MODIFY_COLUMNS_ON_SWITCH) | |||
| ); | |||
| await replaceUrlAppState(nextAppState); | |||
| $route.reload(); | |||
There was a problem hiding this comment.
so switching the index pattern is now pushing to the browser history
kertal
commented
Nov 24, 2020
| @@ -264,7 +264,8 @@ function discoverController($element, $route, $scope, $timeout, $window, Promise | |||
| if (!_.isEqual(newStatePartial, oldStatePartial)) { | |||
| $scope.$evalAsync(async () => { | |||
| if (oldStatePartial.index !== newStatePartial.index) { | |||
| //in case of index switch the route has currently to be reloaded, legacy | |||
| //in case of index pattern switch the route has currently to be reloaded, legacy | |||
| $route.reload(); | |||
There was a problem hiding this comment.
when there is a change of index pattern in URL, the route is reloaded, so the new index pattern is selected ... reload is necessary because of other legacy dependencies, and will be no longer necessary in the future, when moving to react router
kertal
added
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
@elasticmachine merge upstream |
…-back-on-index-pattern-change
|
When I tested this in Chrome on Mac OS, I found that after re-selecting an index pattern and navigating back, I'm directed back to home, not a previous index pattern in Discover: |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
majagrubic
approved these changes
Nov 26, 2020
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Nov 26, 2020
kertal
added a commit
that referenced
this pull request
Nov 26, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Nov 30, 2020
* master: [Security Solution] Exceptions Cypress tests (elastic#81759) [ML] Fix spaces job ID check (elastic#84404) [Security Solution][Detections] Handle dupes when processing threshold rules (elastic#83062) skip flaky suite (elastic#84440) skip flaky suite (elastic#84445) [APM] Fix missing `service.node.name` (elastic#84269) Upgrade fp-ts to 2.8.6 (elastic#83866) Added data streams privileges to better control delete actions in UI (elastic#83573) Improve short-url redirect validation (elastic#84366) TSVB offsets (elastic#83051) [Discover] Fix navigating back when changing index pattern (elastic#84061) [Logs UI] Polish the UI for the log entry examples in the anomaly table (elastic#82139) [Logs UI] Limit the height of the "view in context" container (elastic#83178) [Application Usage] Update `schema` with new `fleet` rename (elastic#84327) fix identation in list (elastic#84301)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR restores the functionality of Discover to navigate back and forth selected index patterns using the browser back and forward button.
How to test
Fixes #79872
Checklist