[APM] Fix missing service.node.name
#84269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/apm-ui (Team:apm) |
sorenlouv
commented
Nov 24, 2020
| urlParams, | ||
| agentName, | ||
| serviceNodeName | ||
| ); |
There was a problem hiding this comment.
This was the crux of the problem with missing service.node.name
sorenlouv
commented
Nov 24, 2020
| </EuiFlexGrid> | ||
| <EuiSpacer size="xxl" /> | ||
| </ChartsSyncContextProvider> | ||
| )} |
There was a problem hiding this comment.
For some reason the chart section was duplicated
sorenlouv
commented
Nov 24, 2020
| getCPUChartData(setup, serviceName), | ||
| getMemoryChartData(setup, serviceName), | ||
| getCPUChartData({ setup, serviceName }), | ||
| getMemoryChartData({ setup, serviceName }), |
There was a problem hiding this comment.
The server side changes from here and down are purely stylistic (destructured arguments)
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
|
jenkins run the e2e |
This was referenced Nov 27, 2020
sorenlouv
added a commit
to sorenlouv/kibana
that referenced
this pull request
Nov 27, 2020
# Conflicts: # x-pack/plugins/apm/public/components/app/service_node_metrics/index.tsx
sorenlouv
added a commit
that referenced
this pull request
Nov 27, 2020
sorenlouv
added a commit
that referenced
this pull request
Nov 27, 2020
# Conflicts: # x-pack/plugins/apm/public/components/app/service_node_metrics/index.tsx
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Nov 30, 2020
* master: [Security Solution] Exceptions Cypress tests (elastic#81759) [ML] Fix spaces job ID check (elastic#84404) [Security Solution][Detections] Handle dupes when processing threshold rules (elastic#83062) skip flaky suite (elastic#84440) skip flaky suite (elastic#84445) [APM] Fix missing `service.node.name` (elastic#84269) Upgrade fp-ts to 2.8.6 (elastic#83866) Added data streams privileges to better control delete actions in UI (elastic#83573) Improve short-url redirect validation (elastic#84366) TSVB offsets (elastic#83051) [Discover] Fix navigating back when changing index pattern (elastic#84061) [Logs UI] Polish the UI for the log entry examples in the anomaly table (elastic#82139) [Logs UI] Limit the height of the "view in context" container (elastic#83178) [Application Usage] Update `schema` with new `fleet` rename (elastic#84327) fix identation in list (elastic#84301)
|
tests ok |
cauemarcondes
added
the
apm:test-plan-done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #83935
service.node.namefilter on metrics details page (jvm specific)