-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Upgrade Assistant] Redesign overview page #95346
[Upgrade Assistant] Redesign overview page #95346
Conversation
…erview-redesign
…erview-redesign
…erview-redesign
…erview-redesign
onFilterChange={changeFilter} | ||
onSearchChange={changeSearch} | ||
onFilterChange={(filter: LevelFilterOption) => setCurrentFilter(filter)} | ||
onSearchChange={(newSearch: string) => setSearch(newSearch)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or directly onSearchChange={setSearch}
😊
@alisonelizabeth I'm not sure of a consistent pattern we have for accordions collapsing/expanding across Kibana (we should! and now have it on our "Needs guidelines" list). I'm inclined to say keep the existing behavior. While more clunky, 2 separate buttons is quite obvious. So we can absolutely streamline this, but I'd like to see if we can get some collective thoughts (hopefully quickly) around this that we can apply everywhere. |
.../plugins/upgrade_assistant/public/application/components/es_deprecations/es_deprecations.tsx
Outdated
Show resolved
Hide resolved
.../plugins/upgrade_assistant/public/application/components/es_deprecations/es_deprecations.tsx
Outdated
Show resolved
Hide resolved
...gins/upgrade_assistant/public/application/components/overview/deprecation_logging_toggle.tsx
Outdated
Show resolved
Hide resolved
...gins/upgrade_assistant/public/application/components/overview/deprecation_logging_toggle.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/upgrade_assistant/public/application/components/overview/overview.tsx
Outdated
Show resolved
Hide resolved
.../upgrade_assistant/public/application/components/es_deprecations/deprecation_tab_content.tsx
Outdated
Show resolved
Hide resolved
<p> | ||
<FormattedMessage | ||
id="xpack.upgradeAssistant.checkupTab.noIssues.nextStepsDetail" | ||
defaultMessage="Check the {overviewTabButton} for next steps." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the reference to "steps" here still make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I changed this to: Check the Overview page for other Stack deprecations
. Happy to make any additional changes!
x-pack/plugins/upgrade_assistant/public/application/components/overview/es_stats.tsx
Outdated
Show resolved
Hide resolved
'xpack.upgradeAssistant.esDeprecationErrors.partiallyUpgradedWarningMessage', | ||
{ | ||
defaultMessage: | ||
'One or more Elasticsearch nodes have a newer version of Elasticsearch than Kibana.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reads like Kibana has a version of Elasticsearch.
'One or more Elasticsearch nodes have a newer version of Elasticsearch than Kibana.', | |
'Upgrade Kibana to the same version as your Elasticsearch cluster. One or more nodes in the cluster is running <version xyz> .', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We currently don't have access to the version in this context. It's something we can support, but I think I'd prefer to do so in a separate PR. For now, I've updated this to:
Upgrade Kibana to the same version as your Elasticsearch cluster. One or more nodes in the cluster is running a different version than Kibana.
x-pack/plugins/upgrade_assistant/public/application/lib/es_deprecation_errors.ts
Outdated
Show resolved
Hide resolved
…/es_deprecations/es_deprecations.tsx Co-authored-by: debadair <debadair@elastic.co>
…/es_deprecations/es_deprecations.tsx Co-authored-by: debadair <debadair@elastic.co>
…/overview/deprecation_logging_toggle.tsx Co-authored-by: debadair <debadair@elastic.co>
…/overview/deprecation_logging_toggle.tsx Co-authored-by: debadair <debadair@elastic.co>
…/overview/overview.tsx Co-authored-by: debadair <debadair@elastic.co>
…/es_deprecations/deprecation_tab_content.tsx Co-authored-by: debadair <debadair@elastic.co>
…/overview/overview.tsx Co-authored-by: debadair <debadair@elastic.co>
…recation_errors.ts Co-authored-by: debadair <debadair@elastic.co>
…recation_errors.ts Co-authored-by: debadair <debadair@elastic.co>
…/es_deprecations/deprecation_tab_content.tsx Co-authored-by: debadair <debadair@elastic.co>
…/overview/es_stats.tsx Co-authored-by: debadair <debadair@elastic.co>
…recation_errors.ts Co-authored-by: debadair <debadair@elastic.co>
Thanks for the copy review @debadair! I applied your suggestions and responded to your comment about the message mentioning "steps" on the overview page. |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
I'm going to go ahead and merge this PR. I'm going to leave the deprecation toggle as-is for now, as the UX will likely change again once we support deprecation log indexing (#79208). |
This PR implements the first phase of the Upgrade Assistant redesign: a new Overview page and the start to distinguish between Elasticsearch and other stack (i.e., Kibana) deprecations.
Other notable changes:
What's next
How to test/review
Note for
7.13
, users will still see the "coming soon" prompt. In order to test these changes, you will need to disable that functionality. Inx-pack/plugins/upgrade_assistant/common/constants.ts
, setUA_READONLY_MODE
tofalse
.You can add some mock deprecation data by modifying the response returned from
getUpgradeAssistantStatus()
inx-pack/plugins/upgrade_assistant/server/lib/es_migration_apis.ts
. I've created a gist with some mock data: https://gist.github.com/alisonelizabeth/f093c1464ffd90f9781c42399c758ab4.Screenshots
// Note: This warning callout was pre-existing. It may or may not be applicable anymore depending on which release we decide to re-enable UA. I decided to leave for now.