Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial packaging of tokens for CSS / Jetpack Compose / Swift UI #1

Merged
merged 29 commits into from
Feb 17, 2023
Merged

Initial packaging of tokens for CSS / Jetpack Compose / Swift UI #1

merged 29 commits into from
Feb 17, 2023

Conversation

germain-gg
Copy link
Contributor

  • Add color tokens (system) and typography tokens for Web.
  • Fix references and generate assets

@germain-gg
Fix buggy spacing properties
68562f5 
As a temporary workaround for tokens-studio/sd-transforms#13

This commit needs to be reverted once the issue above has been resolved
@germain-gg
Copy link
Contributor Author

germain-gg commented Feb 13, 2023 •
edited
Loading

This currently has three outstanding issues:

janogarcia and others added 23 commits February 13, 2023 13:35
@janogarcia
Add typography tokens for iOS.
3be0023
@germain-gg
Merge branch 'develop' into janogarcia/ios-typography
3893f81
@germain-gg
Generate iOS tokens
6f31320
@janogarcia
Add core typography tokens for Android
b2366da
@germain-gg
Merge pull request #2 from vector-im/janogarcia/ios-typography
8b270a2
@germain-gg
Generate tokens
9872f37
@germain-gg
Merge pull request #3 from vector-im/janogarcia/android-typography
dcb3400
@germain-gg
Fix Kotlin Output
bbc3503
@janogarcia
- Add font weight variants to composition tokens for Web
91af19c 
- Fix sign for letter spacing values on Web
@janogarcia
Make 0 values unitless.
b3fc0b1
@germain-gg
Add compose transformer for typography token
a3d7e08 
To remove once tokens-studio/sd-transforms#20 has landed
@germain-gg
Add transformers for sp and dp
6311c11
@germain-gg
Generate assets
292872f
@germain-gg
Generate assets
b988924
@germain-gg
Merge pull request #8 from vector-im/janogarcia/ios-typography
0021868
@germain-gg
Merge pull request #7 from vector-im/janogarcia/web-typography
3dc72d4
@germain-gg
Use percentage letter-spacing on Android
2e26128
@germain-gg
Merge pull request #6 from vector-im/janogarcia/android-typography
b100fe2
@germain-gg
Merge branch 'develop' into gsouquet/kotlin-output
4c9ed85
@germain-gg
Add transformer for letter-spacing
6a0f51d
@germain-gg
Simplify fontweight transformer
4fbfe8c
@germain-gg
Finalise naming
106d7ed
@germain-gg
Merge pull request #5 from vector-im/gsouquet/kotlin-output
e6e8509
@germain-gg germain-gg changed the title Add color tokens (system) and typography tokens for Web. Initial packaging of tokens for CSS / Jetpack Compose / Swift UI Feb 17, 2023
@germain-gg germain-gg merged commit 9984df0 into main Feb 17, 2023
@germain-gg germain-gg deleted the develop branch February 17, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janogarcia janogarcia Awaiting requested review from janogarcia

@nadonomy nadonomy Awaiting requested review from nadonomy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@germain-gg @janogarcia