Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental: Mashing text in to the room filter can freeze the whole app #7926

Closed
lampholder opened this issue Dec 20, 2018 · 4 comments
Closed

Experimental: Mashing text in to the room filter can freeze the whole app #7926

lampholder opened this issue Dec 20, 2018 · 4 comments
Assignees
@jryans
Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression

Comments

@lampholder
Copy link
Member

No logs 'cause it ded.

I've seen this now on two occasions; it's occurred when I've mistyped what I'm trying to filter a few times and then mashed a bunch of stuff in frustration (this detail may or may not be important)
@lampholder
Copy link
Member Author

Another clue: the processor goes nuts, so some sort of infinite loop might be occurrign.

@jryans jryans self-assigned this Dec 20, 2018
@jryans
Copy link
Collaborator

jryans commented Dec 20, 2018

From the profile @lampholder shared, this is caused by an infinite loop in _onMoveFocus from LeftPanel.js. I'll keep digging.

@jryans
Copy link
Collaborator

jryans commented Dec 20, 2018

Steps to reproduce:

  1. Enter enough random characters in room filter so that no rooms match
  2. Press the Enter key

jryans added a commit to jryans/matrix-react-sdk that referenced this issue Dec 20, 2018
@jryans
Update room filter focus handling to avoid infinite loop
973fb3b 
The classes on the search box input were changed without updating the focusing
loop in the room filter which used one of these classes as a boundary condition.
This led to a case that could loop forever.

Fixes element-hq/element-web#7926.
@jryans jryans mentioned this issue Dec 20, 2018
Merged
@jryans jryans added T-Defect X-Regression P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Dec 20, 2018
jryans added a commit to jryans/matrix-react-sdk that referenced this issue Dec 20, 2018
@jryans
Update room filter focus handling to avoid infinite loop
3b87be8 
The classes on the search box input were changed without updating the focusing
loop in the room filter which used one of these classes as a boundary condition.
This led to a case that could loop forever.

Regressed by matrix-org#2267.
Fixes element-hq/element-web#7926.
jryans added a commit to jryans/matrix-react-sdk that referenced this issue Dec 20, 2018
@jryans
Update room filter focus handling to avoid infinite loop
00514b1 
The classes on the search box input were changed without updating the focusing
loop in the room filter which used one of these classes as a boundary condition.
This led to a case that could loop forever.

Regressed by matrix-org#2267.
Fixes element-hq/element-web#7926.
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Dec 20, 2018
@jryans
Update room filter focus handling to avoid infinite loop
097d6fd 
The classes on the search box input were changed without updating the focusing
loop in the room filter which used one of these classes as a boundary condition.
This led to a case that could loop forever.

Regressed by #2267.
Fixes element-hq/element-web#7926.
@jryans
Copy link
Collaborator

jryans commented Dec 20, 2018

Fixed by matrix-org/matrix-react-sdk#2380.

@jryans jryans closed this as completed Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jryans @lampholder