This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Redesign: Update room filter focus handling to avoid infinite loop #2380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
approved these changes
Dec 20, 2018
jryans
force-pushed
the
room-filter-exp
branch
from
973fb3b
to
3b87be8
Compare
|
Edited top comment to mention regressing PR. |
The classes on the search box input were changed without updating the focusing loop in the room filter which used one of these classes as a boundary condition. This led to a case that could loop forever. Regressed by matrix-org#2267. Fixes element-hq/element-web#7926.
jryans
force-pushed
the
room-filter-exp
branch
from
3b87be8
to
00514b1
Compare
|
Pushed again just to check the CI fix. Looks like it's working. 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The classes on the search box input were changed without updating the focusing
loop in the room filter which used one of these classes as a boundary condition.
This led to a case that could loop forever.
Regressed by #2267.
Fixes element-hq/element-web#7926.