This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Redesign: bring back & restyle room filter field #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this does the filtering in RoomList instead of RoomSubList, so we can hide sections that don't have any results. The filtering does happen with every rerender of RoomList, but only does something while searching, so the performance implications are probably negligible.
also remove collapse/expand button in search field
text inputs are now styled at every occurence in the app, style input by default, and provide a .mx_textinput class if buttons need to appear inside the input styling. Before this was partially done in _common.scss, but as it's highly theme-dependent, makes more sense to do it in the theme.
as we can reuse it in the room header
jryans
added a commit
to jryans/matrix-react-sdk
that referenced
this pull request
Dec 20, 2018
The classes on the search box input were changed without updating the focusing loop in the room filter which used one of these classes as a boundary condition. This led to a case that could loop forever. Regressed by matrix-org#2267. Fixes element-hq/element-web#7926.
jryans
added a commit
to jryans/matrix-react-sdk
that referenced
this pull request
Dec 20, 2018
The classes on the search box input were changed without updating the focusing loop in the room filter which used one of these classes as a boundary condition. This led to a case that could loop forever. Regressed by matrix-org#2267. Fixes element-hq/element-web#7926.
jryans
added a commit
that referenced
this pull request
Dec 20, 2018
The classes on the search box input were changed without updating the focusing loop in the room filter which used one of these classes as a boundary condition. This led to a case that could loop forever. Regressed by #2267. Fixes element-hq/element-web#7926.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also generic text input styling, see commit messages.
Part of element-hq/element-web#7567 & element-hq/element-web#7559