Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds https://github.com/NullVoxPopuli/rollup-plugin-glimmer-template-tag
However
adding
rollup-plugin-glimmer-template-tag
as a devDependency then requires--typescript
app blueprint using the built-in types, semi-related: WIP: Fix--typescript
flag by bringing in the blueprint, and removing ember-cli-typescript ember-cli/ember-cli#10216(the problem is that the
@types/ember*
packages and the built in types aren't perfectly compatible)@glimmer/component
(I think for types), andwebpack
. for libraries webpack is unreasonable (and unused), but@glimmer/component
, is 🤷 a good number of v2 addons will need it anyway (and is added here) For webpack, we'll want to add apnpm.peerDependencyRules.ignoreMissing
entryTo Test
cd $elsewhere
npx ember-cli@latest addon gjs-addon -b $addonBlueprint/ --skip-npm --skip-git --addon-only
cd gjs-addon
pnpm i
pnpm build