Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a basic implementation of the gjs rollup plugin #1518

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Conversation

mansona
Copy link
Member

@mansona mansona commented Jul 6, 2023

This is just testing out an end-to-end implementation of the swc-based content-tag preprocessor

There are a number of things that need to be done before we can merge this:

If anyone can think of anything else let me know ;)

@mansona mansona force-pushed the swc-content-tag branch 2 times, most recently from ed56362 to c6f0834 Compare July 6, 2023 16:49
@mansona mansona marked this pull request as ready for review July 19, 2023 21:40
@mansona mansona requested a review from a team July 19, 2023 22:58
packages/addon-dev/src/rollup-gjs-plugin.ts Outdated Show resolved Hide resolved
}
}

const gjsFilter = createFilter('**/*.gjs');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you match gts here too (and rename gts to ts the same way you rename gjs to js) it will all just compose correctly for the typescript case too. content-tag already supports both automatically.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so I figured it would be best to transform .gjs to .js files and .gts to .ts files so I expanded the filter and added a bit of code to rename the id correctly

I wanted to have a test but we actually don't have the TS setup correctly on the addon and rollup is complaining 🙈

@mansona mansona added the enhancement New feature or request label Jul 20, 2023
@mansona mansona merged commit 2c0e2bd into main Jul 20, 2023
@mansona mansona deleted the swc-content-tag branch July 20, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants