Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: ld-sidenav-navitem text overflows container in single line mode #942

Closed
3 tasks done
borisdiakur opened this issue Sep 21, 2023 · 0 comments · Fixed by #943
Closed
3 tasks done

bug: ld-sidenav-navitem text overflows container in single line mode #942

borisdiakur opened this issue Sep 21, 2023 · 0 comments · Fixed by #943
Assignees
@borisdiakur
Labels
bug An issue describing unexpected or malicious behaviour. confirmed This label indicates that the issue has been reproduced and verified by the core team. released

Comments

@borisdiakur
Copy link
Contributor

Prerequisites

Liquid version

5.12.1

Framework bindings

no bindings

Current behavior

When using very large words in the ld-sidenav-navitem component the text overflows its container. This only happens in single line mode. There is no issue when used with secondary line.

Screenshot 2023-09-21 at 17 23 15

Expected behavior

In single line mode, the text should wrap and apply an ellipsis on the second line or at least truncate the first line using an ellipsis.

Steps to reproduce

Use a long word in a ld-sidenav-navitem component such as "asdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdf".

Code reproduction URL

https://stackblitz.com/edit/github-5s6mjr?file=index.html

Additional information

No response
@borisdiakur borisdiakur added bug An issue describing unexpected or malicious behaviour. triage An issue that needs assessment to determine its validity and urgency confirmed This label indicates that the issue has been reproduced and verified by the core team. in progress This label indicates that the issue is currently being worked on. and removed triage An issue that needs assessment to determine its validity and urgency labels Sep 21, 2023
@borisdiakur borisdiakur self-assigned this Sep 21, 2023
borisdiakur added a commit that referenced this issue Sep 21, 2023
@borisdiakur
fix(ld-sidenav): truncate long words in nav items
4207771 
Fixes #942
@borisdiakur borisdiakur mentioned this issue Sep 21, 2023
Merged
10 tasks
borisdiakur added a commit that referenced this issue Sep 21, 2023
@borisdiakur
fix(ld-sidenav): truncate long words in nav items
d31779e 
Fixes #942
@borisdiakur borisdiakur removed the in progress This label indicates that the issue is currently being worked on. label Sep 21, 2023
github-actions bot pushed a commit that referenced this issue Sep 21, 2023
@semantic-release-bot
chore(release): 5.12.2 [skip ci]
4b2f96b 
## [5.12.2](v5.12.1...v5.12.2) (2023-09-21)

### Bug Fixes

* **ld-sidenav:** truncate long words in nav header ([a93f496](a93f496))
* **ld-sidenav:** truncate long words in nav items ([d31779e](d31779e)), closes [#942](#942)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@borisdiakur borisdiakur

Labels
bug An issue describing unexpected or malicious behaviour. confirmed This label indicates that the issue has been reproduced and verified by the core team. released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ld-sidenav): truncate long words in nav items emdgroup-liquid/liquid
1 participant
@borisdiakur