Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ld-sidenav): truncate long words in nav items #943

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

borisdiakur
Copy link
Contributor

Description

This PR fixes an issue with long words overflowing their container boundaries in the ld-sidenav-navitem component.

Fixes #942

Type of change

  • Bugfix

Is it a breaking change?

  • No

How Has This Been Tested?

  • e2e tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • New and existing tests pass locally with my changes

@vercel
Copy link

vercel bot commented Sep 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
liquid ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2023 4:34pm

@borisdiakur borisdiakur force-pushed the fix/ld-sidenav_truncate branch from 82952ac to 37c6297 Compare September 21, 2023 16:27
@borisdiakur borisdiakur merged commit a93f496 into main Sep 21, 2023
@borisdiakur borisdiakur deleted the fix/ld-sidenav_truncate branch September 21, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ld-sidenav-navitem text overflows container in single line mode
1 participant